aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSimon Brandhof <simon.brandhof@sonarsource.com>2016-01-30 14:01:58 +0100
committerSimon Brandhof <simon.brandhof@sonarsource.com>2016-01-30 14:01:58 +0100
commitb11816776254f69a0dd7a25c32260b2d77aaa358 (patch)
tree483c9e6fd37e635c307256eaf877a70a97d86725
parent97d1aafc328e6a7e7692cb75f2f85a46594a1aa7 (diff)
downloadsonarqube-b11816776254f69a0dd7a25c32260b2d77aaa358.tar.gz
sonarqube-b11816776254f69a0dd7a25c32260b2d77aaa358.zip
Fix minor quality flaws
-rw-r--r--sonar-db/src/main/java/org/sonar/db/version/v50/FileSourceDto.java2
-rw-r--r--sonar-duplications/src/main/java/net/sourceforge/pmd/cpd/SourceCode.java2
2 files changed, 2 insertions, 2 deletions
diff --git a/sonar-db/src/main/java/org/sonar/db/version/v50/FileSourceDto.java b/sonar-db/src/main/java/org/sonar/db/version/v50/FileSourceDto.java
index b69c0994713..d4135d069e6 100644
--- a/sonar-db/src/main/java/org/sonar/db/version/v50/FileSourceDto.java
+++ b/sonar-db/src/main/java/org/sonar/db/version/v50/FileSourceDto.java
@@ -89,7 +89,7 @@ class FileSourceDto {
Map<Integer, String> duplicationsPerLine = computeDuplicationsPerLine(duplicationGroups);
ByteArrayOutputStream output = new ByteArrayOutputStream();
int line = 0;
- String sourceLine = null;
+ String sourceLine;
CsvWriter csv = CsvWriter.of(new OutputStreamWriter(output, UTF_8));
StringBuilder lineHashes = new StringBuilder();
while (sourceSplitter.hasNext()) {
diff --git a/sonar-duplications/src/main/java/net/sourceforge/pmd/cpd/SourceCode.java b/sonar-duplications/src/main/java/net/sourceforge/pmd/cpd/SourceCode.java
index eae293c0d6f..c124d395535 100644
--- a/sonar-duplications/src/main/java/net/sourceforge/pmd/cpd/SourceCode.java
+++ b/sonar-duplications/src/main/java/net/sourceforge/pmd/cpd/SourceCode.java
@@ -144,7 +144,7 @@ public class SourceCode {
public String getSlice(int startLine, int endLine) {
StringBuffer sb = new StringBuffer();
List lines = cl.getCode();
- for (int i = (startLine == 0 ? startLine : startLine - 1); i < endLine && i < lines.size(); i++) {
+ for (int i = (startLine == 0 ? startLine : (startLine - 1)); i < endLine && i < lines.size(); i++) {
if (sb.length() != 0) {
sb.append(EOL);
}