diff options
author | Simon Brandhof <simon.brandhof@sonarsource.com> | 2015-02-23 07:47:40 +0100 |
---|---|---|
committer | Simon Brandhof <simon.brandhof@sonarsource.com> | 2015-02-23 07:47:40 +0100 |
commit | debb5c4828a05a05812bac2bdc430ed15f28b52d (patch) | |
tree | 51037aae8f3ff06a2487991bb84fb884ba2a1b0d | |
parent | 80c2516938825b56038fed7ae6f65ce3777c5f87 (diff) | |
download | sonarqube-debb5c4828a05a05812bac2bdc430ed15f28b52d.tar.gz sonarqube-debb5c4828a05a05812bac2bdc430ed15f28b52d.zip |
Fix quality flaws
3 files changed, 9 insertions, 6 deletions
diff --git a/server/sonar-process-monitor/src/test/java/org/sonar/process/monitor/MonitorTest.java b/server/sonar-process-monitor/src/test/java/org/sonar/process/monitor/MonitorTest.java index e88b8d49379..e417b5fd268 100644 --- a/server/sonar-process-monitor/src/test/java/org/sonar/process/monitor/MonitorTest.java +++ b/server/sonar-process-monitor/src/test/java/org/sonar/process/monitor/MonitorTest.java @@ -222,11 +222,6 @@ public class MonitorTest { } @Test - public void force_stop_if_too_long() throws Exception { - // TODO - } - - @Test public void fail_to_start_if_bad_class_name() throws Exception { monitor = newDefaultMonitor(); JavaCommand command = new JavaCommand("test") diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/LogInterceptors.java b/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/LogInterceptors.java index a17ab972167..2e13f97b8e9 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/LogInterceptors.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/utils/log/LogInterceptors.java @@ -23,7 +23,7 @@ import com.google.common.base.Preconditions; class LogInterceptors { - private static LogInterceptor instance = NullInterceptor.NULL_INSTANCE; + private static volatile LogInterceptor instance = NullInterceptor.NULL_INSTANCE; private LogInterceptors() { } diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/utils/log/LogInterceptorsTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/utils/log/LogInterceptorsTest.java index 7a5adbe5ca9..d05a4395353 100644 --- a/sonar-plugin-api/src/test/java/org/sonar/api/utils/log/LogInterceptorsTest.java +++ b/sonar-plugin-api/src/test/java/org/sonar/api/utils/log/LogInterceptorsTest.java @@ -20,6 +20,7 @@ package org.sonar.api.utils.log; import org.junit.Test; +import org.sonar.test.TestUtils; import static org.assertj.core.api.Assertions.assertThat; @@ -35,4 +36,11 @@ public class LogInterceptorsTest { public void instance_cant_be_null() throws Exception { LogInterceptors.set(null); } + + @Test + public void private_constructor() throws Exception { + assertThat(TestUtils.hasOnlyPrivateConstructors(LogInterceptors.class)); + } } + + |