aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTeryk Bellahsene <teryk.bellahsene@sonarsource.com>2014-09-30 10:41:45 +0200
committerTeryk Bellahsene <teryk.bellahsene@sonarsource.com>2014-09-30 10:49:58 +0200
commit6c869b7a86a5c1b6e4c9069a956199cc89d20c29 (patch)
tree6984d8448cbba78e4f88dfadaa67db5f87b87faa
parent27ac53be2c275542e703d98545aa94c1431067db (diff)
downloadsonarqube-6c869b7a86a5c1b6e4c9069a956199cc89d20c29.tar.gz
sonarqube-6c869b7a86a5c1b6e4c9069a956199cc89d20c29.zip
Fix quality flaws
-rw-r--r--server/sonar-server/src/main/java/org/sonar/server/computation/db/AnalysisReportDao.java3
-rw-r--r--server/sonar-server/src/test/java/org/sonar/server/computation/db/AnalysisReportDaoTest.java5
2 files changed, 3 insertions, 5 deletions
diff --git a/server/sonar-server/src/main/java/org/sonar/server/computation/db/AnalysisReportDao.java b/server/sonar-server/src/main/java/org/sonar/server/computation/db/AnalysisReportDao.java
index 6b26191e1fd..726eebd22a0 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/computation/db/AnalysisReportDao.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/computation/db/AnalysisReportDao.java
@@ -62,8 +62,7 @@ public class AnalysisReportDao extends BaseDao<AnalysisReportMapper, AnalysisRep
}
public List<AnalysisReportDto> findByProjectKey(DbSession session, String projectKey) {
- List<AnalysisReportDto> analysisReports = mapper(session).selectByProjectKey(projectKey);
- return analysisReports;
+ return mapper(session).selectByProjectKey(projectKey);
}
@Override
diff --git a/server/sonar-server/src/test/java/org/sonar/server/computation/db/AnalysisReportDaoTest.java b/server/sonar-server/src/test/java/org/sonar/server/computation/db/AnalysisReportDaoTest.java
index d442b589b8a..b11cb7cf478 100644
--- a/server/sonar-server/src/test/java/org/sonar/server/computation/db/AnalysisReportDaoTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/computation/db/AnalysisReportDaoTest.java
@@ -38,13 +38,12 @@ import static org.mockito.Mockito.when;
import static org.sonar.core.computation.db.AnalysisReportDto.Status.PENDING;
public class AnalysisReportDaoTest {
+ @Rule
+ public TestDatabase db = new TestDatabase();
private AnalysisReportDao dao;
private DbSession session;
private System2 system2;
- @Rule
- public TestDatabase db = new TestDatabase();
-
@Before
public void before() {
this.session = db.myBatis().openSession(false);