diff options
author | Simon Brandhof <simon.brandhof@sonarsource.com> | 2016-11-11 12:34:11 +0100 |
---|---|---|
committer | Simon Brandhof <simon.brandhof@sonarsource.com> | 2016-11-11 12:34:11 +0100 |
commit | 129d630f52bd531f070969d806166f8c70593751 (patch) | |
tree | bc1810b96c6800b595446c0c02a1fdc4160e893f | |
parent | fcdefb9e0944be78742d18fd3e02a81f882db864 (diff) | |
download | sonarqube-129d630f52bd531f070969d806166f8c70593751.tar.gz sonarqube-129d630f52bd531f070969d806166f8c70593751.zip |
Fix Quality flaws around NPE
3 files changed, 5 insertions, 3 deletions
diff --git a/server/sonar-server/src/main/java/org/sonar/server/plugins/ws/PluginWSCommons.java b/server/sonar-server/src/main/java/org/sonar/server/plugins/ws/PluginWSCommons.java index 2bace234654..63012719a7c 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/plugins/ws/PluginWSCommons.java +++ b/server/sonar-server/src/main/java/org/sonar/server/plugins/ws/PluginWSCommons.java @@ -29,6 +29,7 @@ import java.util.Collections; import java.util.Comparator; import java.util.List; import java.util.Map; +import javax.annotation.CheckForNull; import javax.annotation.Nonnull; import javax.annotation.Nullable; import org.sonar.api.utils.text.JsonWriter; @@ -269,7 +270,8 @@ public class PluginWSCommons { } } - static String categoryOrNull(Plugin plugin) { + @CheckForNull + static String categoryOrNull(@Nullable Plugin plugin) { return plugin != null ? plugin.getCategory() : null; } diff --git a/server/sonar-server/src/main/java/org/sonar/server/qualitygate/ws/DeselectAction.java b/server/sonar-server/src/main/java/org/sonar/server/qualitygate/ws/DeselectAction.java index 29c947d5afa..b90315ff228 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/qualitygate/ws/DeselectAction.java +++ b/server/sonar-server/src/main/java/org/sonar/server/qualitygate/ws/DeselectAction.java @@ -20,7 +20,7 @@ package org.sonar.server.qualitygate.ws; import com.google.common.base.Optional; -import org.elasticsearch.common.Nullable; +import javax.annotation.Nullable; import org.sonar.api.server.ws.Request; import org.sonar.api.server.ws.Response; import org.sonar.api.server.ws.WebService; diff --git a/server/sonar-server/src/main/java/org/sonar/server/qualitygate/ws/SelectAction.java b/server/sonar-server/src/main/java/org/sonar/server/qualitygate/ws/SelectAction.java index c4ea2e424e7..318c11ee04e 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/qualitygate/ws/SelectAction.java +++ b/server/sonar-server/src/main/java/org/sonar/server/qualitygate/ws/SelectAction.java @@ -20,7 +20,7 @@ package org.sonar.server.qualitygate.ws; import com.google.common.base.Optional; -import org.elasticsearch.common.Nullable; +import javax.annotation.Nullable; import org.sonar.api.server.ws.Request; import org.sonar.api.server.ws.Response; import org.sonar.api.server.ws.WebService; |