aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSimon Brandhof <simon.brandhof@sonarsource.com>2017-01-29 16:28:27 +0100
committerSimon Brandhof <simon.brandhof@sonarsource.com>2017-02-01 17:11:52 +0100
commite2fbdcb385cee0bc49260e695b57f03e124f7bc9 (patch)
tree6fa3fea22986c5dcc094a60de51878a549ebea08
parent177413e959ac1efd6e6f0601ecc9b6b5536e6046 (diff)
downloadsonarqube-e2fbdcb385cee0bc49260e695b57f03e124f7bc9.tar.gz
sonarqube-e2fbdcb385cee0bc49260e695b57f03e124f7bc9.zip
SONAR-8716 Remove unused method UserSession#hasGlobalPermission(String)
-rw-r--r--server/sonar-ce/src/main/java/org/sonar/ce/user/CeUserSession.java6
-rw-r--r--server/sonar-server/src/main/java/org/sonar/server/user/AbstractUserSession.java5
-rw-r--r--server/sonar-server/src/main/java/org/sonar/server/user/ThreadLocalUserSession.java5
-rw-r--r--server/sonar-server/src/main/java/org/sonar/server/user/UserSession.java6
-rw-r--r--server/sonar-server/src/test/java/org/sonar/server/tester/UserSessionRule.java5
-rw-r--r--server/sonar-server/src/test/java/org/sonar/server/user/ServerUserSessionTest.java10
6 files changed, 0 insertions, 37 deletions
diff --git a/server/sonar-ce/src/main/java/org/sonar/ce/user/CeUserSession.java b/server/sonar-ce/src/main/java/org/sonar/ce/user/CeUserSession.java
index c67c2880f30..39f6f821fa4 100644
--- a/server/sonar-ce/src/main/java/org/sonar/ce/user/CeUserSession.java
+++ b/server/sonar-ce/src/main/java/org/sonar/ce/user/CeUserSession.java
@@ -19,7 +19,6 @@
*/
package org.sonar.ce.user;
-import java.util.Collection;
import java.util.List;
import java.util.Set;
import org.sonar.db.user.GroupDto;
@@ -101,11 +100,6 @@ public class CeUserSession implements UserSession {
}
@Override
- public boolean hasGlobalPermission(String globalPermission) {
- return notImplementedBooleanMethod();
- }
-
- @Override
public List<String> globalPermissions() {
return notImplemented();
}
diff --git a/server/sonar-server/src/main/java/org/sonar/server/user/AbstractUserSession.java b/server/sonar-server/src/main/java/org/sonar/server/user/AbstractUserSession.java
index 90507535851..a61b44710e1 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/user/AbstractUserSession.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/user/AbstractUserSession.java
@@ -72,11 +72,6 @@ public abstract class AbstractUserSession implements UserSession {
}
@Override
- public boolean hasGlobalPermission(String globalPermission) {
- return isRoot() || hasPermission(globalPermission);
- }
-
- @Override
public UserSession checkComponentPermission(String projectPermission, String componentKey) {
if (!hasComponentPermission(projectPermission, componentKey)) {
throw new ForbiddenException(INSUFFICIENT_PRIVILEGES_MESSAGE);
diff --git a/server/sonar-server/src/main/java/org/sonar/server/user/ThreadLocalUserSession.java b/server/sonar-server/src/main/java/org/sonar/server/user/ThreadLocalUserSession.java
index 2a03c9af16d..db21fb6b49b 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/user/ThreadLocalUserSession.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/user/ThreadLocalUserSession.java
@@ -114,11 +114,6 @@ public class ThreadLocalUserSession implements UserSession {
}
@Override
- public boolean hasGlobalPermission(String globalPermission) {
- return get().hasGlobalPermission(globalPermission);
- }
-
- @Override
public List<String> globalPermissions() {
return get().globalPermissions();
}
diff --git a/server/sonar-server/src/main/java/org/sonar/server/user/UserSession.java b/server/sonar-server/src/main/java/org/sonar/server/user/UserSession.java
index 2eb5b598177..1e3a0515e99 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/user/UserSession.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/user/UserSession.java
@@ -105,12 +105,6 @@ public interface UserSession {
*/
UserSession checkOrganizationPermission(String organizationUuid, String permission);
- /**
- * @deprecated Only used by Views and the Developer Cockpit plugins.
- */
- @Deprecated
- boolean hasGlobalPermission(String globalPermission);
-
List<String> globalPermissions();
/**
diff --git a/server/sonar-server/src/test/java/org/sonar/server/tester/UserSessionRule.java b/server/sonar-server/src/test/java/org/sonar/server/tester/UserSessionRule.java
index fb6f4995c1f..1798c27d534 100644
--- a/server/sonar-server/src/test/java/org/sonar/server/tester/UserSessionRule.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/tester/UserSessionRule.java
@@ -326,11 +326,6 @@ public class UserSessionRule implements TestRule, UserSession {
}
@Override
- public boolean hasGlobalPermission(String globalPermission) {
- return currentUserSession.hasGlobalPermission(globalPermission);
- }
-
- @Override
public boolean hasOrganizationPermission(String organizationUuid, String permission) {
return currentUserSession.hasOrganizationPermission(organizationUuid, permission);
}
diff --git a/server/sonar-server/src/test/java/org/sonar/server/user/ServerUserSessionTest.java b/server/sonar-server/src/test/java/org/sonar/server/user/ServerUserSessionTest.java
index b2f96903a15..a357d6925a5 100644
--- a/server/sonar-server/src/test/java/org/sonar/server/user/ServerUserSessionTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/user/ServerUserSessionTest.java
@@ -309,16 +309,6 @@ public class ServerUserSessionTest {
}
@Test
- public void deprecated_has_global_permission() throws Exception {
- addGlobalPermissions("profileadmin", "admin");
- UserSession session = newUserSession(userDto);
-
- assertThat(session.hasGlobalPermission(QUALITY_PROFILE_ADMIN)).isTrue();
- assertThat(session.hasGlobalPermission(SYSTEM_ADMIN)).isTrue();
- assertThat(session.hasGlobalPermission(QUALITY_GATE_ADMIN)).isFalse();
- }
-
- @Test
public void fail_if_user_dto_is_null() throws Exception {
expectedException.expect(NullPointerException.class);
newUserSession(null);