summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Schwarz <daniel.schwarz@sonarsource.com>2017-09-26 13:05:17 +0200
committerDaniel Schwarz <daniel.schwarz@sonarsource.com>2017-09-26 14:26:50 +0200
commit6ce3647990273f62d0f289ee8db6c135f2718458 (patch)
treef03a0f5e53236ad7ff00b1cc1c68bdc83727a802
parent93f85261cd74c1bc50dc6da02106fabc606f7322 (diff)
downloadsonarqube-6ce3647990273f62d0f289ee8db6c135f2718458.tar.gz
sonarqube-6ce3647990273f62d0f289ee8db6c135f2718458.zip
improved unit test
This avoids false positives in RegisterRuleTest that were caused by unique key collisions of randomly generated keys.
-rw-r--r--server/sonar-server/src/test/java/org/sonar/server/rule/RegisterRulesTest.java9
1 files changed, 5 insertions, 4 deletions
diff --git a/server/sonar-server/src/test/java/org/sonar/server/rule/RegisterRulesTest.java b/server/sonar-server/src/test/java/org/sonar/server/rule/RegisterRulesTest.java
index 94d7440b88d..b3202d0d02e 100644
--- a/server/sonar-server/src/test/java/org/sonar/server/rule/RegisterRulesTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/rule/RegisterRulesTest.java
@@ -190,10 +190,11 @@ public class RegisterRulesTest {
// register many rules
execute(context -> {
RulesDefinition.NewRepository repo = context.createRepository("fake", "java");
- IntStream.range(0, numberOfRules).forEach(i ->
- repo.createRule(randomAlphanumeric(5))
- .setName(randomAlphanumeric(20))
- .setHtmlDescription(randomAlphanumeric(20)));
+ IntStream.range(0, numberOfRules)
+ .mapToObj(i -> "rule-" + i)
+ .forEach(ruleKey -> repo.createRule(ruleKey)
+ .setName(randomAlphanumeric(20))
+ .setHtmlDescription(randomAlphanumeric(20)));
repo.done();
});