SONAR-9356 Rename onboarding setting

2 files changed, 13 insertions, 17 deletions

diff --git a/sonar-core/src/main/java/org/sonar/core/config/CorePropertyDefinitions.java b/sonar-core/src/main/java/org/sonar/core/config/CorePropertyDefinitions.java
index ec0402616c7..9a184cc3f54 100644
--- a/sonar-core/src/main/java/org/sonar/core/config/CorePropertyDefinitions.java
+++ b/sonar-core/src/main/java/org/sonar/core/config/CorePropertyDefinitions.java
@@ -29,6 +29,7 @@ import org.sonar.api.config.EmailSettings;
 import org.sonar.api.config.PropertyDefinition;
 import org.sonar.api.resources.Qualifiers;
 
+import static org.sonar.api.PropertyType.BOOLEAN;
 import static org.sonar.api.database.DatabaseProperties.PROP_PASSWORD;
 
 public class CorePropertyDefinitions {
@@ -45,6 +46,7 @@ public class CorePropertyDefinitions {
   private static final String CATEGORY_ORGANIZATIONS = "organizations";
   public static final String ORGANIZATIONS_ANYONE_CAN_CREATE = "sonar.organizations.anyoneCanCreate";
   public static final String ORGANIZATIONS_CREATE_PERSONAL_ORG = "sonar.organizations.createPersonalOrg";
+  public static final String ONBOARDING_TUTORIAL_SHOW_TO_NEW_USERS = "sonar.onboardingTutorial.showToNewUsers";
 
   private CorePropertyDefinitions() {
     // only static stuff
@@ -120,11 +122,10 @@ public class CorePropertyDefinitions {
         .multiValues(true)
         .defaultValue(CoreProperties.PREVIEW_EXCLUDE_PLUGINS_DEFAULT_VALUE)
         .build(),
-      PropertyDefinition.builder(CoreProperties.SKIP_ONBOARDING_TUTORIAL)
-        .name("Skip the onboarding tutorial")
-        .type(PropertyType.BOOLEAN)
-        .description("By default, each new user is lead through a tutorial, that explains how to analyze a first project, after logging in for the fist time. " +
-          "By enabling this setting, the tutorial will not be shown automatically, but only be visible in the help.")
+      PropertyDefinition.builder(ONBOARDING_TUTORIAL_SHOW_TO_NEW_USERS)
+        .name("Show an onboarding tutorial to new users")
+        .type(BOOLEAN)
+        .description("Show an onboarding tutorial to news, that explains how to analyze a first project, after logging in for the fist time.")
         .category(CoreProperties.CATEGORY_GENERAL)
         .defaultValue(String.valueOf(false))
         .build(),
@@ -135,13 +136,13 @@ public class CorePropertyDefinitions {
       PropertyDefinition.builder("sonar.authenticator.downcase")
         .name("Downcase login")
         .description("Downcase login during user authentication, typically for Active Directory")
-        .type(PropertyType.BOOLEAN)
+        .type(BOOLEAN)
         .defaultValue(String.valueOf(false))
         .hidden()
         .build(),
       PropertyDefinition.builder(CoreProperties.CORE_AUTHENTICATOR_IGNORE_STARTUP_FAILURE)
         .name("Ignore failures during authenticator startup")
-        .type(PropertyType.BOOLEAN)
+        .type(BOOLEAN)
         .defaultValue(String.valueOf(false))
         .hidden()
         .build(),
@@ -149,7 +150,7 @@ public class CorePropertyDefinitions {
         .name("Disable the SCM Sensor")
         .description("Disable the retrieval of blame information from Source Control Manager")
         .category(CoreProperties.CATEGORY_SCM)
-        .type(PropertyType.BOOLEAN)
+        .type(BOOLEAN)
         .onQualifiers(Qualifiers.PROJECT)
         .defaultValue(String.valueOf(false))
         .build(),
@@ -178,7 +179,7 @@ public class CorePropertyDefinitions {
       PropertyDefinition.builder(WebConstants.SONAR_LF_ENABLE_GRAVATAR)
         .name("Enable support of gravatars")
         .description("Gravatars are profile pictures of users based on their email.")
-        .type(PropertyType.BOOLEAN)
+        .type(BOOLEAN)
         .defaultValue(String.valueOf(false))
         .category(CoreProperties.CATEGORY_GENERAL)
         .subCategory(CoreProperties.SUBCATEGORY_LOOKNFEEL)
@@ -236,7 +237,7 @@ public class CorePropertyDefinitions {
         .onQualifiers(Qualifiers.PROJECT)
         .category(CoreProperties.CATEGORY_GENERAL)
         .subCategory(CoreProperties.SUBCATEGORY_DUPLICATIONS)
-        .type(PropertyType.BOOLEAN)
+        .type(BOOLEAN)
         .build(),
       PropertyDefinition.builder(CoreProperties.CPD_EXCLUSIONS)
         .defaultValue("")
@@ -254,14 +255,14 @@ public class CorePropertyDefinitions {
         .name("Allow any authenticated user to create organizations")
         .defaultValue(Boolean.toString(false))
         .category(CATEGORY_ORGANIZATIONS)
-        .type(PropertyType.BOOLEAN)
+        .type(BOOLEAN)
         .hidden()
         .build(),
       PropertyDefinition.builder(ORGANIZATIONS_CREATE_PERSONAL_ORG)
         .name("Create an organization for each new user")
         .defaultValue(Boolean.toString(false))
         .category(CATEGORY_ORGANIZATIONS)
-        .type(PropertyType.BOOLEAN)
+        .type(BOOLEAN)
         .hidden()
         .build()));
     return defs;
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/CoreProperties.java b/sonar-plugin-api/src/main/java/org/sonar/api/CoreProperties.java
index 869022a2758..5400fcb4411 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/CoreProperties.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/CoreProperties.java
@@ -492,9 +492,4 @@ public interface CoreProperties {
    * @since 5.1
    */
   String DEFAULT_ISSUE_ASSIGNEE = "sonar.issues.defaultAssigneeLogin";
-
-  /**
-   * @since 6.5
-   */
-  String SKIP_ONBOARDING_TUTORIAL = "sonar.onboardingTutorial.skip";
 }