aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSimon Brandhof <simon.brandhof@gmail.com>2014-02-03 21:50:31 +0100
committerSimon Brandhof <simon.brandhof@gmail.com>2014-02-03 21:50:31 +0100
commitda8f8285fe77723cf7b07c644366c86b25ca67b1 (patch)
treeb9e16bfca7bec721578ad8501da78033d4a282ff
parent7b73ceaff46a212b53c22e038d684dd108f157be (diff)
downloadsonarqube-da8f8285fe77723cf7b07c644366c86b25ca67b1.tar.gz
sonarqube-da8f8285fe77723cf7b07c644366c86b25ca67b1.zip
Fix some quality flaws
-rw-r--r--sonar-deprecated/src/main/java/org/sonar/api/batch/AbstractDirectoriesDecorator.java2
-rw-r--r--sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/internal/DefaultRule.java2
-rw-r--r--sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleStatus.java2
-rw-r--r--sonar-plugin-api/src/main/java/org/sonar/api/rules/ActiveRule.java1
4 files changed, 3 insertions, 4 deletions
diff --git a/sonar-deprecated/src/main/java/org/sonar/api/batch/AbstractDirectoriesDecorator.java b/sonar-deprecated/src/main/java/org/sonar/api/batch/AbstractDirectoriesDecorator.java
index 3ccc4edae81..cf54bafecdf 100644
--- a/sonar-deprecated/src/main/java/org/sonar/api/batch/AbstractDirectoriesDecorator.java
+++ b/sonar-deprecated/src/main/java/org/sonar/api/batch/AbstractDirectoriesDecorator.java
@@ -36,7 +36,7 @@ public abstract class AbstractDirectoriesDecorator implements Decorator {
/**
* @param language this will be use to defined whether the decorator should be executed on a project
*/
- public AbstractDirectoriesDecorator(Language language) {//NOSONAR this unused parameter is kept for backward-compatibility of API
+ public AbstractDirectoriesDecorator(Language language) {
}
/**
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/internal/DefaultRule.java b/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/internal/DefaultRule.java
index ba3580b2093..784425b5d2a 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/internal/DefaultRule.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/batch/rule/internal/DefaultRule.java
@@ -34,7 +34,7 @@ import java.util.Map;
public class DefaultRule implements Rule {
private final RuleKey key;
- private Integer id;
+ private final Integer id;
private final String name, severity, description, metadata;
private final RuleStatus status;
private final Map<String, RuleParam> params;
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleStatus.java b/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleStatus.java
index 00b97edcd02..d9d95535ceb 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleStatus.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/rule/RuleStatus.java
@@ -28,4 +28,4 @@ public enum RuleStatus {
public static RuleStatus defaultStatus() {
return READY;
}
-} \ No newline at end of file
+}
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/rules/ActiveRule.java b/sonar-plugin-api/src/main/java/org/sonar/api/rules/ActiveRule.java
index 5c21e31b788..55772eac07d 100644
--- a/sonar-plugin-api/src/main/java/org/sonar/api/rules/ActiveRule.java
+++ b/sonar-plugin-api/src/main/java/org/sonar/api/rules/ActiveRule.java
@@ -36,7 +36,6 @@ import java.util.List;
*/
@Entity
@Table(name = "active_rules")
-@Deprecated
public class ActiveRule implements Cloneable {
public static final String INHERITED = "INHERITED";