aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJulien HENRY <julien.henry@sonarsource.com>2017-12-07 15:31:54 +0100
committerJulien HENRY <julien.henry@sonarsource.com>2017-12-07 15:31:54 +0100
commit29901a50874a01a88e05cdf4d0a4fdb6929a507b (patch)
tree797e896240e2448a088cff5139fac27436cee248
parentf5a38606deffb5155f9ee0898e1130a78202eed6 (diff)
downloadsonarqube-29901a50874a01a88e05cdf4d0a4fdb6929a507b.tar.gz
sonarqube-29901a50874a01a88e05cdf4d0a4fdb6929a507b.zip
Revert "SONAR-10176 Fix query of users having a global permission"
This reverts commit f5a38606deffb5155f9ee0898e1130a78202eed6. Was pushed too early by mistake
-rw-r--r--server/sonar-db-dao/src/main/resources/org/sonar/db/permission/AuthorizationMapper.xml2
-rw-r--r--server/sonar-db-dao/src/test/java/org/sonar/db/permission/AuthorizationDaoTest.java3
2 files changed, 0 insertions, 5 deletions
diff --git a/server/sonar-db-dao/src/main/resources/org/sonar/db/permission/AuthorizationMapper.xml b/server/sonar-db-dao/src/main/resources/org/sonar/db/permission/AuthorizationMapper.xml
index 3df9e766e1e..60f105b4ede 100644
--- a/server/sonar-db-dao/src/main/resources/org/sonar/db/permission/AuthorizationMapper.xml
+++ b/server/sonar-db-dao/src/main/resources/org/sonar/db/permission/AuthorizationMapper.xml
@@ -385,7 +385,6 @@
inner join users u on u.id=ur.user_id
where
ur.role=#{permission,jdbcType=VARCHAR}
- and ur.resource_id is null
union
@@ -395,7 +394,6 @@
inner join users u on u.id=gu.user_id
where
gr.role = #{permission,jdbcType=VARCHAR} and
- gr.resource_id is null and
gr.group_id is not null
</select>
diff --git a/server/sonar-db-dao/src/test/java/org/sonar/db/permission/AuthorizationDaoTest.java b/server/sonar-db-dao/src/test/java/org/sonar/db/permission/AuthorizationDaoTest.java
index 2e6ba70c1e2..951f8011a03 100644
--- a/server/sonar-db-dao/src/test/java/org/sonar/db/permission/AuthorizationDaoTest.java
+++ b/server/sonar-db-dao/src/test/java/org/sonar/db/permission/AuthorizationDaoTest.java
@@ -1021,11 +1021,8 @@ public class AuthorizationDaoTest {
UserDto user3 = db.users().insertUser();
db.users().insertMember(administratorGroup2, user3);
- ComponentDto project = db.components().insertPrivateProject();
-
UserDto user4 = db.users().insertUser();
db.users().insertPermissionOnUser(organization1, user4, ADMINISTER_QUALITY_PROFILES);
- db.users().insertProjectPermissionOnUser(user4, "admin", project);
db.users().insertUser();
List<String> logins = underTest.selectGlobalAdministratorLogins(dbSession);