aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSébastien Lesaint <sebastien.lesaint@sonarsource.com>2015-09-17 16:37:05 +0200
committerSébastien Lesaint <sebastien.lesaint@sonarsource.com>2015-09-22 17:20:56 +0200
commit2d4280fc1cdafa8c7fb37239819d58cd580b9f2b (patch)
tree7843bdad1dd14ec3906b1349a59b91e877ad9e4d
parentb036a69f088d54ba962b54b26f1f972f41fcfd1b (diff)
downloadsonarqube-2d4280fc1cdafa8c7fb37239819d58cd580b9f2b.tar.gz
sonarqube-2d4280fc1cdafa8c7fb37239819d58cd580b9f2b.zip
small optimisation in NewCoverageMeasuresStep
we used to create a Date from a long value to only use Date#getTime; remove useless creation of the Date object
-rw-r--r--server/sonar-server/src/main/java/org/sonar/server/computation/step/NewCoverageMeasuresStep.java9
1 files changed, 4 insertions, 5 deletions
diff --git a/server/sonar-server/src/main/java/org/sonar/server/computation/step/NewCoverageMeasuresStep.java b/server/sonar-server/src/main/java/org/sonar/server/computation/step/NewCoverageMeasuresStep.java
index d3da00d000c..7236e9f8278 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/computation/step/NewCoverageMeasuresStep.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/computation/step/NewCoverageMeasuresStep.java
@@ -23,7 +23,6 @@ import com.google.common.base.Optional;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterables;
import java.util.Collections;
-import java.util.Date;
import java.util.List;
import java.util.Map;
import javax.annotation.CheckForNull;
@@ -387,7 +386,7 @@ public class NewCoverageMeasuresStep implements ComputationStep {
int conditions = (Integer) ObjectUtils.defaultIfNull(conditionsByLine.get(lineId), 0);
int coveredConditions = (Integer) ObjectUtils.defaultIfNull(coveredConditionsByLine.get(lineId), 0);
BatchReport.Changesets.Changeset changeset = componentScm.getChangeset(componentScm.getChangesetIndexByLine(lineId - 1));
- Date date = changeset.hasDate() ? new Date(changeset.getDate()) : null;
+ Long date = changeset.hasDate() ? changeset.getDate() : null;
analyze(context.getPeriods(), date, hits, conditions, coveredConditions);
}
@@ -400,7 +399,7 @@ public class NewCoverageMeasuresStep implements ComputationStep {
return Collections.emptyMap();
}
- public void analyze(List<Period> periods, @Nullable Date lineDate, int hits, int conditions, int coveredConditions) {
+ public void analyze(List<Period> periods, @Nullable Long lineDate, int hits, int conditions, int coveredConditions) {
if (lineDate == null) {
return;
}
@@ -415,8 +414,8 @@ public class NewCoverageMeasuresStep implements ComputationStep {
/**
* A line belongs to a Period if its date is older than the SNAPSHOT's date of the period.
*/
- private static boolean isLineInPeriod(Date lineDate, Period period) {
- return lineDate.getTime() > period.getSnapshotDate();
+ private static boolean isLineInPeriod(long lineDate, Period period) {
+ return lineDate > period.getSnapshotDate();
}
private void incrementLines(Period period, int hits) {