diff options
author | Simon Brandhof <simon.brandhof@sonarsource.com> | 2019-05-12 17:27:40 +0200 |
---|---|---|
committer | SonarTech <sonartech@sonarsource.com> | 2019-05-22 20:21:19 +0200 |
commit | 81cd843cf04908c817d982ccbd825f545eb38390 (patch) | |
tree | 1c075edc20ebb5a94702926307192f6ae7a7334e | |
parent | 8e51dfd985545cb0b686dcee0a8a225e6cbeb15c (diff) | |
download | sonarqube-81cd843cf04908c817d982ccbd825f545eb38390.tar.gz sonarqube-81cd843cf04908c817d982ccbd825f545eb38390.zip |
SONAR-11950 autoconfig of SCM revision on Github Actions
3 files changed, 141 insertions, 0 deletions
diff --git a/sonar-scanner-engine/src/main/java/org/sonar/scanner/ci/vendors/GithubActions.java b/sonar-scanner-engine/src/main/java/org/sonar/scanner/ci/vendors/GithubActions.java new file mode 100644 index 00000000000..e05c1777857 --- /dev/null +++ b/sonar-scanner-engine/src/main/java/org/sonar/scanner/ci/vendors/GithubActions.java @@ -0,0 +1,64 @@ +/* + * SonarQube + * Copyright (C) 2009-2019 SonarSource SA + * mailto:info AT sonarsource DOT com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 3 of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with this program; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + */ +package org.sonar.scanner.ci.vendors; + +import org.apache.commons.lang.StringUtils; +import org.sonar.api.utils.System2; +import org.sonar.api.utils.log.Loggers; +import org.sonar.scanner.ci.CiConfiguration; +import org.sonar.scanner.ci.CiConfigurationImpl; +import org.sonar.scanner.ci.CiVendor; + +import static org.apache.commons.lang.StringUtils.isEmpty; + +/** + * Support of https://github.com/features/actions + * + * Environment variables: https://developer.github.com/actions/creating-github-actions/accessing-the-runtime-environment/#environment-variables + */ +public class GithubActions implements CiVendor { + + private static final String PROPERTY_COMMIT = "GITHUB_SHA"; + + private final System2 system; + + public GithubActions(System2 system) { + this.system = system; + } + + @Override + public String getName() { + return "Github Actions"; + } + + @Override + public boolean isDetected() { + return StringUtils.isNotBlank(system.envVariable("GITHUB_ACTION")); + } + + @Override + public CiConfiguration loadConfiguration() { + String revision = system.envVariable(PROPERTY_COMMIT); + if (isEmpty(revision)) { + Loggers.get(getClass()).warn("Missing environment variable " + PROPERTY_COMMIT); + } + return new CiConfigurationImpl(revision); + } +} diff --git a/sonar-scanner-engine/src/main/java/org/sonar/scanner/scan/ProjectScanContainer.java b/sonar-scanner-engine/src/main/java/org/sonar/scanner/scan/ProjectScanContainer.java index cbffd780c3b..1a8807f142d 100644 --- a/sonar-scanner-engine/src/main/java/org/sonar/scanner/scan/ProjectScanContainer.java +++ b/sonar-scanner-engine/src/main/java/org/sonar/scanner/scan/ProjectScanContainer.java @@ -53,6 +53,7 @@ import org.sonar.scanner.ci.vendors.Buildkite; import org.sonar.scanner.ci.vendors.CircleCi; import org.sonar.scanner.ci.vendors.CirrusCi; import org.sonar.scanner.ci.vendors.DroneCi; +import org.sonar.scanner.ci.vendors.GithubActions; import org.sonar.scanner.ci.vendors.Jenkins; import org.sonar.scanner.ci.vendors.SemaphoreCi; import org.sonar.scanner.cpd.CpdExecutor; @@ -279,6 +280,7 @@ public class ProjectScanContainer extends ComponentContainer { CircleCi.class, CirrusCi.class, DroneCi.class, + GithubActions.class, Jenkins.class, SemaphoreCi.class, diff --git a/sonar-scanner-engine/src/test/java/org/sonar/scanner/ci/vendors/GithubActionsTest.java b/sonar-scanner-engine/src/test/java/org/sonar/scanner/ci/vendors/GithubActionsTest.java new file mode 100644 index 00000000000..a49d4e99ce3 --- /dev/null +++ b/sonar-scanner-engine/src/test/java/org/sonar/scanner/ci/vendors/GithubActionsTest.java @@ -0,0 +1,75 @@ +/* + * SonarQube + * Copyright (C) 2009-2019 SonarSource SA + * mailto:info AT sonarsource DOT com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 3 of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with this program; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + */ +package org.sonar.scanner.ci.vendors; + +import javax.annotation.Nullable; +import org.junit.Rule; +import org.junit.Test; +import org.sonar.api.utils.System2; +import org.sonar.api.utils.log.LogTester; +import org.sonar.api.utils.log.LoggerLevel; +import org.sonar.scanner.ci.CiVendor; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.when; + +public class GithubActionsTest { + + @Rule + public LogTester logs = new LogTester(); + + private System2 system = mock(System2.class); + private CiVendor underTest = new GithubActions(system); + + @Test + public void getName() { + assertThat(underTest.getName()).isEqualTo("Github Actions"); + } + + @Test + public void isDetected() { + setEnvVariable("GITHUB_ACTION", "build"); + assertThat(underTest.isDetected()).isTrue(); + + setEnvVariable("GITHUB_ACTION", null); + assertThat(underTest.isDetected()).isFalse(); + } + + @Test + public void loadConfiguration() { + setEnvVariable("GITHUB_ACTION", "build"); + setEnvVariable("GITHUB_SHA", "abd12fc"); + + assertThat(underTest.loadConfiguration().getScmRevision()).hasValue("abd12fc"); + } + + @Test + public void log_warning_if_missing_GITHUB_SHA() { + setEnvVariable("GITHUB_ACTION", "build"); + + assertThat(underTest.loadConfiguration().getScmRevision()).isEmpty(); + assertThat(logs.logs(LoggerLevel.WARN)).contains("Missing environment variable GITHUB_SHA"); + } + + private void setEnvVariable(String key, @Nullable String value) { + when(system.envVariable(key)).thenReturn(value); + } +} |