diff options
author | Simon Brandhof <simon.brandhof@gmail.com> | 2011-12-14 17:41:48 +0100 |
---|---|---|
committer | Simon Brandhof <simon.brandhof@gmail.com> | 2011-12-14 17:41:48 +0100 |
commit | a547283bb4bb430ad7ea7a457bd6c9c5274efd7d (patch) | |
tree | 864ab8b6dda146e0a8216d0cbebab24539bd7ff6 | |
parent | cd19885928f5aae1e8b1663eb45dd301b46ccb49 (diff) | |
download | sonarqube-a547283bb4bb430ad7ea7a457bd6c9c5274efd7d.tar.gz sonarqube-a547283bb4bb430ad7ea7a457bd6c9c5274efd7d.zip |
Decrease visibility of some methods of org.sonar.persistence.review.ReviewQuery
-rw-r--r-- | sonar-core/src/main/java/org/sonar/persistence/review/ReviewQuery.java | 4 | ||||
-rw-r--r-- | sonar-core/src/test/java/org/sonar/persistence/review/ReviewDaoTest.java | 5 |
2 files changed, 2 insertions, 7 deletions
diff --git a/sonar-core/src/main/java/org/sonar/persistence/review/ReviewQuery.java b/sonar-core/src/main/java/org/sonar/persistence/review/ReviewQuery.java index 8f3cdda15bb..ed649d62840 100644 --- a/sonar-core/src/main/java/org/sonar/persistence/review/ReviewQuery.java +++ b/sonar-core/src/main/java/org/sonar/persistence/review/ReviewQuery.java @@ -128,11 +128,11 @@ public final class ReviewQuery { return this; } - protected boolean needToPartitionQuery() { + boolean needToPartitionQuery() { return violationPermanentIds != null && violationPermanentIds.size() > DatabaseUtils.MAX_IN_ELEMENTS; } - public ReviewQuery[] partition() { + ReviewQuery[] partition() { List<List<Integer>> partitions = Lists.partition(violationPermanentIds, DatabaseUtils.MAX_IN_ELEMENTS); ReviewQuery[] result = new ReviewQuery[partitions.size()]; for (int index = 0; index < partitions.size(); index++) { diff --git a/sonar-core/src/test/java/org/sonar/persistence/review/ReviewDaoTest.java b/sonar-core/src/test/java/org/sonar/persistence/review/ReviewDaoTest.java index 4e776f276a6..18c9beb948d 100644 --- a/sonar-core/src/test/java/org/sonar/persistence/review/ReviewDaoTest.java +++ b/sonar-core/src/test/java/org/sonar/persistence/review/ReviewDaoTest.java @@ -25,9 +25,6 @@ import org.hamcrest.Description; import org.junit.Before; import org.junit.Test; import org.sonar.persistence.DaoTestCase; -import org.sonar.persistence.review.ReviewDao; -import org.sonar.persistence.review.ReviewDto; -import org.sonar.persistence.review.ReviewQuery; import java.util.List; @@ -131,8 +128,6 @@ public class ReviewDaoTest extends DaoTestCase { public boolean matches(Object o) { ReviewDto reviewDto = (ReviewDto) o; - System.out.println(reviewDto.getViolationPermanentId()); - return expectedId.equals(reviewDto.getViolationPermanentId()); } |