aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFabrice Bellingard <bellingard@gmail.com>2012-05-14 09:22:55 +0200
committerFabrice Bellingard <bellingard@gmail.com>2012-05-14 15:11:02 +0200
commitc633a0a8b7131857f13943266e0eea38523cdf8a (patch)
tree28f50adce6fdce11fc62075f0e1575633c4f65a0
parentd70279f853cecc9e0f8c4abee82eff8801e481b6 (diff)
downloadsonarqube-c633a0a8b7131857f13943266e0eea38523cdf8a.tar.gz
sonarqube-c633a0a8b7131857f13943266e0eea38523cdf8a.zip
SONAR-2706 Add loading icon as the linking action can be long
-rw-r--r--sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_review_command_form.html.erb3
-rw-r--r--sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_comment_form.html.erb3
2 files changed, 6 insertions, 0 deletions
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_review_command_form.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_review_command_form.html.erb
index cc4ff3bb746..285bfcc4611 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_review_command_form.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/project_reviews/_review_command_form.html.erb
@@ -7,7 +7,10 @@
@review_command.getName(),
:url => {:action => 'run_review_command'},
:html => {:id => "submit_btn"},
+ :loading => "$('loading').show();",
:update => 'review' -%>
&nbsp;
<%= link_to_remote message('cancel'), :url => {:action => 'show', :id => params[:id]}, :update => 'review' -%>
+ &nbsp;
+ <span id="loading" style="display: none;"><%= image_tag 'loading.gif' -%></span>
</form>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_comment_form.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_comment_form.html.erb
index fcf463c4d9e..3180334ab96 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_comment_form.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_violation_comment_form.html.erb
@@ -37,8 +37,11 @@
button_label,
:url => {:action => 'violation_save_comment'},
:html => {:id => "submit_btn"+params[:id]}.merge(@review_command ? {} : {:disabled => "true"}),
+ :loading => "$('loading-#{params[:id]}').show();",
:update => 'vId'+params[:id] -%>
&nbsp;
<%= link_to_function message('cancel'), "cancelViolationAction(#{params[:id]})" -%>
+ &nbsp;
+ <span id="loading-<%= params[:id] -%>" style="display: none;"><%= image_tag 'loading.gif' -%></span>
</div>
</form>