diff options
| author | Jeremy Davis <jeremy.davis@sonarsource.com> | 2022-09-22 11:46:12 +0200 |
|---|---|---|
| committer | sonartech <sonartech@sonarsource.com> | 2022-09-22 20:03:33 +0000 |
| commit | d5ba777fbeaf073990cdc0dcb904cbe38d5aebb5 (patch) | |
| tree | dec0ad07cc4c0ac5e44bac15ea620fbb777248a1 | |
| parent | 6016243876d28339736e661f6f88dedb693c177e (diff) | |
| download | sonarqube-d5ba777fbeaf073990cdc0dcb904cbe38d5aebb5.tar.gz sonarqube-d5ba777fbeaf073990cdc0dcb904cbe38d5aebb5.zip | |
SONAR-16906 [893103] Buttons must have discernible text
3 files changed, 5 insertions, 1 deletions
diff --git a/server/sonar-web/src/main/js/components/SourceViewer/SourceViewerHeader.tsx b/server/sonar-web/src/main/js/components/SourceViewer/SourceViewerHeader.tsx index eed5622d773..3b701394c64 100644 --- a/server/sonar-web/src/main/js/components/SourceViewer/SourceViewerHeader.tsx +++ b/server/sonar-web/src/main/js/components/SourceViewer/SourceViewerHeader.tsx @@ -233,7 +233,7 @@ export default class SourceViewerHeader extends React.PureComponent<Props, State </ul> } overlayPlacement={PopupPlacement.BottomRight}> - <ButtonIcon className="js-actions"> + <ButtonIcon className="js-actions" aria-label={translate('component_viewer.action_menu')}> <ListIcon /> </ButtonIcon> </Dropdown> diff --git a/server/sonar-web/src/main/js/components/SourceViewer/__tests__/__snapshots__/SourceViewerHeader-test.tsx.snap b/server/sonar-web/src/main/js/components/SourceViewer/__tests__/__snapshots__/SourceViewerHeader-test.tsx.snap index db63a2fa2b5..032a2196c26 100644 --- a/server/sonar-web/src/main/js/components/SourceViewer/__tests__/__snapshots__/SourceViewerHeader-test.tsx.snap +++ b/server/sonar-web/src/main/js/components/SourceViewer/__tests__/__snapshots__/SourceViewerHeader-test.tsx.snap @@ -107,6 +107,7 @@ exports[`should render correctly for a regular file 1`] = ` overlayPlacement="bottom-right" > <ButtonIcon + aria-label="component_viewer.action_menu" className="js-actions" > <ListIcon /> @@ -240,6 +241,7 @@ exports[`should render correctly for a unit test 1`] = ` overlayPlacement="bottom-right" > <ButtonIcon + aria-label="component_viewer.action_menu" className="js-actions" > <ListIcon /> @@ -504,6 +506,7 @@ exports[`should render correctly if issue details are passed 1`] = ` overlayPlacement="bottom-right" > <ButtonIcon + aria-label="component_viewer.action_menu" className="js-actions" > <ListIcon /> diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties index 9fe2a9d9d77..b0ee0fb6e02 100644 --- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties +++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties @@ -2856,6 +2856,7 @@ component_viewer.file_measures=File measures component_viewer.show_all_measures=Show all measures component_viewer.no_component=The component has been removed or never existed. component_viewer.copy_path_to_clipboard=Copy the file path to the clipboard +component_viewer.action_menu=File actions menu source_viewer.view_all_issues=See all issues in this file source_viewer.expand_all_lines=Show all lines of code |