diff options
| author | Sarath Nair <91882341+sarath-nair-sonarsource@users.noreply.github.com> | 2024-09-25 12:00:35 +0200 |
|---|---|---|
| committer | sonartech <sonartech@sonarsource.com> | 2024-09-25 20:02:55 +0000 |
| commit | d83706dfc84508524cf9dd879745eaaae507d85a (patch) | |
| tree | a734215bfb08ef89796ae2b86abe8137f0d42cee | |
| parent | 7ff1ec1bbaf6a8b82b83e96600012f4bb2cf8a0c (diff) | |
| download | sonarqube-d83706dfc84508524cf9dd879745eaaae507d85a.tar.gz sonarqube-d83706dfc84508524cf9dd879745eaaae507d85a.zip | |
SONAR-22764 Do not show project bind hint for non projects (#11850)
2 files changed, 17 insertions, 1 deletions
diff --git a/server/sonar-web/src/main/js/apps/permissions/project/components/PageHeader.tsx b/server/sonar-web/src/main/js/apps/permissions/project/components/PageHeader.tsx index 80aa2ec2b75..419e7b6a536 100644 --- a/server/sonar-web/src/main/js/apps/permissions/project/components/PageHeader.tsx +++ b/server/sonar-web/src/main/js/apps/permissions/project/components/PageHeader.tsx @@ -109,7 +109,7 @@ export default function PageHeader(props: Readonly<Props>) { </div> </> )} - {githubProvisioningStatus && !isGitHubProject && ( + {githubProvisioningStatus && !isGitHubProject && isProject(component.qualifier) && ( <FlagMessage variant="warning" className="sw-mt-2"> {translate('project_permission.local_project_with_github_provisioning')} </FlagMessage> diff --git a/server/sonar-web/src/main/js/apps/permissions/project/components/__tests__/PermissionsProject-it.tsx b/server/sonar-web/src/main/js/apps/permissions/project/components/__tests__/PermissionsProject-it.tsx index e7e2585b60d..c1d2be79d89 100644 --- a/server/sonar-web/src/main/js/apps/permissions/project/components/__tests__/PermissionsProject-it.tsx +++ b/server/sonar-web/src/main/js/apps/permissions/project/components/__tests__/PermissionsProject-it.tsx @@ -449,6 +449,22 @@ describe('GitHub provisioning', () => { .every((item) => item.getAttributeNames().includes('disabled')), ).toBe(false); }); + + it.each([ComponentQualifier.Portfolio, ComponentQualifier.Application])( + 'shoudlnt show sync warning for portfolio and applications', + async (qualifier) => { + const user = userEvent.setup(); + const ui = getPageObject(user); + dopTranslationHandler.gitHubConfigurations.push( + mockGitHubConfiguration({ provisioningType: ProvisioningType.auto }), + ); + renderPermissionsProjectApp({ qualifier }, { featureList: [Feature.GithubProvisioning] }); + await ui.appLoaded(); + + expect(ui.pageTitle.get()).toBeInTheDocument(); + expect(ui.nonGHProjectWarning.query()).not.toBeInTheDocument(); + }, + ); }); describe('GitLab provisioning', () => { |