aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephane Gamard <stephane.gamard@sonarsource.com>2014-10-14 15:41:28 +0200
committerStephane Gamard <stephane.gamard@sonarsource.com>2014-10-15 09:48:03 +0200
commit25e47d9f694fc9805e1ac20930abdd1b514d3cac (patch)
tree774857c90d1ea21054bf1edab0551c003e5ccf10
parent390b84dc29bd0f6d6b4726ffff80f72535419f54 (diff)
downloadsonarqube-25e47d9f694fc9805e1ac20930abdd1b514d3cac.tar.gz
sonarqube-25e47d9f694fc9805e1ac20930abdd1b514d3cac.zip
removed un-necessary try/catch
-rw-r--r--server/sonar-server/src/main/java/org/sonar/server/db/BaseDao.java14
-rw-r--r--server/sonar-server/src/test/java/org/sonar/server/component/db/ComponentDaoTest.java3
2 files changed, 7 insertions, 10 deletions
diff --git a/server/sonar-server/src/main/java/org/sonar/server/db/BaseDao.java b/server/sonar-server/src/main/java/org/sonar/server/db/BaseDao.java
index 71426bec541..b9f51f14b41 100644
--- a/server/sonar-server/src/main/java/org/sonar/server/db/BaseDao.java
+++ b/server/sonar-server/src/main/java/org/sonar/server/db/BaseDao.java
@@ -360,15 +360,11 @@ public abstract class BaseDao<MAPPER, DTO extends Dto<KEY>, KEY extends Serializ
LOGGER.warn("Synchronizer should only be used with BatchSession!");
}
- try {
- DbSynchronizationHandler handler = getSynchronizationResultHandler(session, params);
- session.select(getSynchronizeStatementFQN(), getSynchronizationParams(date, params), handler);
- handler.enqueueCollected();
- session.enqueue(new RefreshIndex(this.getIndexType()));
- session.commit();
- } catch (Exception e) {
- throw new IllegalStateException(e);
- }
+ DbSynchronizationHandler handler = getSynchronizationResultHandler(session, params);
+ session.select(getSynchronizeStatementFQN(), getSynchronizationParams(date, params), handler);
+ handler.enqueueCollected();
+ session.enqueue(new RefreshIndex(this.getIndexType()));
+ session.commit();
}
private String getSynchronizeStatementFQN() {
diff --git a/server/sonar-server/src/test/java/org/sonar/server/component/db/ComponentDaoTest.java b/server/sonar-server/src/test/java/org/sonar/server/component/db/ComponentDaoTest.java
index bb492c16a0b..19017b84411 100644
--- a/server/sonar-server/src/test/java/org/sonar/server/component/db/ComponentDaoTest.java
+++ b/server/sonar-server/src/test/java/org/sonar/server/component/db/ComponentDaoTest.java
@@ -19,6 +19,7 @@
*/
package org.sonar.server.component.db;
+import org.apache.ibatis.exceptions.PersistenceException;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
@@ -362,7 +363,7 @@ public class ComponentDaoTest extends AbstractDaoTestCase {
checkTable("delete", "projects");
}
- @Test(expected = IllegalStateException.class)
+ @Test(expected = PersistenceException.class)
public void synchronize_after() {
dao.synchronizeAfter(session, new Date(0L));
}