aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeremy Davis <jeremy.davis@sonarsource.com>2019-11-07 20:02:10 +0900
committerSonarTech <sonartech@sonarsource.com>2019-11-08 20:21:12 +0100
commit615f9bf88a4a1e0fed0818fb8ff01848865ae99a (patch)
tree5da3e038715839fd92d13ab50b8b220038d15b7f
parentcb3209eefa3f943524effb7b0d4f03c4bf9a45f6 (diff)
downloadsonarqube-615f9bf88a4a1e0fed0818fb8ff01848865ae99a.tar.gz
sonarqube-615f9bf88a4a1e0fed0818fb8ff01848865ae99a.zip
SONAR-12537 Update See rule button in issues page
-rw-r--r--server/sonar-web/src/main/js/components/issue/Issue.css5
-rw-r--r--server/sonar-web/src/main/js/components/issue/components/IssueMessage.tsx5
-rw-r--r--server/sonar-web/src/main/js/components/issue/components/__tests__/__snapshots__/IssueMessage-test.tsx.snap4
3 files changed, 10 insertions, 4 deletions
diff --git a/server/sonar-web/src/main/js/components/issue/Issue.css b/server/sonar-web/src/main/js/components/issue/Issue.css
index d46b2d7e948..88cd8b45282 100644
--- a/server/sonar-web/src/main/js/components/issue/Issue.css
+++ b/server/sonar-web/src/main/js/components/issue/Issue.css
@@ -97,6 +97,11 @@
white-space: nowrap;
}
+.issue-see-rule {
+ border-bottom: none;
+ line-height: 16px;
+}
+
.issue-changelog {
width: 450px;
max-height: 320px;
diff --git a/server/sonar-web/src/main/js/components/issue/components/IssueMessage.tsx b/server/sonar-web/src/main/js/components/issue/components/IssueMessage.tsx
index dba797fae45..22c91a6c916 100644
--- a/server/sonar-web/src/main/js/components/issue/components/IssueMessage.tsx
+++ b/server/sonar-web/src/main/js/components/issue/components/IssueMessage.tsx
@@ -43,13 +43,14 @@ export default class IssueMessage extends React.PureComponent<Props> {
render() {
return (
<div className="issue-message">
- <span className="little-spacer-right">{this.props.message}</span>
+ <span className="spacer-right">{this.props.message}</span>
<Button
aria-label={translate('issue.rule_details')}
- className="button button-grey button-tiny spacer-right text-top"
+ className="button button-link issue-see-rule spacer-right text-top"
onClick={this.handleClick}>
{translate('issue.see_rule')}
</Button>
+
{this.props.engine && (
<Tooltip
overlay={translateWithParameters('issue.from_external_rule_engine', this.props.engine)}>
diff --git a/server/sonar-web/src/main/js/components/issue/components/__tests__/__snapshots__/IssueMessage-test.tsx.snap b/server/sonar-web/src/main/js/components/issue/components/__tests__/__snapshots__/IssueMessage-test.tsx.snap
index 74d242cefac..38370231ce0 100644
--- a/server/sonar-web/src/main/js/components/issue/components/__tests__/__snapshots__/IssueMessage-test.tsx.snap
+++ b/server/sonar-web/src/main/js/components/issue/components/__tests__/__snapshots__/IssueMessage-test.tsx.snap
@@ -5,13 +5,13 @@ exports[`should render with the message and a link to open the rule 1`] = `
className="issue-message"
>
<span
- className="little-spacer-right"
+ className="spacer-right"
>
Reduce the number of conditional operators (4) used in the expression
</span>
<Button
aria-label="issue.rule_details"
- className="button button-grey button-tiny spacer-right text-top"
+ className="button button-link issue-see-rule spacer-right text-top"
onClick={[Function]}
>
issue.see_rule