aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSébastien Lesaint <sebastien.lesaint@sonarsource.com>2015-10-19 17:11:21 +0200
committerSébastien Lesaint <sebastien.lesaint@sonarsource.com>2015-10-20 10:36:17 +0200
commit7b7e95604f458f7a0d5ef5d4d3753f8e694253cd (patch)
tree20924a9efbae80a2634c9d26864398e2aea97659
parentf5d5b1625934b89c3524f52b4ee3b1dfe8f299a5 (diff)
downloadsonarqube-7b7e95604f458f7a0d5ef5d4d3753f8e694253cd.tar.gz
sonarqube-7b7e95604f458f7a0d5ef5d4d3753f8e694253cd.zip
SONAR-6680 add RuleDao.selectAll to be used by CE's RuleRepository
-rw-r--r--sonar-db/src/main/java/org/sonar/db/rule/RuleDao.java4
-rw-r--r--sonar-db/src/main/java/org/sonar/db/rule/RuleMapper.java2
-rw-r--r--sonar-db/src/test/java/org/sonar/db/rule/RuleDaoTest.java9
3 files changed, 15 insertions, 0 deletions
diff --git a/sonar-db/src/main/java/org/sonar/db/rule/RuleDao.java b/sonar-db/src/main/java/org/sonar/db/rule/RuleDao.java
index cf4be7e8278..1a7026281f0 100644
--- a/sonar-db/src/main/java/org/sonar/db/rule/RuleDao.java
+++ b/sonar-db/src/main/java/org/sonar/db/rule/RuleDao.java
@@ -70,6 +70,10 @@ public class RuleDao implements Dao {
mapper(session).selectEnabledAndNonManual(resultHandler);
}
+ public List<RuleDto> selectAll(DbSession session) {
+ return mapper(session).selectAll();
+ }
+
public void insert(DbSession session, RuleDto dto) {
mapper(session).insert(dto);
}
diff --git a/sonar-db/src/main/java/org/sonar/db/rule/RuleMapper.java b/sonar-db/src/main/java/org/sonar/db/rule/RuleMapper.java
index 833fdedf37c..e3af090fae3 100644
--- a/sonar-db/src/main/java/org/sonar/db/rule/RuleMapper.java
+++ b/sonar-db/src/main/java/org/sonar/db/rule/RuleMapper.java
@@ -30,6 +30,8 @@ public interface RuleMapper {
List<RuleDto> selectAll();
+ List<RuleDto> selectAll(ResultHandler resultHandler);
+
List<RuleDto> selectEnabledAndNonManual();
void selectEnabledAndNonManual(ResultHandler resultHandler);
diff --git a/sonar-db/src/test/java/org/sonar/db/rule/RuleDaoTest.java b/sonar-db/src/test/java/org/sonar/db/rule/RuleDaoTest.java
index 8bd207050be..b452784bddc 100644
--- a/sonar-db/src/test/java/org/sonar/db/rule/RuleDaoTest.java
+++ b/sonar-db/src/test/java/org/sonar/db/rule/RuleDaoTest.java
@@ -129,6 +129,15 @@ public class RuleDaoTest {
}
@Test
+ public void selectAll() {
+ dbTester.prepareDbUnit(getClass(), "shared.xml");
+
+ List<RuleDto> ruleDtos = underTest.selectAll(dbTester.getSession());
+
+ assertThat(ruleDtos).extracting("id").containsOnly(1, 2);
+ }
+
+ @Test
public void insert() throws Exception {
dbTester.getDbClient().ruleDao().insert(dbTester.getSession(), RuleTesting.newDto(RuleKey.of("java", "S001")).setConfigKey(null));
dbTester.getDbClient().ruleDao().insert(dbTester.getSession(), RuleTesting.newDto(RuleKey.of("java", "S002")).setConfigKey("I002"));