diff options
| author | David Cho-Lerat <117642976+david-cho-lerat-sonarsource@users.noreply.github.com> | 2022-12-12 11:24:24 +0100 |
|---|---|---|
| committer | sonartech <sonartech@sonarsource.com> | 2022-12-12 20:04:02 +0000 |
| commit | e051863b7be7bdfe2f5c59ce921788b3d7ca0c15 (patch) | |
| tree | 0419047acac12d06b9836f362415f9f4472ab5f7 | |
| parent | 53cacbcdf5d599c2970700152ec4fb947b084bde (diff) | |
| download | sonarqube-e051863b7be7bdfe2f5c59ce921788b3d7ca0c15.tar.gz sonarqube-e051863b7be7bdfe2f5c59ce921788b3d7ca0c15.zip | |
SONAR-17724 Using incorrect ARIA role "tab" for Rules navigation (#7206)
| -rw-r--r-- | server/sonar-web/src/main/js/apps/coding-rules/components/App.tsx | 4 | ||||
| -rw-r--r-- | server/sonar-web/src/main/js/apps/coding-rules/components/__tests__/__snapshots__/App-test.tsx.snap | 10 |
2 files changed, 5 insertions, 9 deletions
diff --git a/server/sonar-web/src/main/js/apps/coding-rules/components/App.tsx b/server/sonar-web/src/main/js/apps/coding-rules/components/App.tsx index e14c9daa657..a766fad57b2 100644 --- a/server/sonar-web/src/main/js/apps/coding-rules/components/App.tsx +++ b/server/sonar-web/src/main/js/apps/coding-rules/components/App.tsx @@ -647,7 +647,7 @@ export class App extends React.PureComponent<Props, State> { /> ) : ( <> - <div role="tab"> + <section> {rules.map((rule) => ( <RuleListItem activation={this.getRuleActivation(rule.key)} @@ -662,7 +662,7 @@ export class App extends React.PureComponent<Props, State> { selectedProfile={this.getSelectedProfile()} /> ))} - </div> + </section> {paging !== undefined && ( <ListFooter count={rules.length} diff --git a/server/sonar-web/src/main/js/apps/coding-rules/components/__tests__/__snapshots__/App-test.tsx.snap b/server/sonar-web/src/main/js/apps/coding-rules/components/__tests__/__snapshots__/App-test.tsx.snap index f90b687a909..c21831ed804 100644 --- a/server/sonar-web/src/main/js/apps/coding-rules/components/__tests__/__snapshots__/App-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/coding-rules/components/__tests__/__snapshots__/App-test.tsx.snap @@ -267,9 +267,7 @@ exports[`should render correctly: loaded 1`] = ` <div className="layout-page-main-inner" > - <div - role="tab" - > + <section> <RuleListItem isLoggedIn={true} key="javascript:S1067" @@ -324,7 +322,7 @@ exports[`should render correctly: loaded 1`] = ` } selected={false} /> - </div> + </section> <ListFooter count={2} loadMore={[Function]} @@ -389,9 +387,7 @@ exports[`should render correctly: loading 1`] = ` <div className="layout-page-main-inner" > - <div - role="tab" - /> + <section /> </div> </div> </div> |