aboutsummaryrefslogtreecommitdiffstats
path: root/it
diff options
context:
space:
mode:
authorJulien Lancelot <julien.lancelot@sonarsource.com>2017-01-31 17:39:29 +0100
committerJulien Lancelot <julien.lancelot@sonarsource.com>2017-02-02 17:05:25 +0100
commit772fe2510ab174fa0f12ee93087d8cbe6a594f61 (patch)
tree09ddb1b189aeee3c0b0d40cc5bf87e58b6df6b05 /it
parent6358f483146da56ef2893d109d347be10f5b342a (diff)
downloadsonarqube-772fe2510ab174fa0f12ee93087d8cbe6a594f61.tar.gz
sonarqube-772fe2510ab174fa0f12ee93087d8cbe6a594f61.zip
SONAR-8610 Remove setting sonar.technicalDebt.hoursInDay
Diffstat (limited to 'it')
-rw-r--r--it/it-tests/src/test/java/it/qualityModel/DebtConfigurationRule.java12
-rw-r--r--it/it-tests/src/test/java/it/qualityModel/TechnicalDebtInIssueChangelogTest.java3
-rw-r--r--it/it-tests/src/test/java/it/qualityModel/TechnicalDebtTest.java44
3 files changed, 0 insertions, 59 deletions
diff --git a/it/it-tests/src/test/java/it/qualityModel/DebtConfigurationRule.java b/it/it-tests/src/test/java/it/qualityModel/DebtConfigurationRule.java
index 57c6e844ac6..11ca09aa744 100644
--- a/it/it-tests/src/test/java/it/qualityModel/DebtConfigurationRule.java
+++ b/it/it-tests/src/test/java/it/qualityModel/DebtConfigurationRule.java
@@ -33,7 +33,6 @@ import static util.ItUtils.setServerProperty;
*/
public class DebtConfigurationRule extends ExternalResource {
- private static final String HOURS_IN_DAY_PROPERTY = "sonar.technicalDebt.hoursInDay";
private static final String DEV_COST_PROPERTY = "sonar.technicalDebt.developmentCost";
private static final String RATING_GRID_PROPERTY = "sonar.technicalDebt.ratingGrid";
@@ -71,21 +70,10 @@ public class DebtConfigurationRule extends ExternalResource {
}
public void reset() {
- resetHoursInDay();
resetDevelopmentCost();
resetRatingGrid();
}
- public DebtConfigurationRule updateHoursInDay(int hoursInDay) {
- setProperty(HOURS_IN_DAY_PROPERTY, Integer.toString(hoursInDay));
- return this;
- }
-
- public DebtConfigurationRule resetHoursInDay() {
- resetProperty(HOURS_IN_DAY_PROPERTY);
- return this;
- }
-
public DebtConfigurationRule updateDevelopmentCost(int developmentCost) {
setProperty(DEV_COST_PROPERTY, Integer.toString(developmentCost));
return this;
diff --git a/it/it-tests/src/test/java/it/qualityModel/TechnicalDebtInIssueChangelogTest.java b/it/it-tests/src/test/java/it/qualityModel/TechnicalDebtInIssueChangelogTest.java
index ab44372993f..89bc42c742b 100644
--- a/it/it-tests/src/test/java/it/qualityModel/TechnicalDebtInIssueChangelogTest.java
+++ b/it/it-tests/src/test/java/it/qualityModel/TechnicalDebtInIssueChangelogTest.java
@@ -52,9 +52,6 @@ public class TechnicalDebtInIssueChangelogTest {
@Before
public void deleteAnalysisData() {
orchestrator.resetData();
-
- // Set hours in day property to 8
- debtConfiguration.updateHoursInDay(8);
}
@Test
diff --git a/it/it-tests/src/test/java/it/qualityModel/TechnicalDebtTest.java b/it/it-tests/src/test/java/it/qualityModel/TechnicalDebtTest.java
index f4ba792a436..32d4b4c6bfd 100644
--- a/it/it-tests/src/test/java/it/qualityModel/TechnicalDebtTest.java
+++ b/it/it-tests/src/test/java/it/qualityModel/TechnicalDebtTest.java
@@ -29,7 +29,6 @@ import org.junit.ClassRule;
import org.junit.Rule;
import org.junit.Test;
import org.sonar.wsclient.issue.Issue;
-import org.sonar.wsclient.issue.IssueClient;
import org.sonar.wsclient.issue.IssueQuery;
import static org.assertj.core.api.Assertions.assertThat;
@@ -46,9 +45,6 @@ public class TechnicalDebtTest {
@Before
public void deleteAnalysisData() {
orchestrator.resetData();
-
- // Set hours in day property to 8
- debtConfiguration.updateHoursInDay(8);
}
/**
@@ -71,44 +67,4 @@ public class TechnicalDebtTest {
}
}
- @Test
- public void use_hours_in_day_property_to_display_debt() throws Exception {
- orchestrator.getServer().restoreProfile(FileLocation.ofClasspath("/qualityModel/one-issue-per-file.xml"));
- orchestrator.getServer().provisionProject("sample", "sample");
- orchestrator.getServer().associateProjectToQualityProfile("sample", "xoo", "one-issue-per-file");
-
- // One day -> 10 hours
- debtConfiguration.updateHoursInDay(10);
-
- orchestrator.executeBuild(SonarScanner.create(projectDir("shared/xoo-sample"))
- // As OneIssuePerFile has a debt of 10 minutes, we multiply it by 72 to have 1 day and 2 hours of technical debt
- .setProperties("sonar.oneIssuePerFile.effortToFix", "72")
- );
-
- IssueClient issueClient = orchestrator.getServer().wsClient().issueClient();
- Issue issue = issueClient.find(IssueQuery.create()).list().get(0);
-
- assertThat(issue.debt()).isEqualTo("1d2h");
- }
-
- @Test
- public void use_hours_in_day_property_during_analysis_to_convert_debt() throws Exception {
- orchestrator.getServer().restoreProfile(FileLocation.ofClasspath("/qualityModel/one-day-debt-per-file.xml"));
- orchestrator.getServer().provisionProject("sample", "sample");
- orchestrator.getServer().associateProjectToQualityProfile("sample", "xoo", "one-day-debt-per-file");
-
- // One day -> 10 hours : debt will be stored as 360.000 seconds (1 day * 10 hours per day * 60 * 60)
- debtConfiguration.updateHoursInDay(10);
-
- orchestrator.executeBuild(SonarScanner.create(projectDir("shared/xoo-sample")));
-
- // Issue debt was 1 day during analysis but will be displayed as 1 day and 2 hours (hours in day property was set
- // to 10 during analysis but is now 8)
- debtConfiguration.updateHoursInDay(8);
-
- IssueClient issueClient = orchestrator.getServer().wsClient().issueClient();
- Issue issue = issueClient.find(IssueQuery.create()).list().get(0);
- assertThat(issue.debt()).isEqualTo("1d2h");
- }
-
}