diff options
| author | Simon Brandhof <simon.brandhof@sonarsource.com> | 2016-02-26 16:47:54 +0100 |
|---|---|---|
| committer | Simon Brandhof <simon.brandhof@sonarsource.com> | 2016-02-29 12:12:16 +0100 |
| commit | cbf142857bfce52b0131ade69ce34880f813f2e7 (patch) | |
| tree | 2294fe7aa748c156662b12a3e3ce13ee35fd76dc /it | |
| parent | afe276c062e03d7c0ed7bab97b0ee8cf0511423e (diff) | |
| download | sonarqube-cbf142857bfce52b0131ade69ce34880f813f2e7.tar.gz sonarqube-cbf142857bfce52b0131ade69ce34880f813f2e7.zip | |
Replace SQL "count(*)" by "count(1)"
It can have slight performance improvements on some databases.
Diffstat (limited to 'it')
3 files changed, 5 insertions, 5 deletions
diff --git a/it/it-tests/src/test/java/it/dbCleaner/PurgeTest.java b/it/it-tests/src/test/java/it/dbCleaner/PurgeTest.java index 430a2834d9f..936d17517cf 100644 --- a/it/it-tests/src/test/java/it/dbCleaner/PurgeTest.java +++ b/it/it-tests/src/test/java/it/dbCleaner/PurgeTest.java @@ -263,7 +263,7 @@ public class PurgeTest { } private int count(String condition) { - return orchestrator.getDatabase().countSql("select count(*) from " + condition); + return orchestrator.getDatabase().countSql("select count(1) from " + condition); } private void assertMeasuresCountForQualifier(String qualifier, int count) { @@ -275,7 +275,7 @@ public class PurgeTest { } private int countMeasures(String qualifier) { - String sql = "SELECT count(pm.id) FROM project_measures pm, snapshots s, metrics m where pm.snapshot_id=s.id and pm.metric_id=m.id and s.qualifier='" + qualifier + "'"; + String sql = "SELECT count(1) FROM project_measures pm, snapshots s, metrics m where pm.snapshot_id=s.id and pm.metric_id=m.id and s.qualifier='" + qualifier + "'"; return orchestrator.getDatabase().countSql(sql); } diff --git a/it/it-tests/src/test/java/it/debt/TechnicalDebtPurgeTest.java b/it/it-tests/src/test/java/it/debt/TechnicalDebtPurgeTest.java index c329e732b97..9ee0febd76e 100644 --- a/it/it-tests/src/test/java/it/debt/TechnicalDebtPurgeTest.java +++ b/it/it-tests/src/test/java/it/debt/TechnicalDebtPurgeTest.java @@ -33,8 +33,8 @@ import static util.ItUtils.projectDir; public class TechnicalDebtPurgeTest { - private static final String SQL_COUNT_MEASURES_ON_CHARACTERISTICS = "select count(*) from project_measures where characteristic_id is not null"; - private static final String SQL_COUNT_MEASURES_ON_DEBT_MEASURES_WITH_RULES = "select count(*) from project_measures where rule_id is not null and metric_id in (select id from metrics where name='sqale_index')"; + private static final String SQL_COUNT_MEASURES_ON_CHARACTERISTICS = "select count(1) from project_measures where characteristic_id is not null"; + private static final String SQL_COUNT_MEASURES_ON_DEBT_MEASURES_WITH_RULES = "select count(1) from project_measures where rule_id is not null and metric_id in (select id from metrics where name='sqale_index')"; @ClassRule public static Orchestrator orchestrator = Category2Suite.ORCHESTRATOR; diff --git a/it/it-tests/src/test/java/it/projectAdministration/ProjectAdministrationTest.java b/it/it-tests/src/test/java/it/projectAdministration/ProjectAdministrationTest.java index c9ebffb8ac9..885dbd7b5b1 100644 --- a/it/it-tests/src/test/java/it/projectAdministration/ProjectAdministrationTest.java +++ b/it/it-tests/src/test/java/it/projectAdministration/ProjectAdministrationTest.java @@ -247,7 +247,7 @@ public class ProjectAdministrationTest { } private int count(String condition) { - return orchestrator.getDatabase().countSql("select count(*) from " + condition); + return orchestrator.getDatabase().countSql("select count(1) from " + condition); } } |