diff options
| author | Evgeny Mandrikov <mandrikov@gmail.com> | 2011-06-17 14:55:40 +0400 |
|---|---|---|
| committer | Evgeny Mandrikov <mandrikov@gmail.com> | 2011-06-17 17:18:45 +0400 |
| commit | c973498cfec4ff8e59ac33e9c9fb150a71ef828a (patch) | |
| tree | 276e8ac2d6ba96b6edeb4622c6702ae19f988251 /plugins/sonar-core-plugin | |
| parent | 58c0a485ceade20933b5bc52b914ef2b34cadbd5 (diff) | |
| download | sonarqube-c973498cfec4ff8e59ac33e9c9fb150a71ef828a.tar.gz sonarqube-c973498cfec4ff8e59ac33e9c9fb150a71ef828a.zip | |
SONAR-2428 Detection new violations, when new module added to project
Diffstat (limited to 'plugins/sonar-core-plugin')
2 files changed, 6 insertions, 6 deletions
diff --git a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/NewCoverageFileAnalyzer.java b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/NewCoverageFileAnalyzer.java index 5686c6d4ecc..d44ffd056e1 100644 --- a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/NewCoverageFileAnalyzer.java +++ b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/NewCoverageFileAnalyzer.java @@ -60,7 +60,6 @@ public final class NewCoverageFileAnalyzer implements Decorator { this.structs = structs; } - public boolean shouldExecuteOnProject(Project project) { return project.isLatestAnalysis() && !structs.isEmpty(); } @@ -146,7 +145,6 @@ public final class NewCoverageFileAnalyzer implements Decorator { context.saveMeasure(newUncoveredConditions); } - private Map<Integer, Integer> parseCountByLine(Measure measure) { if (measure != null && measure.hasData()) { return KeyValueFormat.parseIntInt(measure.getData()); @@ -154,7 +152,6 @@ public final class NewCoverageFileAnalyzer implements Decorator { return Maps.newHashMap(); } - public static final class PeriodStruct { int index; Date date; @@ -179,9 +176,9 @@ public final class NewCoverageFileAnalyzer implements Decorator { void analyze(Date lineDate, int hits, int conditions, int coveredConditions) { if (lineDate == null) { - //TODO warning + // TODO warning - } else if (lineDate.after(date)) { + } else if (date == null || lineDate.after(date)) { // TODO test if string comparison is faster or not addLine(hits > 0); addConditions(conditions, coveredConditions); diff --git a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/NewViolationsDecorator.java b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/NewViolationsDecorator.java index 358c3394edc..86a150e28cd 100644 --- a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/NewViolationsDecorator.java +++ b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/NewViolationsDecorator.java @@ -173,7 +173,10 @@ public class NewViolationsDecorator implements Decorator { } private boolean isAfter(Violation violation, Date date) { - return violation.getCreatedAt()!= null && violation.getCreatedAt().after(date); + if (date == null) { + return true; + } + return violation.getCreatedAt() != null && violation.getCreatedAt().after(date); } private Metric getMetricForSeverity(RulePriority severity) { |