diff options
author | Simon Brandhof <simon.brandhof@gmail.com> | 2011-12-12 11:51:24 +0100 |
---|---|---|
committer | Simon Brandhof <simon.brandhof@gmail.com> | 2011-12-12 11:51:24 +0100 |
commit | dceec13d5c22aaa67f9f19d6196b3ae4330b23ff (patch) | |
tree | 6acec7e8f0d4013c1e7afb1455617f901a56bf82 /plugins/sonar-design-plugin | |
parent | 5c1cabf8355199f03924bbabf34f98b315a01f51 (diff) | |
download | sonarqube-dceec13d5c22aaa67f9f19d6196b3ae4330b23ff.tar.gz sonarqube-dceec13d5c22aaa67f9f19d6196b3ae4330b23ff.zip |
Fix some violations
Diffstat (limited to 'plugins/sonar-design-plugin')
3 files changed, 11 insertions, 6 deletions
diff --git a/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/batch/MavenDependenciesSensor.java b/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/batch/MavenDependenciesSensor.java index 198340252c4..be23b8433f9 100644 --- a/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/batch/MavenDependenciesSensor.java +++ b/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/batch/MavenDependenciesSensor.java @@ -54,7 +54,8 @@ public class MavenDependenciesSensor implements Sensor { private DependencyTreeBuilder treeBuilder; private SonarIndex index; - public MavenDependenciesSensor(ArtifactRepository localRepository, ArtifactFactory artifactFactory, ArtifactMetadataSource artifactMetadataSource, ArtifactCollector artifactCollector, DependencyTreeBuilder treeBuilder, SonarIndex index) { + public MavenDependenciesSensor(ArtifactRepository localRepository, ArtifactFactory artifactFactory, ArtifactMetadataSource artifactMetadataSource, + ArtifactCollector artifactCollector, DependencyTreeBuilder treeBuilder, SonarIndex index) { this.localRepository = localRepository; this.artifactFactory = artifactFactory; this.artifactMetadataSource = artifactMetadataSource; diff --git a/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/ui/page/GwtDesignPage.java b/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/ui/page/GwtDesignPage.java index 22dd200c31a..360fb5174f8 100644 --- a/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/ui/page/GwtDesignPage.java +++ b/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/ui/page/GwtDesignPage.java @@ -21,13 +21,16 @@ package org.sonar.plugins.design.ui.page; import org.sonar.api.measures.CoreMetrics; import org.sonar.api.resources.Java; -import org.sonar.api.resources.Resource; +import org.sonar.api.resources.Qualifiers; import org.sonar.api.web.*; import org.sonar.plugins.design.ui.page.client.DesignPage; @ResourceLanguage(Java.KEY) -@ResourceQualifier({Resource.QUALIFIER_PROJECT, Resource.QUALIFIER_MODULE, Resource.QUALIFIER_PACKAGE, Resource.QUALIFIER_DIRECTORY}) -@DefaultTab(metrics={CoreMetrics.DEPENDENCY_MATRIX_KEY, CoreMetrics.PACKAGE_FEEDBACK_EDGES_KEY, CoreMetrics.PACKAGE_CYCLES_KEY, CoreMetrics.PACKAGE_TANGLE_INDEX_KEY, CoreMetrics.PACKAGE_TANGLES_KEY, CoreMetrics.FILE_CYCLES_KEY, CoreMetrics.FILE_TANGLE_INDEX_KEY, CoreMetrics.FILE_TANGLES_KEY, CoreMetrics.FILE_FEEDBACK_EDGES_KEY}) +@ResourceQualifier({Qualifiers.PROJECT, Qualifiers.MODULE, Qualifiers.PACKAGE, Qualifiers.DIRECTORY}) +@DefaultTab(metrics = { + CoreMetrics.DEPENDENCY_MATRIX_KEY, CoreMetrics.PACKAGE_FEEDBACK_EDGES_KEY, CoreMetrics.PACKAGE_CYCLES_KEY, CoreMetrics.PACKAGE_TANGLE_INDEX_KEY, + CoreMetrics.PACKAGE_TANGLES_KEY, CoreMetrics.FILE_CYCLES_KEY, CoreMetrics.FILE_TANGLE_INDEX_KEY, CoreMetrics.FILE_TANGLES_KEY, + CoreMetrics.FILE_FEEDBACK_EDGES_KEY}) @NavigationSection({NavigationSection.RESOURCE, NavigationSection.RESOURCE_TAB}) @UserRole(UserRole.USER) public class GwtDesignPage extends GwtPage { diff --git a/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/ui/page/client/DependencyInfo.java b/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/ui/page/client/DependencyInfo.java index 412322fb779..6b68914f04e 100644 --- a/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/ui/page/client/DependencyInfo.java +++ b/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/ui/page/client/DependencyInfo.java @@ -58,7 +58,8 @@ public final class DependencyInfo extends Composite { public void showOrPopup(String dependencyId) { if (popupMode) { - Window.open(Links.urlForResourcePage(Configuration.getResourceId(), DesignPage.GWT_ID, "layout=false&depId=" + dependencyId), "dependency", Links.DEFAULT_POPUP_HTML_FEATURES); + Window.open(Links.urlForResourcePage(Configuration.getResourceId(), DesignPage.GWT_ID, "layout=false&depId=" + dependencyId), + "dependency", Links.DEFAULT_POPUP_HTML_FEATURES); } else { INSTANCE.show(dependencyId); @@ -68,7 +69,7 @@ public final class DependencyInfo extends Composite { public void show(String dependencyId) { panel.clear(); currentDependencyId = dependencyId; - if (dependencyId !=null) { + if (dependencyId != null) { panel.add(loading); loadDependency(dependencyId); } |