SONAR-2231 Don't use module sonar-deprecated in core plugins

* Create new implementation of PmdViolationsXmlParser for sonar-pmd-plugin

* Remove unused method in sonar-findbugs-plugin and remove dependency

* Just remove dependency in sonar-squid-java-plugin

2 files changed, 0 insertions, 29 deletions

diff --git a/plugins/sonar-findbugs-plugin/pom.xml b/plugins/sonar-findbugs-plugin/pom.xml
index f5c63f130d6..2cceb3c3dc4 100644
--- a/plugins/sonar-findbugs-plugin/pom.xml
+++ b/plugins/sonar-findbugs-plugin/pom.xml
@@ -69,12 +69,6 @@
         </exclusion>
       </exclusions>
     </dependency>
-    <dependency>
-      <groupId>org.codehaus.sonar</groupId>
-      <artifactId>sonar-deprecated</artifactId>
-      <version>${project.version}</version>
-      <scope>provided</scope>
-    </dependency>
 
     <!-- unit tests -->
     <dependency>
diff --git a/plugins/sonar-findbugs-plugin/src/test/java/org/sonar/plugins/findbugs/FindbugsTests.java b/plugins/sonar-findbugs-plugin/src/test/java/org/sonar/plugins/findbugs/FindbugsTests.java
index 900032273b2..55a63bd3bd3 100644
--- a/plugins/sonar-findbugs-plugin/src/test/java/org/sonar/plugins/findbugs/FindbugsTests.java
+++ b/plugins/sonar-findbugs-plugin/src/test/java/org/sonar/plugins/findbugs/FindbugsTests.java
@@ -19,25 +19,18 @@
  */
 package org.sonar.plugins.findbugs;
 
-import static org.mockito.Matchers.anyString;
-import static org.mockito.Matchers.eq;
 import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
 
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
 
-import org.mockito.invocation.InvocationOnMock;
-import org.mockito.stubbing.Answer;
-import org.sonar.api.CoreProperties;
 import org.sonar.api.platform.ServerFileSystem;
 import org.sonar.api.profiles.RulesProfile;
 import org.sonar.api.resources.Java;
 import org.sonar.api.rules.ActiveRule;
 import org.sonar.api.rules.Rule;
 import org.sonar.api.rules.RulePriority;
-import org.sonar.api.rules.RulesManager;
 import org.sonar.api.rules.XMLRuleParser;
 import org.sonar.test.TestUtils;
 import org.xml.sax.SAXException;
@@ -70,22 +63,6 @@ public abstract class FindbugsTests {
     return activeRules;
   }
 
-  protected RulesManager createRulesManager() {
-    RulesManager rulesManager = mock(RulesManager.class);
-
-    when(rulesManager.getPluginRule(eq(CoreProperties.FINDBUGS_PLUGIN), anyString())).thenAnswer(new Answer<Rule>() {
-
-      public Rule answer(InvocationOnMock invocationOnMock) throws Throwable {
-        Object[] args = invocationOnMock.getArguments();
-        Rule rule = Rule.create();
-        rule.setPluginName((String) args[0]);
-        rule.setKey((String) args[1]);
-        return rule;
-      }
-    });
-    return rulesManager;
-  }
-
   protected RulesProfile createRulesProfileWithActiveRules() {
     RulesProfile profile = RulesProfile.create();
     profile.setName(RulesProfile.SONAR_WAY_FINDBUGS_NAME);