SONAR-2724 SONAR-2723 Improved getter and setter detection algorithm

4 files changed, 36 insertions, 0 deletions

diff --git a/plugins/sonar-squid-java-plugin/test-resources/bytecode/bin/properties/JavaBean.class b/plugins/sonar-squid-java-plugin/test-resources/bytecode/bin/properties/JavaBean.class
index 96067d246b9..5fbd5f8656f 100644
--- a/plugins/sonar-squid-java-plugin/test-resources/bytecode/bin/properties/JavaBean.class
+++ b/plugins/sonar-squid-java-plugin/test-resources/bytecode/bin/properties/JavaBean.class
diff --git a/plugins/sonar-squid-java-plugin/test-resources/bytecode/bin/tags/impl/FixMe$1.class b/plugins/sonar-squid-java-plugin/test-resources/bytecode/bin/tags/impl/FixMe$1.class
index 95daff2fdbd..7581dc25b8a 100644
--- a/plugins/sonar-squid-java-plugin/test-resources/bytecode/bin/tags/impl/FixMe$1.class
+++ b/plugins/sonar-squid-java-plugin/test-resources/bytecode/bin/tags/impl/FixMe$1.class
diff --git a/plugins/sonar-squid-java-plugin/test-resources/bytecode/bin/tags/impl/Todo.class b/plugins/sonar-squid-java-plugin/test-resources/bytecode/bin/tags/impl/Todo.class
index 1f443ef6018..ca3774bfbea 100644
--- a/plugins/sonar-squid-java-plugin/test-resources/bytecode/bin/tags/impl/Todo.class
+++ b/plugins/sonar-squid-java-plugin/test-resources/bytecode/bin/tags/impl/Todo.class
diff --git a/plugins/sonar-squid-java-plugin/test-resources/bytecode/src/properties/JavaBean.java b/plugins/sonar-squid-java-plugin/test-resources/bytecode/src/properties/JavaBean.java
index be09a2b5b99..6e858627c24 100644
--- a/plugins/sonar-squid-java-plugin/test-resources/bytecode/src/properties/JavaBean.java
+++ b/plugins/sonar-squid-java-plugin/test-resources/bytecode/src/properties/JavaBean.java
@@ -1,9 +1,14 @@
 package properties;
 
+import java.util.ArrayList;
+
 public class JavaBean {
   
   private String name;
   private boolean french;
+  ArrayList<String> firstNames = new ArrayList<String>();
+  private static String staticMember;
+  private String FirstName;
   
   public String getName(){
     return name;
@@ -24,4 +29,35 @@ public class JavaBean {
   public void anotherMethod(){
     
   }
+  
+  public void addFirstName(String firstName) {
+    firstNames.add(firstName);
+  }
+  
+  public String getNameOrDefault() {
+    return (name == null) ? "Freddy" : name;
+  }
+  
+  public static void uselessStaticMethod() {
+    
+  }
+  
+  public void accessorWithABunchOfCalls() {
+    uselessStaticMethod();
+    ArrayList<String> myList = new ArrayList<String>();
+    myList.add("Banana");
+    myList.add("Peach");
+    myList.add("Strawberry");
+    
+    firstNames.addAll(myList);
+  }
+  
+  public void iShouldBeAStaticSetter() {
+    staticMember = "Hello!";
+  }
+  
+  public String getFirstName() {
+    return FirstName;
+  }
+  
 }