aboutsummaryrefslogtreecommitdiffstats
path: root/plugins/sonar-squid-java-plugin
diff options
context:
space:
mode:
authorEvgeny Mandrikov <mandrikov@gmail.com>2012-02-17 12:48:07 +0400
committerEvgeny Mandrikov <mandrikov@gmail.com>2012-02-17 13:46:50 +0400
commit0aa289a5926819abf28961be3d2f1e772648e9fb (patch)
tree2b4e7df2d9c0c383ca532b57f59db3be5a991740 /plugins/sonar-squid-java-plugin
parentaa342c58f14c8bc402f69143e9451aaad878e6c3 (diff)
downloadsonarqube-0aa289a5926819abf28961be3d2f1e772648e9fb.tar.gz
sonarqube-0aa289a5926819abf28961be3d2f1e772648e9fb.zip
Fix some quality flaws
Diffstat (limited to 'plugins/sonar-squid-java-plugin')
-rw-r--r--plugins/sonar-squid-java-plugin/src/main/java/org/sonar/java/ast/visitor/PublicApiVisitor.java13
-rw-r--r--plugins/sonar-squid-java-plugin/src/main/java/org/sonar/java/ast/visitor/SuppressWarningsAnnotationUtils.java6
2 files changed, 7 insertions, 12 deletions
diff --git a/plugins/sonar-squid-java-plugin/src/main/java/org/sonar/java/ast/visitor/PublicApiVisitor.java b/plugins/sonar-squid-java-plugin/src/main/java/org/sonar/java/ast/visitor/PublicApiVisitor.java
index 94d96dd4c10..bf2a3c5bed0 100644
--- a/plugins/sonar-squid-java-plugin/src/main/java/org/sonar/java/ast/visitor/PublicApiVisitor.java
+++ b/plugins/sonar-squid-java-plugin/src/main/java/org/sonar/java/ast/visitor/PublicApiVisitor.java
@@ -19,21 +19,16 @@
*/
package org.sonar.java.ast.visitor;
-import java.util.Arrays;
-import java.util.List;
-
+import com.puppycrawl.tools.checkstyle.api.*;
import org.sonar.squid.api.SourceCode;
import org.sonar.squid.measures.Metric;
-import com.puppycrawl.tools.checkstyle.api.AnnotationUtility;
-import com.puppycrawl.tools.checkstyle.api.DetailAST;
-import com.puppycrawl.tools.checkstyle.api.FileContents;
-import com.puppycrawl.tools.checkstyle.api.Scope;
-import com.puppycrawl.tools.checkstyle.api.TokenTypes;
+import java.util.Arrays;
+import java.util.List;
public class PublicApiVisitor extends JavaAstVisitor {
- final static String OVERRIDE_ANNOTATION_KEYWORD = "Override";
+ static final String OVERRIDE_ANNOTATION_KEYWORD = "Override";
public static final List<Integer> TOKENS = Arrays.asList(TokenTypes.CLASS_DEF, TokenTypes.INTERFACE_DEF, TokenTypes.METHOD_DEF,
TokenTypes.CTOR_DEF, TokenTypes.ANNOTATION_DEF, TokenTypes.ANNOTATION_FIELD_DEF, TokenTypes.VARIABLE_DEF);
diff --git a/plugins/sonar-squid-java-plugin/src/main/java/org/sonar/java/ast/visitor/SuppressWarningsAnnotationUtils.java b/plugins/sonar-squid-java-plugin/src/main/java/org/sonar/java/ast/visitor/SuppressWarningsAnnotationUtils.java
index c0413ddf322..fb2c20174de 100644
--- a/plugins/sonar-squid-java-plugin/src/main/java/org/sonar/java/ast/visitor/SuppressWarningsAnnotationUtils.java
+++ b/plugins/sonar-squid-java-plugin/src/main/java/org/sonar/java/ast/visitor/SuppressWarningsAnnotationUtils.java
@@ -29,9 +29,9 @@ import com.puppycrawl.tools.checkstyle.api.TokenTypes;
*/
public final class SuppressWarningsAnnotationUtils {
- private final static String SUPPRESS_WARNINGS_ANNOTATION_NAME = "SuppressWarnings";
- private final static String SUPPRESS_WARNINGS_ANNOTATION_FQ_NAME = "java.lang." + SUPPRESS_WARNINGS_ANNOTATION_NAME;
- private final static String VALUE = "\"all\"";
+ private static final String SUPPRESS_WARNINGS_ANNOTATION_NAME = "SuppressWarnings";
+ private static final String SUPPRESS_WARNINGS_ANNOTATION_FQ_NAME = "java.lang." + SUPPRESS_WARNINGS_ANNOTATION_NAME;
+ private static final String VALUE = "\"all\"";
public static boolean isSuppressAllWarnings(DetailAST ast) {
DetailAST suppressWarningsAnnotation = getSuppressWarningsAnnotation(ast);