summaryrefslogtreecommitdiffstats
path: root/plugins
diff options
context:
space:
mode:
authorJulien Lancelot <julien.lancelot@gmail.com>2013-08-20 12:26:24 +0200
committerJulien Lancelot <julien.lancelot@gmail.com>2013-08-20 12:26:24 +0200
commitcfd9912407a505d6005d70f89ffc01c2d19b7ab4 (patch)
treebcb920437ce0055791f01d994dc3560d99e63e58 /plugins
parentab09254608fa6dcf5595891d9070e4d9faf21276 (diff)
downloadsonarqube-cfd9912407a505d6005d70f89ffc01c2d19b7ab4.tar.gz
sonarqube-cfd9912407a505d6005d70f89ffc01c2d19b7ab4.zip
Fix quality flaws
Diffstat (limited to 'plugins')
-rw-r--r--plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/GenerateAlertEvents.java9
-rw-r--r--plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/TendencyAnalyser.java6
-rw-r--r--plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/ui/libraries/client/ProjectPanel.java2
3 files changed, 6 insertions, 11 deletions
diff --git a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/GenerateAlertEvents.java b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/GenerateAlertEvents.java
index 4bdc0c13a06..3e048566bf6 100644
--- a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/GenerateAlertEvents.java
+++ b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/GenerateAlertEvents.java
@@ -19,12 +19,7 @@
*/
package org.sonar.plugins.core.sensors;
-import org.sonar.api.batch.Decorator;
-import org.sonar.api.batch.DecoratorContext;
-import org.sonar.api.batch.DependsUpon;
-import org.sonar.api.batch.Event;
-import org.sonar.api.batch.TimeMachine;
-import org.sonar.api.batch.TimeMachineQuery;
+import org.sonar.api.batch.*;
import org.sonar.api.measures.CoreMetrics;
import org.sonar.api.measures.Measure;
import org.sonar.api.measures.Metric;
@@ -71,7 +66,7 @@ public class GenerateAlertEvents implements Decorator {
TimeMachineQuery query = new TimeMachineQuery(resource).setOnlyLastAnalysis(true).setMetrics(CoreMetrics.ALERT_STATUS);
List<Measure> measures = timeMachine.getMeasures(query);
- Measure pastStatus = (measures != null && measures.size() == 1 ? measures.get(0) : null);
+ Measure pastStatus = measures != null && measures.size() == 1 ? measures.get(0) : null;
String alertText = currentStatus.getAlertText();
Level alertLevel = currentStatus.getDataAsLevel();
String alertName = null;
diff --git a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/TendencyAnalyser.java b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/TendencyAnalyser.java
index 6923ec0fa94..92c964f7b61 100644
--- a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/TendencyAnalyser.java
+++ b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/timemachine/TendencyAnalyser.java
@@ -68,9 +68,9 @@ public class TendencyAnalyser {
if (nullValuesYList || nbrPoints == 1) {
return null;
}
- double n0 = ((nbrPoints * sumXY) - (sumX * sumY));
- double d = ((nbrPoints * sumXPower2) - (sumX * sumX));
- double n1 = ((sumY * sumXPower2) - (sumX * sumXY));
+ double n0 = (nbrPoints * sumXY) - (sumX * sumY);
+ double d = (nbrPoints * sumXPower2) - (sumX * sumX);
+ double n1 = (sumY * sumXPower2) - (sumX * sumXY);
SlopeData result = new SlopeData();
diff --git a/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/ui/libraries/client/ProjectPanel.java b/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/ui/libraries/client/ProjectPanel.java
index 0dff6d7e40d..14d269610b5 100644
--- a/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/ui/libraries/client/ProjectPanel.java
+++ b/plugins/sonar-design-plugin/src/main/java/org/sonar/plugins/design/ui/libraries/client/ProjectPanel.java
@@ -108,7 +108,7 @@ public class ProjectPanel extends FlowPanel {
}
public void filter() {
- boolean visible = (tree.getItemCount() == 0 && !filters.hasKeyword());
+ boolean visible = tree.getItemCount() == 0 && !filters.hasKeyword();
for (int index = 0; index < tree.getItemCount(); index++) {
Library lib = (Library) tree.getItem(index);
visible |= !lib.filter(filters.getKeywordFilter().getKeyword(), filters.isTestFiltered());