Fix some quality flaws

1 files changed, 9 insertions, 6 deletions

diff --git a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/AlertUtils.java b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/AlertUtils.java
index 5d5e6c89a2c..95951013333 100644
--- a/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/AlertUtils.java
+++ b/plugins/sonar-core-plugin/src/main/java/org/sonar/plugins/core/sensors/AlertUtils.java
@@ -52,16 +52,19 @@ public final class AlertUtils {
     Comparable criteriaValue = getValueForComparison(alert.getMetric(), valueToEval);
     Comparable measureValue = getMeasureValue(alert, measure);
     if (measureValue != null) {
-      int comparison = measureValue.compareTo(criteriaValue);
-      return !(// NOSONAR complexity of this boolean expression is under control
-          (alert.isNotEqualsOperator() && comparison == 0)
-              || (alert.isGreaterOperator() && comparison != 1)
-              || (alert.isSmallerOperator() && comparison != -1)
-              || (alert.isEqualsOperator() && comparison != 0));
+      return doesReachThresholds(measureValue, criteriaValue, alert);
     }
     return false;
   }
 
+  private static boolean doesReachThresholds(Comparable measureValue, Comparable criteriaValue, Alert alert){
+    int comparison = measureValue.compareTo(criteriaValue);
+    return !((alert.isNotEqualsOperator() && comparison == 0)
+        || (alert.isGreaterOperator() && comparison != 1)
+        || (alert.isSmallerOperator() && comparison != -1)
+        || (alert.isEqualsOperator() && comparison != 0));
+  }
+
   private static String getValueToEval(Alert alert, Metric.Level alertLevel) {
     if (alertLevel.equals(Metric.Level.ERROR)) {
       return alert.getValueError();