aboutsummaryrefslogtreecommitdiffstats
path: root/plugins
diff options
context:
space:
mode:
authorDavid Gageot <david@gageot.net>2012-09-17 16:27:08 +0200
committerDavid Gageot <david@gageot.net>2012-09-20 12:07:32 +0200
commit1b000a65c28f43a3242c55f91a0cc7f6a210e979 (patch)
tree776139ba456138bd8042ef1f409121a057e10c4f /plugins
parentc77bc1df270111bd96c300f4a7a856b71045737d (diff)
downloadsonarqube-1b000a65c28f43a3242c55f91a0cc7f6a210e979.tar.gz
sonarqube-1b000a65c28f43a3242c55f91a0cc7f6a210e979.zip
Don't use anyObject() matcher
Diffstat (limited to 'plugins')
-rw-r--r--plugins/sonar-checkstyle-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleExecutorTest.java12
-rw-r--r--plugins/sonar-checkstyle-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleProfileImporterTest.java13
-rw-r--r--plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/CheckAlertThresholdsTest.java2
-rw-r--r--plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/GenerateAlertEventsTest.java12
-rw-r--r--plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ProfileEventsSensorTest.java9
-rw-r--r--plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/VersionEventsSensorTest.java6
-rw-r--r--plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ViolationsDecoratorTest.java25
-rw-r--r--plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/WeightedViolationsDecoratorTest.java16
-rw-r--r--plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/NewCoverageFileAnalyzerTest.java6
-rw-r--r--plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/ViolationPersisterDecoratorTest.java4
-rw-r--r--plugins/sonar-cpd-plugin/src/test/java/org/sonar/plugins/cpd/decorators/SumDuplicationsDecoratorTest.java17
-rw-r--r--plugins/sonar-pmd-plugin/src/test/java/org/sonar/plugins/pmd/PmdProfileImporterTest.java4
-rw-r--r--plugins/sonar-surefire-plugin/src/test/java/org/sonar/plugins/surefire/SurefireSensorTest.java30
-rw-r--r--plugins/sonar-surefire-plugin/src/test/java/org/sonar/plugins/surefire/api/AbstractSurefireParserTest.java32
14 files changed, 106 insertions, 82 deletions
diff --git a/plugins/sonar-checkstyle-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleExecutorTest.java b/plugins/sonar-checkstyle-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleExecutorTest.java
index f92e2259af3..6f7f320aa71 100644
--- a/plugins/sonar-checkstyle-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleExecutorTest.java
+++ b/plugins/sonar-checkstyle-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleExecutorTest.java
@@ -34,7 +34,7 @@ import java.util.Locale;
import static org.hamcrest.core.Is.is;
import static org.junit.Assert.assertThat;
import static org.junit.internal.matchers.StringContains.containsString;
-import static org.mockito.Matchers.anyObject;
+import static org.mockito.Matchers.any;
import static org.mockito.Matchers.argThat;
import static org.mockito.Mockito.atLeast;
import static org.mockito.Mockito.mock;
@@ -51,8 +51,8 @@ public class CheckstyleExecutorTest {
CheckstyleExecutor executor = new CheckstyleExecutor(conf, listener, getClass().getClassLoader());
executor.execute();
- verify(listener, times(1)).auditStarted((AuditEvent) anyObject());
- verify(listener, times(1)).auditFinished((AuditEvent) anyObject());
+ verify(listener, times(1)).auditStarted(any(AuditEvent.class));
+ verify(listener, times(1)).auditFinished(any(AuditEvent.class));
verify(listener, times(1)).fileStarted(argThat(newFilenameMatcher("Hello.java")));
verify(listener, times(1)).fileFinished(argThat(newFilenameMatcher("Hello.java")));
verify(listener, times(1)).fileStarted(argThat(newFilenameMatcher("World.java")));
@@ -77,7 +77,7 @@ public class CheckstyleExecutorTest {
return new ArgumentMatcher<AuditEvent>() {
@Override
public boolean matches(Object o) {
- AuditEvent event = (AuditEvent)o;
+ AuditEvent event = (AuditEvent) o;
return StringUtils.endsWith(event.getFileName(), filename) && StringUtils.equals(event.getSourceName(), rule);
}
};
@@ -87,7 +87,7 @@ public class CheckstyleExecutorTest {
return new ArgumentMatcher<AuditEvent>() {
@Override
public boolean matches(Object o) {
- AuditEvent event = (AuditEvent)o;
+ AuditEvent event = (AuditEvent) o;
return StringUtils.endsWith(event.getFileName(), filename);
}
};
@@ -101,7 +101,7 @@ public class CheckstyleExecutorTest {
CheckstyleConfiguration conf = mock(CheckstyleConfiguration.class);
when(conf.getCharset()).thenReturn(Charset.defaultCharset());
when(conf.getCheckstyleConfiguration()).thenReturn(CheckstyleConfiguration.toCheckstyleConfiguration(new File("test-resources/checkstyle-conf.xml")));
- when(conf.getSourceFiles()).thenReturn(Arrays.<File>asList(new File("test-resources/Hello.java"), new File("test-resources/World.java")));
+ when(conf.getSourceFiles()).thenReturn(Arrays.<File> asList(new File("test-resources/Hello.java"), new File("test-resources/World.java")));
when(conf.getLocale()).thenReturn(Locale.ENGLISH);
return conf;
}
diff --git a/plugins/sonar-checkstyle-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleProfileImporterTest.java b/plugins/sonar-checkstyle-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleProfileImporterTest.java
index 6fffd91a7fb..61f89285662 100644
--- a/plugins/sonar-checkstyle-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleProfileImporterTest.java
+++ b/plugins/sonar-checkstyle-plugin/src/test/java/org/sonar/plugins/checkstyle/CheckstyleProfileImporterTest.java
@@ -25,7 +25,11 @@ import org.junit.Test;
import org.mockito.invocation.InvocationOnMock;
import org.mockito.stubbing.Answer;
import org.sonar.api.profiles.RulesProfile;
-import org.sonar.api.rules.*;
+import org.sonar.api.rules.ActiveRule;
+import org.sonar.api.rules.Rule;
+import org.sonar.api.rules.RuleFinder;
+import org.sonar.api.rules.RulePriority;
+import org.sonar.api.rules.RuleQuery;
import org.sonar.api.utils.ValidationMessages;
import org.sonar.test.TestUtils;
@@ -37,7 +41,7 @@ import static org.hamcrest.core.IsNull.nullValue;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertThat;
-import static org.mockito.Matchers.anyObject;
+import static org.mockito.Matchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
@@ -115,7 +119,8 @@ public class CheckstyleProfileImporterTest {
RulesProfile profile = importer.importProfile(reader, messages);
assertNotNull(profile.getActiveRuleByConfigKey("checkstyle", "Checker/JavadocPackage"));
- assertThat(profile.getActiveRuleByConfigKey("checkstyle", "Checker/JavadocPackage").getRule().getKey(), is("com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck_12345"));
+ assertThat(profile.getActiveRuleByConfigKey("checkstyle", "Checker/JavadocPackage").getRule().getKey(),
+ is("com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck_12345"));
assertThat(messages.getWarnings().size(), is(0));
}
@@ -139,7 +144,7 @@ public class CheckstyleProfileImporterTest {
private RuleFinder newRuleFinder() {
RuleFinder ruleFinder = mock(RuleFinder.class);
- when(ruleFinder.find((RuleQuery) anyObject())).thenAnswer(new Answer<Rule>() {
+ when(ruleFinder.find(any(RuleQuery.class))).thenAnswer(new Answer<Rule>() {
public Rule answer(InvocationOnMock iom) throws Throwable {
RuleQuery query = (RuleQuery) iom.getArguments()[0];
Rule rule = null;
diff --git a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/CheckAlertThresholdsTest.java b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/CheckAlertThresholdsTest.java
index 9d9f3088164..1843350e396 100644
--- a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/CheckAlertThresholdsTest.java
+++ b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/CheckAlertThresholdsTest.java
@@ -92,7 +92,7 @@ public class CheckAlertThresholdsTest {
decorator.decorate(project, context);
- verify(context, never()).saveMeasure((Measure) anyObject());
+ verify(context, never()).saveMeasure(any(Measure.class));
}
@Test
diff --git a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/GenerateAlertEventsTest.java b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/GenerateAlertEventsTest.java
index f6ccdb668b3..ddbd9cc18e4 100644
--- a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/GenerateAlertEventsTest.java
+++ b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/GenerateAlertEventsTest.java
@@ -38,7 +38,7 @@ import java.util.Date;
import static org.hamcrest.CoreMatchers.is;
import static org.junit.Assert.assertThat;
-import static org.mockito.Matchers.anyObject;
+import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyString;
import static org.mockito.Matchers.isNull;
import static org.mockito.Mockito.mock;
@@ -89,7 +89,7 @@ public class GenerateAlertEventsTest {
@Test
public void shouldCreateEventWhenWarnToError() {
- when(timeMachine.getMeasures((TimeMachineQuery) anyObject())).thenReturn(Arrays.asList(newAlertStatus(Metric.Level.WARN, "desc")));
+ when(timeMachine.getMeasures(any(TimeMachineQuery.class))).thenReturn(Arrays.asList(newAlertStatus(Metric.Level.WARN, "desc")));
when(context.getMeasure(CoreMetrics.ALERT_STATUS)).thenReturn(newAlertStatus(Metric.Level.ERROR, "desc"));
decorator.decorate(project, context);
@@ -99,7 +99,7 @@ public class GenerateAlertEventsTest {
@Test
public void shouldCreateEventWhenErrorToOk() {
- when(timeMachine.getMeasures((TimeMachineQuery) anyObject())).thenReturn(Arrays.asList(newAlertStatus(Metric.Level.ERROR, "desc")));
+ when(timeMachine.getMeasures(any(TimeMachineQuery.class))).thenReturn(Arrays.asList(newAlertStatus(Metric.Level.ERROR, "desc")));
when(context.getMeasure(CoreMetrics.ALERT_STATUS)).thenReturn(newAlertStatus(Metric.Level.OK, null));
decorator.decorate(project, context);
@@ -109,7 +109,7 @@ public class GenerateAlertEventsTest {
@Test
public void shouldCreateEventWhenErrorToWarn() {
- when(timeMachine.getMeasures((TimeMachineQuery) anyObject())).thenReturn(Arrays.asList(newAlertStatus(Metric.Level.ERROR, "desc")));
+ when(timeMachine.getMeasures(any(TimeMachineQuery.class))).thenReturn(Arrays.asList(newAlertStatus(Metric.Level.ERROR, "desc")));
when(context.getMeasure(CoreMetrics.ALERT_STATUS)).thenReturn(newAlertStatus(Metric.Level.WARN, "desc"));
decorator.decorate(project, context);
@@ -126,7 +126,7 @@ public class GenerateAlertEventsTest {
@Test
public void shouldNotCreateEventWhenSameLevel() {
- when(timeMachine.getMeasures((TimeMachineQuery) anyObject())).thenReturn(Arrays.asList(newAlertStatus(Metric.Level.ERROR, "desc")));
+ when(timeMachine.getMeasures(any(TimeMachineQuery.class))).thenReturn(Arrays.asList(newAlertStatus(Metric.Level.ERROR, "desc")));
when(context.getMeasure(CoreMetrics.ALERT_STATUS)).thenReturn(newAlertStatus(Metric.Level.ERROR, "desc"));
decorator.decorate(project, context);
@@ -136,7 +136,7 @@ public class GenerateAlertEventsTest {
@Test
public void shouldNotCreateEventIfNoMoreAlertStatus() {
- when(timeMachine.getMeasures((TimeMachineQuery) anyObject())).thenReturn(Arrays.asList(newAlertStatus(Metric.Level.ERROR, "desc")));
+ when(timeMachine.getMeasures(any(TimeMachineQuery.class))).thenReturn(Arrays.asList(newAlertStatus(Metric.Level.ERROR, "desc")));
when(context.getMeasure(CoreMetrics.ALERT_STATUS)).thenReturn(null);
decorator.decorate(project, context);
diff --git a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ProfileEventsSensorTest.java b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ProfileEventsSensorTest.java
index 8ce2c25ebf8..2eb7f73a0f8 100644
--- a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ProfileEventsSensorTest.java
+++ b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ProfileEventsSensorTest.java
@@ -38,7 +38,6 @@ import java.util.Date;
import static org.hamcrest.Matchers.is;
import static org.junit.Assert.assertThat;
import static org.mockito.Matchers.any;
-import static org.mockito.Matchers.anyObject;
import static org.mockito.Matchers.anyString;
import static org.mockito.Matchers.eq;
import static org.mockito.Matchers.same;
@@ -73,7 +72,7 @@ public class ProfileEventsSensorTest {
sensor.analyse(project, context);
- verify(context, never()).createEvent((Resource) anyObject(), anyString(), anyString(), anyString(), (Date) anyObject());
+ verify(context, never()).createEvent(any(Resource.class), anyString(), anyString(), anyString(), any(Date.class));
}
@Test
@@ -98,7 +97,7 @@ public class ProfileEventsSensorTest {
verify(context).createEvent(same(project),
eq("Foo version 1"),
eq("Foo version 1 is used instead of Bar version 1"),
- same(Event.CATEGORY_PROFILE), (Date) anyObject());
+ same(Event.CATEGORY_PROFILE), any(Date.class));
}
@Test
@@ -112,7 +111,7 @@ public class ProfileEventsSensorTest {
verify(context).createEvent(same(project),
eq("Foo version 2"),
eq("Foo version 2 is used instead of Foo version 1"),
- same(Event.CATEGORY_PROFILE), (Date) anyObject());
+ same(Event.CATEGORY_PROFILE), any(Date.class));
}
@Test
@@ -137,7 +136,7 @@ public class ProfileEventsSensorTest {
verify(context).createEvent(same(project),
eq("Foo version 2"),
eq("Foo version 2 is used instead of Foo version 1"),
- same(Event.CATEGORY_PROFILE), (Date) anyObject());
+ same(Event.CATEGORY_PROFILE), any(Date.class));
}
private RulesProfile mockProfileWithVersion(int version) {
diff --git a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/VersionEventsSensorTest.java b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/VersionEventsSensorTest.java
index c1dbd67d4f1..a93270a2882 100644
--- a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/VersionEventsSensorTest.java
+++ b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/VersionEventsSensorTest.java
@@ -32,7 +32,7 @@ import java.util.Date;
import static org.hamcrest.Matchers.is;
import static org.junit.Assert.assertThat;
-import static org.mockito.Matchers.anyObject;
+import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyString;
import static org.mockito.Matchers.eq;
import static org.mockito.Matchers.isNull;
@@ -65,8 +65,8 @@ public class VersionEventsSensorTest {
sensor.analyse(project, context);
- verify(context, never()).createEvent((Resource) anyObject(), anyString(), anyString(), anyString(), (Date) anyObject());
- verify(context, never()).deleteEvent((Event) anyObject());
+ verify(context, never()).createEvent(any(Resource.class), anyString(), anyString(), anyString(), any(Date.class));
+ verify(context, never()).deleteEvent(any(Event.class));
}
@Test
diff --git a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ViolationsDecoratorTest.java b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ViolationsDecoratorTest.java
index 665b59aa721..8bffe0e33aa 100644
--- a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ViolationsDecoratorTest.java
+++ b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/ViolationsDecoratorTest.java
@@ -36,8 +36,15 @@ import org.sonar.api.test.IsRuleMeasure;
import java.util.Collections;
import java.util.List;
-import static org.mockito.Matchers.*;
-import static org.mockito.Mockito.*;
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.anyDouble;
+import static org.mockito.Matchers.argThat;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
public class ViolationsDecoratorTest {
private Rule ruleA1;
@@ -63,7 +70,7 @@ public class ViolationsDecoratorTest {
public void shouldCountViolations() {
when(resource.getScope()).thenReturn(Scopes.PROJECT);
when(context.getViolations()).thenReturn(createViolations());
- when(context.getChildrenMeasures((MeasuresFilter) anyObject())).thenReturn(Collections.<Measure>emptyList());
+ when(context.getChildrenMeasures(any(MeasuresFilter.class))).thenReturn(Collections.<Measure> emptyList());
decorator.decorate(resource, context);
@@ -77,7 +84,7 @@ public class ViolationsDecoratorTest {
public void shouldNotCountViolationsIfMeasureAlreadyExists() {
when(resource.getScope()).thenReturn(Scopes.PROJECT);
when(context.getViolations()).thenReturn(createViolations());
- when(context.getChildrenMeasures((MeasuresFilter) anyObject())).thenReturn(Collections.<Measure>emptyList());
+ when(context.getChildrenMeasures(any(MeasuresFilter.class))).thenReturn(Collections.<Measure> emptyList());
when(context.getMeasure(CoreMetrics.VIOLATIONS)).thenReturn(new Measure(CoreMetrics.VIOLATIONS, 3000.0));
when(context.getMeasure(CoreMetrics.MAJOR_VIOLATIONS)).thenReturn(new Measure(CoreMetrics.MAJOR_VIOLATIONS, 500.0));
@@ -91,8 +98,8 @@ public class ViolationsDecoratorTest {
@Test
public void shouldSaveZeroOnProjects() {
when(resource.getScope()).thenReturn(Scopes.PROJECT);
- when(context.getViolations()).thenReturn(Collections.<Violation>emptyList());
- when(context.getChildrenMeasures((MeasuresFilter) anyObject())).thenReturn(Collections.<Measure>emptyList());
+ when(context.getViolations()).thenReturn(Collections.<Violation> emptyList());
+ when(context.getChildrenMeasures(any(MeasuresFilter.class))).thenReturn(Collections.<Measure> emptyList());
decorator.decorate(resource, context);
@@ -102,8 +109,8 @@ public class ViolationsDecoratorTest {
@Test
public void shouldSaveZeroOnDirectories() {
when(resource.getScope()).thenReturn(Scopes.DIRECTORY);
- when(context.getViolations()).thenReturn(Collections.<Violation>emptyList());
- when(context.getChildrenMeasures((MeasuresFilter) anyObject())).thenReturn(Collections.<Measure>emptyList());
+ when(context.getViolations()).thenReturn(Collections.<Violation> emptyList());
+ when(context.getChildrenMeasures(any(MeasuresFilter.class))).thenReturn(Collections.<Measure> emptyList());
decorator.decorate(resource, context);
@@ -114,7 +121,7 @@ public class ViolationsDecoratorTest {
public void shouldCountViolationsBySeverity() {
when(resource.getScope()).thenReturn(Scopes.PROJECT);
when(context.getViolations()).thenReturn(createViolations());
- when(context.getChildrenMeasures((MeasuresFilter) anyObject())).thenReturn(Collections.<Measure>emptyList());
+ when(context.getChildrenMeasures(any(MeasuresFilter.class))).thenReturn(Collections.<Measure> emptyList());
decorator.decorate(resource, context);
diff --git a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/WeightedViolationsDecoratorTest.java b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/WeightedViolationsDecoratorTest.java
index 0628860fe0a..106daee27ed 100644
--- a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/WeightedViolationsDecoratorTest.java
+++ b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/sensors/WeightedViolationsDecoratorTest.java
@@ -19,13 +19,6 @@
*/
package org.sonar.plugins.core.sensors;
-import static org.junit.Assert.assertThat;
-import static org.mockito.Matchers.anyObject;
-import static org.mockito.Matchers.argThat;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
-
import org.hamcrest.core.Is;
import org.junit.Test;
import org.sonar.api.CoreProperties;
@@ -36,6 +29,13 @@ import org.sonar.api.measures.Measure;
import org.sonar.api.rules.RulePriority;
import org.sonar.api.test.IsMeasure;
+import static org.junit.Assert.assertThat;
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.argThat;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
public class WeightedViolationsDecoratorTest {
@Test
@@ -66,7 +66,7 @@ public class WeightedViolationsDecoratorTest {
decorator.start();
decorator.decorate(context);
- verify(context).saveMeasure((Measure) anyObject());
+ verify(context).saveMeasure(any(Measure.class));
}
@Test
diff --git a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/NewCoverageFileAnalyzerTest.java b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/NewCoverageFileAnalyzerTest.java
index e3c44deea6d..8cc276ae9ea 100644
--- a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/NewCoverageFileAnalyzerTest.java
+++ b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/NewCoverageFileAnalyzerTest.java
@@ -33,7 +33,7 @@ import java.util.Arrays;
import java.util.Date;
import java.util.List;
-import static org.mockito.Matchers.anyObject;
+import static org.mockito.Matchers.any;
import static org.mockito.Matchers.argThat;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
@@ -50,7 +50,7 @@ public class NewCoverageFileAnalyzerTest {
AbstractNewCoverageFileAnalyzer decorator = newDecorator();
decorator.doDecorate(context);
- verify(context, never()).saveMeasure((Measure) anyObject());
+ verify(context, never()).saveMeasure(any(Measure.class));
}
@Test
@@ -62,7 +62,7 @@ public class NewCoverageFileAnalyzerTest {
AbstractNewCoverageFileAnalyzer decorator = newDecorator();
decorator.doDecorate(context);
- verify(context, never()).saveMeasure((Measure) anyObject());
+ verify(context, never()).saveMeasure(any(Measure.class));
}
@Test
diff --git a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/ViolationPersisterDecoratorTest.java b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/ViolationPersisterDecoratorTest.java
index e9c67c5e64b..5b70cfd69c1 100644
--- a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/ViolationPersisterDecoratorTest.java
+++ b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/timemachine/ViolationPersisterDecoratorTest.java
@@ -35,7 +35,7 @@ import org.sonar.jpa.test.AbstractDbUnitTestCase;
import java.util.Arrays;
-import static org.mockito.Matchers.anyObject;
+import static org.mockito.Matchers.any;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
@@ -54,7 +54,7 @@ public class ViolationPersisterDecoratorTest extends AbstractDbUnitTestCase {
setupData("shared");
Snapshot snapshot = getSession().getSingleResult(Snapshot.class, "id", 1000);
ResourcePersister resourcePersister = mock(ResourcePersister.class);
- when(resourcePersister.saveResource((Project) anyObject(), eq(javaFile))).thenReturn(snapshot);
+ when(resourcePersister.saveResource(any(Project.class), eq(javaFile))).thenReturn(snapshot);
when(resourcePersister.getSnapshot(javaFile)).thenReturn(snapshot);
tracker = mock(ViolationTrackingDecorator.class);
decorator = new ViolationPersisterDecorator(tracker, resourcePersister, new DefaultRuleFinder(getSessionFactory()), getSession());
diff --git a/plugins/sonar-cpd-plugin/src/test/java/org/sonar/plugins/cpd/decorators/SumDuplicationsDecoratorTest.java b/plugins/sonar-cpd-plugin/src/test/java/org/sonar/plugins/cpd/decorators/SumDuplicationsDecoratorTest.java
index 1b84b1aa166..070d4b7376a 100644
--- a/plugins/sonar-cpd-plugin/src/test/java/org/sonar/plugins/cpd/decorators/SumDuplicationsDecoratorTest.java
+++ b/plugins/sonar-cpd-plugin/src/test/java/org/sonar/plugins/cpd/decorators/SumDuplicationsDecoratorTest.java
@@ -19,13 +19,7 @@
*/
package org.sonar.plugins.cpd.decorators;
-import static org.hamcrest.CoreMatchers.is;
-import static org.hamcrest.number.OrderingComparisons.greaterThan;
-import static org.junit.Assert.assertThat;
import org.junit.Test;
-import static org.mockito.Matchers.anyObject;
-import static org.mockito.Matchers.argThat;
-import static org.mockito.Mockito.*;
import org.sonar.api.batch.DecoratorContext;
import org.sonar.api.measures.CoreMetrics;
import org.sonar.api.measures.Measure;
@@ -33,6 +27,15 @@ import org.sonar.api.resources.JavaFile;
import org.sonar.api.resources.Resource;
import org.sonar.api.test.IsMeasure;
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.number.OrderingComparisons.greaterThan;
+import static org.junit.Assert.assertThat;
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.argThat;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+
public class SumDuplicationsDecoratorTest {
@Test
@@ -50,7 +53,7 @@ public class SumDuplicationsDecoratorTest {
decorator.decorate(unitTest, context);
- verify(context, never()).saveMeasure((Measure) anyObject());
+ verify(context, never()).saveMeasure(any(Measure.class));
}
@Test
diff --git a/plugins/sonar-pmd-plugin/src/test/java/org/sonar/plugins/pmd/PmdProfileImporterTest.java b/plugins/sonar-pmd-plugin/src/test/java/org/sonar/plugins/pmd/PmdProfileImporterTest.java
index 1920a580140..9744390354e 100644
--- a/plugins/sonar-pmd-plugin/src/test/java/org/sonar/plugins/pmd/PmdProfileImporterTest.java
+++ b/plugins/sonar-pmd-plugin/src/test/java/org/sonar/plugins/pmd/PmdProfileImporterTest.java
@@ -37,7 +37,7 @@ import java.io.Reader;
import java.io.StringReader;
import static org.fest.assertions.Assertions.assertThat;
-import static org.mockito.Matchers.anyObject;
+import static org.mockito.Matchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
@@ -161,7 +161,7 @@ public class PmdProfileImporterTest {
static RuleFinder createRuleFinder() {
RuleFinder ruleFinder = mock(RuleFinder.class);
- when(ruleFinder.find((RuleQuery) anyObject())).then(new Answer<Rule>() {
+ when(ruleFinder.find(any(RuleQuery.class))).then(new Answer<Rule>() {
public Rule answer(InvocationOnMock invocation) {
RuleQuery query = (RuleQuery) invocation.getArguments()[0];
Rule rule = Rule.create(query.getRepositoryKey(), "", "").setConfigKey(query.getConfigKey()).setSeverity(RulePriority.BLOCKER);
diff --git a/plugins/sonar-surefire-plugin/src/test/java/org/sonar/plugins/surefire/SurefireSensorTest.java b/plugins/sonar-surefire-plugin/src/test/java/org/sonar/plugins/surefire/SurefireSensorTest.java
index 6e0c37c0996..e641d4a38b8 100644
--- a/plugins/sonar-surefire-plugin/src/test/java/org/sonar/plugins/surefire/SurefireSensorTest.java
+++ b/plugins/sonar-surefire-plugin/src/test/java/org/sonar/plugins/surefire/SurefireSensorTest.java
@@ -19,12 +19,6 @@
*/
package org.sonar.plugins.surefire;
-import static org.hamcrest.CoreMatchers.is;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertThat;
-import static org.mockito.Matchers.*;
-import static org.mockito.Mockito.*;
-
import org.apache.commons.lang.ObjectUtils;
import org.custommonkey.xmlunit.DetailedDiff;
import org.custommonkey.xmlunit.Diff;
@@ -36,7 +30,12 @@ import org.sonar.api.batch.SensorContext;
import org.sonar.api.measures.CoreMetrics;
import org.sonar.api.measures.Measure;
import org.sonar.api.measures.Metric;
-import org.sonar.api.resources.*;
+import org.sonar.api.resources.Java;
+import org.sonar.api.resources.JavaFile;
+import org.sonar.api.resources.Project;
+import org.sonar.api.resources.Qualifiers;
+import org.sonar.api.resources.Resource;
+import org.sonar.api.resources.Scopes;
import org.sonar.api.test.IsMeasure;
import org.sonar.api.test.IsResource;
import org.sonar.api.test.MavenTestUtils;
@@ -46,6 +45,19 @@ import java.io.FileReader;
import java.io.StringReader;
import java.net.URISyntaxException;
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertThat;
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.anyDouble;
+import static org.mockito.Matchers.argThat;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
public class SurefireSensorTest {
@Test
@@ -88,7 +100,7 @@ public class SurefireSensorTest {
verify(context, times(3)).saveMeasure(argThat(new IsResource(Scopes.FILE, Qualifiers.UNIT_TEST_FILE)),
eq(CoreMetrics.TESTS), anyDouble());
verify(context, times(18)).saveMeasure(argThat(new IsResource(Scopes.FILE, Qualifiers.UNIT_TEST_FILE)),
- (Metric) anyObject(), anyDouble());
+ any(Metric.class), anyDouble());
verify(context, times(3)).saveMeasure(argThat(new IsResource(Scopes.FILE, Qualifiers.UNIT_TEST_FILE)),
argThat(new IsMeasure(CoreMetrics.TEST_DATA)));
@@ -133,7 +145,7 @@ public class SurefireSensorTest {
verify(context, times(1)).saveMeasure(argThat(new IsResource(Scopes.FILE, Qualifiers.UNIT_TEST_FILE)),
eq(CoreMetrics.TESTS), anyDouble());
verify(context, times(6)).saveMeasure(argThat(new IsResource(Scopes.FILE, Qualifiers.UNIT_TEST_FILE)),
- (Metric) anyObject(), anyDouble());
+ any(Metric.class), anyDouble());
verify(context, times(1)).saveMeasure(argThat(new IsResource(Scopes.FILE, Qualifiers.UNIT_TEST_FILE)),
argThat(new IsMeasure(CoreMetrics.TEST_DATA)));
diff --git a/plugins/sonar-surefire-plugin/src/test/java/org/sonar/plugins/surefire/api/AbstractSurefireParserTest.java b/plugins/sonar-surefire-plugin/src/test/java/org/sonar/plugins/surefire/api/AbstractSurefireParserTest.java
index b85b96a7910..7853b8d76b5 100644
--- a/plugins/sonar-surefire-plugin/src/test/java/org/sonar/plugins/surefire/api/AbstractSurefireParserTest.java
+++ b/plugins/sonar-surefire-plugin/src/test/java/org/sonar/plugins/surefire/api/AbstractSurefireParserTest.java
@@ -19,23 +19,8 @@
*/
package org.sonar.plugins.surefire.api;
-import static org.mockito.Matchers.any;
-import static org.mockito.Matchers.anyDouble;
-import static org.mockito.Matchers.anyObject;
-import static org.mockito.Matchers.argThat;
-import static org.mockito.Matchers.eq;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.times;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
-
-import org.mockito.ArgumentMatcher;
-
-import java.net.URISyntaxException;
-import java.util.Arrays;
-
import org.junit.Test;
+import org.mockito.ArgumentMatcher;
import org.sonar.api.batch.SensorContext;
import org.sonar.api.measures.CoreMetrics;
import org.sonar.api.measures.Metric;
@@ -47,6 +32,19 @@ import org.sonar.api.resources.Scopes;
import org.sonar.api.test.IsMeasure;
import org.sonar.api.test.IsResource;
+import java.net.URISyntaxException;
+import java.util.Arrays;
+
+import static org.mockito.Matchers.any;
+import static org.mockito.Matchers.anyDouble;
+import static org.mockito.Matchers.argThat;
+import static org.mockito.Matchers.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
public class AbstractSurefireParserTest {
@Test
@@ -112,7 +110,7 @@ public class AbstractSurefireParserTest {
parser.collect(new Project("foo"), context, getDir("noTests"));
- verify(context, never()).saveMeasure(any(Resource.class), (Metric) anyObject(), anyDouble());
+ verify(context, never()).saveMeasure(any(Resource.class), any(Metric.class), anyDouble());
}
@Test