diff options
| author | simonbrandhof <simon.brandhof@gmail.com> | 2010-09-23 17:28:25 +0000 |
|---|---|---|
| committer | simonbrandhof <simon.brandhof@gmail.com> | 2010-09-23 17:28:25 +0000 |
| commit | 1dfd7034c4cb735683949cef50a8e3809bab6a35 (patch) | |
| tree | bd5692842fa4e17eb557bfaadd86e70654824a54 /plugins | |
| parent | ab9fa99f65324e32caccc5f7016b9aa88c56aca2 (diff) | |
| download | sonarqube-1dfd7034c4cb735683949cef50a8e3809bab6a35.tar.gz sonarqube-1dfd7034c4cb735683949cef50a8e3809bab6a35.zip | |
add AnnotationRuleRepository to load rules from sonar-check-api annotations
Diffstat (limited to 'plugins')
4 files changed, 3 insertions, 4 deletions
diff --git a/plugins/sonar-checkstyle-plugin/src/main/java/org/sonar/plugins/checkstyle/CheckstyleAuditListener.java b/plugins/sonar-checkstyle-plugin/src/main/java/org/sonar/plugins/checkstyle/CheckstyleAuditListener.java index 07741906041..33f7f46cc8c 100644 --- a/plugins/sonar-checkstyle-plugin/src/main/java/org/sonar/plugins/checkstyle/CheckstyleAuditListener.java +++ b/plugins/sonar-checkstyle-plugin/src/main/java/org/sonar/plugins/checkstyle/CheckstyleAuditListener.java @@ -53,7 +53,7 @@ public class CheckstyleAuditListener implements AuditListener, BatchExtension { Rule rule = ruleFinder.findByKey(CheckstyleConstants.REPOSITORY_KEY, ruleKey); if (rule != null) { initResource(event); - Violation violation = new Violation(rule, currentResource) + Violation violation = Violation.create(rule, currentResource) .setLineId(getLineId(event)) .setMessage(getMessage(event)); context.saveViolation(violation); diff --git a/plugins/sonar-findbugs-plugin/src/main/java/org/sonar/plugins/findbugs/FindbugsSensor.java b/plugins/sonar-findbugs-plugin/src/main/java/org/sonar/plugins/findbugs/FindbugsSensor.java index f1ba161bb8c..421172e9a70 100644 --- a/plugins/sonar-findbugs-plugin/src/main/java/org/sonar/plugins/findbugs/FindbugsSensor.java +++ b/plugins/sonar-findbugs-plugin/src/main/java/org/sonar/plugins/findbugs/FindbugsSensor.java @@ -60,7 +60,7 @@ public class FindbugsSensor implements Sensor, DependsUponMavenPlugin, Generates Rule rule = ruleFinder.findByKey(FindbugsConstants.REPOSITORY_KEY, fbViolation.getType()); JavaFile resource = new JavaFile(fbViolation.getSonarJavaFileKey()); if (context.getResource(resource) != null) { - Violation violation = new Violation(rule, resource).setLineId(fbViolation.getStart()).setMessage(fbViolation.getLongMessage()); + Violation violation = Violation.create(rule, resource).setLineId(fbViolation.getStart()).setMessage(fbViolation.getLongMessage()); context.saveViolation(violation); } } diff --git a/plugins/sonar-pmd-plugin/src/test/java/org/sonar/plugins/pmd/PmdViolationsXmlParserTest.java b/plugins/sonar-pmd-plugin/src/test/java/org/sonar/plugins/pmd/PmdViolationsXmlParserTest.java index d06042d5b59..fdfea3f98ba 100644 --- a/plugins/sonar-pmd-plugin/src/test/java/org/sonar/plugins/pmd/PmdViolationsXmlParserTest.java +++ b/plugins/sonar-pmd-plugin/src/test/java/org/sonar/plugins/pmd/PmdViolationsXmlParserTest.java @@ -72,7 +72,7 @@ public class PmdViolationsXmlParserTest { verify(context, times(30)).saveViolation(argThat(new IsViolationOnJavaClass())); verify(context, times(4)).saveViolation(argThat(new IsViolationOnJavaClass(new JavaFile("ch.hortis.sonar.mvn.ClassWithComments")))); - Violation wanted = new Violation(null, new JavaFile("ch.hortis.sonar.mvn.ClassWithComments")) + Violation wanted = Violation.create((Rule)null, new JavaFile("ch.hortis.sonar.mvn.ClassWithComments")) .setMessage("Avoid unused local variables such as 'toto'.") .setLineId(22); verify(context, times(1)).saveViolation(argThat(new IsViolation(wanted))); diff --git a/plugins/sonar-squid-java-plugin/pom.xml b/plugins/sonar-squid-java-plugin/pom.xml index 4d09d61ebef..9ae8a290a2f 100644 --- a/plugins/sonar-squid-java-plugin/pom.xml +++ b/plugins/sonar-squid-java-plugin/pom.xml @@ -134,7 +134,6 @@ <skip>true</skip> </configuration> </plugin> - </plugins> </build> </project> |