aboutsummaryrefslogtreecommitdiffstats
path: root/server/sonar-process
diff options
context:
space:
mode:
authorStephane Gamard <stephane.gamard@searchbox.com>2014-07-15 22:10:28 +0200
committerStephane Gamard <stephane.gamard@searchbox.com>2014-07-15 22:54:53 +0200
commitc69ae78fc6b2c860e34c4b601b76f00698a8ccfa (patch)
treec9370991ac699371ab067b35136debc8824f1788 /server/sonar-process
parent866094481df814943f0c597a18381aa68618323a (diff)
downloadsonarqube-c69ae78fc6b2c860e34c4b601b76f00698a8ccfa.tar.gz
sonarqube-c69ae78fc6b2c860e34c4b601b76f00698a8ccfa.zip
fix tests and outputs.
Diffstat (limited to 'server/sonar-process')
-rw-r--r--server/sonar-process/src/main/java/org/sonar/process/ProcessWrapper.java2
-rw-r--r--server/sonar-process/src/test/java/org/sonar/process/ProcessTest.java20
2 files changed, 21 insertions, 1 deletions
diff --git a/server/sonar-process/src/main/java/org/sonar/process/ProcessWrapper.java b/server/sonar-process/src/main/java/org/sonar/process/ProcessWrapper.java
index f1997f2d09a..5f14e83b45c 100644
--- a/server/sonar-process/src/main/java/org/sonar/process/ProcessWrapper.java
+++ b/server/sonar-process/src/main/java/org/sonar/process/ProcessWrapper.java
@@ -141,7 +141,7 @@ public class ProcessWrapper {
processBuilder.environment().putAll(properties);
processBuilder.environment().put(Process.NAME_PROPERTY, this.getName());
processBuilder.environment().put(Process.PORT_PROPERTY, Integer.toString(port));
- System.out.println("processBuilder.toString(); = " + processBuilder.toString());
+
try {
java.lang.Process process = processBuilder.start();
errorGobbler = new StreamGobbler(process.getErrorStream(), this.getName() + "-ERROR");
diff --git a/server/sonar-process/src/test/java/org/sonar/process/ProcessTest.java b/server/sonar-process/src/test/java/org/sonar/process/ProcessTest.java
index 08e7d24a5b4..7d300208a5c 100644
--- a/server/sonar-process/src/test/java/org/sonar/process/ProcessTest.java
+++ b/server/sonar-process/src/test/java/org/sonar/process/ProcessTest.java
@@ -55,6 +55,26 @@ public class ProcessTest {
}
@Test
+ public void fails_invalid_name() {
+ try {
+ Process.objectNameFor("::");
+ fail();
+ } catch (Exception e) {
+ assertThat(e.getMessage()).isEqualTo("Cannot create ObjectName for ::");
+ }
+ }
+
+ @Test
+ public void fail_missing_properties() {
+ Properties properties = new Properties();
+ try {
+ new TestProcess(Props.create(properties));
+ } catch (Exception e) {
+ assertThat(e.getMessage()).isEqualTo(Process.MISSING_NAME_ARGUMENT);
+ }
+ }
+
+ @Test
public void should_register_mbean() throws Exception {
MBeanServer mbeanServer = ManagementFactory.getPlatformMBeanServer();