diff options
author | Julien Lancelot <julien.lancelot@sonarsource.com> | 2018-03-22 17:19:25 +0100 |
---|---|---|
committer | Julien Lancelot <julien.lancelot@sonarsource.com> | 2018-04-04 08:49:17 +0200 |
commit | 41d6681a6828be8ce51ec955afd8e4168a1af85f (patch) | |
tree | bd767939933cf7f11b930e1858a30b3d14e960ab /server/sonar-server/src | |
parent | f06a639eee611734771ee8d7e335b7bc9a9b3016 (diff) | |
download | sonarqube-41d6681a6828be8ce51ec955afd8e4168a1af85f.tar.gz sonarqube-41d6681a6828be8ce51ec955afd8e4168a1af85f.zip |
SONAR-10285 WS org/enable_support is now only available on SonarCloud
Diffstat (limited to 'server/sonar-server/src')
2 files changed, 39 insertions, 11 deletions
diff --git a/server/sonar-server/src/main/java/org/sonar/server/organization/ws/OrganizationsWsModule.java b/server/sonar-server/src/main/java/org/sonar/server/organization/ws/OrganizationsWsModule.java index dccacc427fd..f27020591f8 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/organization/ws/OrganizationsWsModule.java +++ b/server/sonar-server/src/main/java/org/sonar/server/organization/ws/OrganizationsWsModule.java @@ -19,26 +19,38 @@ */ package org.sonar.server.organization.ws; +import org.sonar.api.config.Configuration; import org.sonar.core.platform.Module; +import static org.sonar.core.config.WebConstants.SONARCLOUD_ENABLED; + public class OrganizationsWsModule extends Module { + private final Configuration config; + + public OrganizationsWsModule(Configuration config) { + this.config = config; + } + @Override protected void configureModule() { add( OrganizationsWs.class, OrganizationsWsSupport.class, // actions - AddMemberAction.class, - CreateAction.class, - DeleteAction.class, - EnableSupportAction.class, - RemoveMemberAction.class, SearchAction.class, SearchMembersAction.class, - SearchMyOrganizationsAction.class, - UpdateAction.class, - UpdateProjectVisibilityAction.class); + SearchMyOrganizationsAction.class); + if (config.getBoolean(SONARCLOUD_ENABLED).orElse(false)) { + add( + EnableSupportAction.class, + AddMemberAction.class, + CreateAction.class, + DeleteAction.class, + RemoveMemberAction.class, + UpdateAction.class, + UpdateProjectVisibilityAction.class); + } } } diff --git a/server/sonar-server/src/test/java/org/sonar/server/organization/ws/OrganizationsWsModuleTest.java b/server/sonar-server/src/test/java/org/sonar/server/organization/ws/OrganizationsWsModuleTest.java index 3ced226dcae..66c96ce2047 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/organization/ws/OrganizationsWsModuleTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/organization/ws/OrganizationsWsModuleTest.java @@ -20,18 +20,34 @@ package org.sonar.server.organization.ws; import org.junit.Test; +import org.sonar.api.config.internal.MapSettings; import org.sonar.core.platform.ComponentContainer; import static org.assertj.core.api.Assertions.assertThat; import static org.sonar.core.platform.ComponentContainer.COMPONENTS_IN_EMPTY_COMPONENT_CONTAINER; public class OrganizationsWsModuleTest { - private OrganizationsWsModule underTest = new OrganizationsWsModule(); + + private ComponentContainer container = new ComponentContainer(); + private MapSettings mapSettings = new MapSettings(); + private OrganizationsWsModule underTest = new OrganizationsWsModule(mapSettings.asConfig()); + + @Test + public void verify_component_count_when_not_on_sonar_cloud() { + mapSettings.setProperty("sonar.sonarcloud.enabled", false); + + underTest.configure(container); + + assertThat(container.getPicoContainer().getComponentAdapters()) + .hasSize(COMPONENTS_IN_EMPTY_COMPONENT_CONTAINER + 5); + } @Test - public void verify_component_count() { - ComponentContainer container = new ComponentContainer(); + public void verify_component_count_when_on_sonar_cloud() { + mapSettings.setProperty("sonar.sonarcloud.enabled", true); + underTest.configure(container); + assertThat(container.getPicoContainer().getComponentAdapters()) .hasSize(COMPONENTS_IN_EMPTY_COMPONENT_CONTAINER + 12); } |