diff options
author | Janos Gyerik <janos.gyerik@sonarsource.com> | 2018-07-03 13:16:03 +0200 |
---|---|---|
committer | SonarTech <sonartech@sonarsource.com> | 2018-07-17 20:21:23 +0200 |
commit | 2a185ff22d5bbf3c19e4a890adce0ab08d2dfd5e (patch) | |
tree | ac62cbff23fc53b59782472d86a1e24161a4c204 /server/sonar-server | |
parent | 6bc80f2bd6ccd4f599435a25ca1d4cb94c5f0086 (diff) | |
download | sonarqube-2a185ff22d5bbf3c19e4a890adce0ab08d2dfd5e.tar.gz sonarqube-2a185ff22d5bbf3c19e4a890adce0ab08d2dfd5e.zip |
SONAR-10986 Extend RulesDefinitions API to support security standards (#466)
Diffstat (limited to 'server/sonar-server')
-rw-r--r-- | server/sonar-server/src/main/java/org/sonar/server/rule/RuleCreator.java | 1 | ||||
-rw-r--r-- | server/sonar-server/src/test/java/org/sonar/server/rule/RuleCreatorTest.java | 2 |
2 files changed, 3 insertions, 0 deletions
diff --git a/server/sonar-server/src/main/java/org/sonar/server/rule/RuleCreator.java b/server/sonar-server/src/main/java/org/sonar/server/rule/RuleCreator.java index b6823f0e3ef..78b157c4eb0 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/rule/RuleCreator.java +++ b/server/sonar-server/src/main/java/org/sonar/server/rule/RuleCreator.java @@ -170,6 +170,7 @@ public class RuleCreator { .setGapDescription(templateRuleDto.getGapDescription()) .setScope(templateRuleDto.getScope()) .setSystemTags(templateRuleDto.getSystemTags()) + .setSecurityStandards(templateRuleDto.getSecurityStandards()) .setCreatedAt(system2.now()) .setUpdatedAt(system2.now()); dbClient.ruleDao().insert(dbSession, ruleDefinition); diff --git a/server/sonar-server/src/test/java/org/sonar/server/rule/RuleCreatorTest.java b/server/sonar-server/src/test/java/org/sonar/server/rule/RuleCreatorTest.java index e09db08a604..4dff170b40e 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/rule/RuleCreatorTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/rule/RuleCreatorTest.java @@ -103,6 +103,7 @@ public class RuleCreatorTest { assertThat(rule.getGapDescription()).isEqualTo("desc"); assertThat(rule.getTags()).containsOnly("usertag1", "usertag2"); assertThat(rule.getSystemTags()).containsOnly("tag1", "tag4"); + assertThat(rule.getSecurityStandards()).containsOnly("owaspTop10:a1", "cwe:123"); List<RuleParamDto> params = dbTester.getDbClient().ruleDao().selectRuleParamsByRuleKey(dbSession, customRuleKey); assertThat(params).hasSize(1); @@ -468,6 +469,7 @@ public class RuleCreatorTest { .setGapDescription("desc") .setTags(Sets.newHashSet("usertag1", "usertag2")) .setSystemTags(Sets.newHashSet("tag1", "tag4")) + .setSecurityStandards(Sets.newHashSet("owaspTop10:a1", "cwe:123")) .setCreatedAt(new Date().getTime()) .setUpdatedAt(new Date().getTime()); dbTester.rules().insert(templateRule.getDefinition()); |