SONAR-16537 Improve scrolling on issue page

3 files changed, 0 insertions, 20 deletions

diff --git a/server/sonar-web/src/main/js/apps/component-measures/components/MeasureContent.tsx b/server/sonar-web/src/main/js/apps/component-measures/components/MeasureContent.tsx
index 37ab7387f28..744ac1dc509 100644
--- a/server/sonar-web/src/main/js/apps/component-measures/components/MeasureContent.tsx
+++ b/server/sonar-web/src/main/js/apps/component-measures/components/MeasureContent.tsx
@@ -29,7 +29,6 @@ import { getComponentMeasureUniqueKey } from '../../../helpers/component';
 import { translate } from '../../../helpers/l10n';
 import { isDiffMetric } from '../../../helpers/measures';
 import { RequestData } from '../../../helpers/request';
-import { scrollToElement } from '../../../helpers/scrolling';
 import { getProjectUrl } from '../../../helpers/urls';
 import { BranchLike } from '../../../types/branch-like';
 import { isFile, isView } from '../../../types/component';
@@ -286,11 +285,6 @@ export default class MeasureContent extends React.PureComponent<Props, State> {
     return index !== -1 ? index : undefined;
   };
 
-  handleScroll = (element: Element) => {
-    const offset = window.innerHeight / 2;
-    scrollToElement(element, { topOffset: offset - 100, bottomOffset: offset, smooth: true });
-  };
-
   getDefaultShowBestMeasures() {
     const { asc, view } = this.props;
     if ((asc !== undefined && view === 'list') || view === 'tree') {
@@ -420,7 +414,6 @@ export default class MeasureContent extends React.PureComponent<Props, State> {
                 component={baseComponent.key}
                 metricKey={this.state.metric?.key}
                 onIssueChange={this.props.onIssueChange}
-                scroll={this.handleScroll}
               />
             </div>
           ) : (
diff --git a/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/MeasureContent-test.tsx b/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/MeasureContent-test.tsx
index 861f7d075ac..de6447408c5 100644
--- a/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/MeasureContent-test.tsx
+++ b/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/MeasureContent-test.tsx
@@ -21,7 +21,6 @@ import { shallow } from 'enzyme';
 import * as React from 'react';
 import { getComponentTree } from '../../../../api/components';
 import { mockComponentMeasure } from '../../../../helpers/mocks/component';
-import { scrollToElement } from '../../../../helpers/scrolling';
 import { mockRouter } from '../../../../helpers/testMocks';
 import { waitAndUpdate } from '../../../../helpers/testUtils';
 import MeasureContent from '../MeasureContent';
@@ -120,17 +119,6 @@ it('should render correctly for a file', async () => {
   expect(wrapper).toMatchSnapshot();
 });
 
-it('should correctly handle scrolling', () => {
-  const element = {} as Element;
-  const wrapper = shallowRender();
-  wrapper.instance().handleScroll(element);
-  expect(scrollToElement).toBeCalledWith(element, {
-    topOffset: 300,
-    bottomOffset: 400,
-    smooth: true
-  });
-});
-
 it('should test fetchMoreComponents to work correctly', async () => {
   (getComponentTree as jest.Mock).mockResolvedValueOnce({
     paging: { pageIndex: 12, pageSize: 500, total: 0 },
diff --git a/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/__snapshots__/MeasureContent-test.tsx.snap b/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/__snapshots__/MeasureContent-test.tsx.snap
index 9335ebc7657..e81c83983dc 100644
--- a/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/__snapshots__/MeasureContent-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/__snapshots__/MeasureContent-test.tsx.snap
@@ -102,7 +102,6 @@ exports[`should render correctly for a file 1`] = `
         displayIssueLocationsLink={true}
         displayLocationMarkers={true}
         metricKey="bugs"
-        scroll={[Function]}
       />
     </div>
   </div>