diff options
author | Stas Vilchik <vilchiks@gmail.com> | 2017-02-07 09:54:17 +0100 |
---|---|---|
committer | Stas Vilchik <vilchiks@gmail.com> | 2017-02-07 09:54:30 +0100 |
commit | f760aabc58687ffa7794c056ff3195ba1eee3a5b (patch) | |
tree | 89d6929f46cac68f31bd1b49e1bd6d0d9ea6c81a /server/sonar-web/src/main/js/apps/issues | |
parent | ac69e7c18e1b4d86be4ea1085ef3b38c7bda531c (diff) | |
download | sonarqube-f760aabc58687ffa7794c056ff3195ba1eee3a5b.tar.gz sonarqube-f760aabc58687ffa7794c056ff3195ba1eee3a5b.zip |
fix quality flaws
Diffstat (limited to 'server/sonar-web/src/main/js/apps/issues')
5 files changed, 7 insertions, 7 deletions
diff --git a/server/sonar-web/src/main/js/apps/issues/component-viewer/main.js b/server/sonar-web/src/main/js/apps/issues/component-viewer/main.js index 4736fdcfe50..c677a6aaf81 100644 --- a/server/sonar-web/src/main/js/apps/issues/component-viewer/main.js +++ b/server/sonar-web/src/main/js/apps/issues/component-viewer/main.js @@ -40,7 +40,7 @@ export default SourceViewer.extend({ this.bindShortcuts(); if (this.baseIssue != null) { this.baseIssue.trigger('locations', this.baseIssue); - return this.scrollToLine(this.baseIssue.get('line')); + this.scrollToLine(this.baseIssue.get('line')); } }, @@ -51,7 +51,7 @@ export default SourceViewer.extend({ if (!selectedIssueView) { return; } - return selectedIssueView.find('.js-issue-' + action).click(); + selectedIssueView.find('.js-issue-' + action).click(); }; key('up', 'componentViewer', () => { that.options.app.controller.selectPrev(); diff --git a/server/sonar-web/src/main/js/apps/issues/controller.js b/server/sonar-web/src/main/js/apps/issues/controller.js index bdb0455f456..7bb4dff6a91 100644 --- a/server/sonar-web/src/main/js/apps/issues/controller.js +++ b/server/sonar-web/src/main/js/apps/issues/controller.js @@ -80,7 +80,7 @@ export default Controller.extend({ }); } if (firstPage && that.isIssuePermalink()) { - return that.showComponentViewer(that.options.app.list.first()); + that.showComponentViewer(that.options.app.list.first()); } }); }, @@ -112,7 +112,7 @@ export default Controller.extend({ }); const facetData = r.facets.find(facet => facet.property === id); if (facetData != null) { - return facet.set(facetData); + facet.set(facetData); } }); }, diff --git a/server/sonar-web/src/main/js/apps/issues/facets/assignee-facet.js b/server/sonar-web/src/main/js/apps/issues/facets/assignee-facet.js index 9c327ffe51f..5556853dbc2 100644 --- a/server/sonar-web/src/main/js/apps/issues/facets/assignee-facet.js +++ b/server/sonar-web/src/main/js/apps/issues/facets/assignee-facet.js @@ -48,7 +48,7 @@ export default CustomValuesFacet.extend({ const value = this.options.app.state.get('query').assigned; if ((value != null) && (!value || value === 'false')) { - return this.$('.js-facet').filter('[data-unassigned]').addClass('active'); + this.$('.js-facet').filter('[data-unassigned]').addClass('active'); } }, diff --git a/server/sonar-web/src/main/js/apps/issues/facets/creation-date-facet.js b/server/sonar-web/src/main/js/apps/issues/facets/creation-date-facet.js index 2ed322dc140..ae53f5ab467 100644 --- a/server/sonar-web/src/main/js/apps/issues/facets/creation-date-facet.js +++ b/server/sonar-web/src/main/js/apps/issues/facets/creation-date-facet.js @@ -56,7 +56,7 @@ export default BaseFacet.extend({ props.forEach(prop => { const value = query[prop]; if (value != null) { - return that.$(`input[name=${prop}]`).val(value); + that.$(`input[name=${prop}]`).val(value); } }); let values = this.model.getValues(); diff --git a/server/sonar-web/src/main/js/apps/issues/facets/resolution-facet.js b/server/sonar-web/src/main/js/apps/issues/facets/resolution-facet.js index 2a2720ba468..4d23327c619 100644 --- a/server/sonar-web/src/main/js/apps/issues/facets/resolution-facet.js +++ b/server/sonar-web/src/main/js/apps/issues/facets/resolution-facet.js @@ -29,7 +29,7 @@ export default BaseFacet.extend({ BaseFacet.prototype.onRender.apply(this, arguments); const value = this.options.app.state.get('query').resolved; if ((value != null) && (!value || value === 'false')) { - return this.$('.js-facet').filter('[data-unresolved]').addClass('active'); + this.$('.js-facet').filter('[data-unresolved]').addClass('active'); } }, |