diff options
author | Stas Vilchik <stas.vilchik@sonarsource.com> | 2017-10-10 16:56:47 +0200 |
---|---|---|
committer | Stas Vilchik <stas.vilchik@sonarsource.com> | 2017-10-11 12:02:21 +0200 |
commit | 2076e3bd0143ffc4f88c180ce3fa3b9ac41b3f85 (patch) | |
tree | b279ea209e0b6379017c1be3a064b9217eb54188 /server/sonar-web/src/main/js/apps/issues | |
parent | 20ed9553b9a1012f341c1f5d4a594221ae437600 (diff) | |
download | sonarqube-2076e3bd0143ffc4f88c180ce3fa3b9ac41b3f85.tar.gz sonarqube-2076e3bd0143ffc4f88c180ce3fa3b9ac41b3f85.zip |
SONAR-7709 Help users to not enter wrong date periods
Diffstat (limited to 'server/sonar-web/src/main/js/apps/issues')
-rw-r--r-- | server/sonar-web/src/main/js/apps/issues/components/App.js | 51 | ||||
-rw-r--r-- | server/sonar-web/src/main/js/apps/issues/sidebar/CreationDateFacet.js | 2 |
2 files changed, 29 insertions, 24 deletions
diff --git a/server/sonar-web/src/main/js/apps/issues/components/App.js b/server/sonar-web/src/main/js/apps/issues/components/App.js index f6616f229ed..984aedca11c 100644 --- a/server/sonar-web/src/main/js/apps/issues/components/App.js +++ b/server/sonar-web/src/main/js/apps/issues/components/App.js @@ -420,7 +420,7 @@ export default class App extends React.PureComponent { if (this.mounted) { this.setState({ loading: false }); } - return Promise.reject(); + return []; } ); } @@ -518,29 +518,32 @@ export default class App extends React.PureComponent { }; fetchFacet = (facet /*: string */) => { - return this.fetchIssues({ ps: 1, facets: mapFacet(facet) }).then(({ facets, ...other }) => { - if (this.mounted) { - this.setState(state => ({ - facets: { ...state.facets, ...parseFacets(facets) }, - referencedComponents: { - ...state.referencedComponents, - ...keyBy(other.components, 'uuid') - }, - referencedLanguages: { - ...state.referencedLanguages, - ...keyBy(other.languages, 'key') - }, - referencedRules: { - ...state.referencedRules, - ...keyBy(other.rules, 'key') - }, - referencedUsers: { - ...state.referencedUsers, - ...keyBy(other.users, 'login') - } - })); - } - }); + return this.fetchIssues({ ps: 1, facets: mapFacet(facet) }).then( + ({ facets, ...other }) => { + if (this.mounted) { + this.setState(state => ({ + facets: { ...state.facets, ...parseFacets(facets) }, + referencedComponents: { + ...state.referencedComponents, + ...keyBy(other.components, 'uuid') + }, + referencedLanguages: { + ...state.referencedLanguages, + ...keyBy(other.languages, 'key') + }, + referencedRules: { + ...state.referencedRules, + ...keyBy(other.rules, 'key') + }, + referencedUsers: { + ...state.referencedUsers, + ...keyBy(other.users, 'login') + } + })); + } + }, + () => {} + ); }; isFiltered = () => { diff --git a/server/sonar-web/src/main/js/apps/issues/sidebar/CreationDateFacet.js b/server/sonar-web/src/main/js/apps/issues/sidebar/CreationDateFacet.js index 461d3405d14..edc61cf799d 100644 --- a/server/sonar-web/src/main/js/apps/issues/sidebar/CreationDateFacet.js +++ b/server/sonar-web/src/main/js/apps/issues/sidebar/CreationDateFacet.js @@ -228,6 +228,7 @@ export default class CreationDateFacet extends React.PureComponent { <DateInput className="search-navigator-date-facet-selection-dropdown-left" inputClassName="search-navigator-date-facet-selection-input" + maxDate={createdBefore ? toShortNotSoISOString(createdBefore) : '+0'} onChange={this.handlePeriodChangeAfter} placeholder={translate('from')} value={createdAfter ? toShortNotSoISOString(createdAfter) : undefined} @@ -235,6 +236,7 @@ export default class CreationDateFacet extends React.PureComponent { <DateInput className="search-navigator-date-facet-selection-dropdown-right" inputClassName="search-navigator-date-facet-selection-input" + minDate={createdAfter ? toShortNotSoISOString(createdAfter) : undefined} onChange={this.handlePeriodChangeBefore} placeholder={translate('to')} value={createdBefore ? toShortNotSoISOString(createdBefore) : undefined} |