aboutsummaryrefslogtreecommitdiffstats
path: root/server/sonar-web/src/main/js/apps/projectQualityGate
diff options
context:
space:
mode:
authorGrégoire Aubert <gregoire.aubert@sonarsource.com>2017-11-24 17:00:35 +0100
committerEric Hartmann <hartmann.eric@gmail.Com>2017-12-04 13:44:55 +0100
commit21e116729e9d8529f6a0a70dce996eb4fba3e1e1 (patch)
treed5120823c94a0894dafdd4015f4db44528fbfc38 /server/sonar-web/src/main/js/apps/projectQualityGate
parent878887d3f9ecd7c580c911b8d80e16871393b9f5 (diff)
downloadsonarqube-21e116729e9d8529f6a0a70dce996eb4fba3e1e1.tar.gz
sonarqube-21e116729e9d8529f6a0a70dce996eb4fba3e1e1.zip
Apply feedback
Diffstat (limited to 'server/sonar-web/src/main/js/apps/projectQualityGate')
-rw-r--r--server/sonar-web/src/main/js/apps/projectQualityGate/Form.tsx7
-rw-r--r--server/sonar-web/src/main/js/apps/projectQualityGate/__tests__/__snapshots__/Form-test.tsx.snap5
2 files changed, 0 insertions, 12 deletions
diff --git a/server/sonar-web/src/main/js/apps/projectQualityGate/Form.tsx b/server/sonar-web/src/main/js/apps/projectQualityGate/Form.tsx
index a2bcf4111cf..909767bfed9 100644
--- a/server/sonar-web/src/main/js/apps/projectQualityGate/Form.tsx
+++ b/server/sonar-web/src/main/js/apps/projectQualityGate/Form.tsx
@@ -18,7 +18,6 @@
* Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*/
import * as React from 'react';
-import { some } from 'lodash';
import { QualityGate } from '../../api/quality-gates';
import Select from '../../components/controls/Select';
import { translate } from '../../helpers/l10n';
@@ -96,11 +95,6 @@ export default class Form extends React.PureComponent<Props, State> {
isDefault: gate.isDefault
}));
- const hasDefault = some(allGates, gate => gate.isDefault);
- if (!hasDefault) {
- options.unshift({ value: '', label: translate('none') });
- }
-
return (
<Select
clearable={false}
@@ -108,7 +102,6 @@ export default class Form extends React.PureComponent<Props, State> {
onChange={this.handleChange}
optionRenderer={this.renderGateName}
options={options}
- placeholder={translate('none')}
style={{ width: 300 }}
value={gate && String(gate.id)}
valueRenderer={this.renderGateName}
diff --git a/server/sonar-web/src/main/js/apps/projectQualityGate/__tests__/__snapshots__/Form-test.tsx.snap b/server/sonar-web/src/main/js/apps/projectQualityGate/__tests__/__snapshots__/Form-test.tsx.snap
index 3e5a39759b8..e7620afb1a2 100644
--- a/server/sonar-web/src/main/js/apps/projectQualityGate/__tests__/__snapshots__/Form-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/projectQualityGate/__tests__/__snapshots__/Form-test.tsx.snap
@@ -10,10 +10,6 @@ exports[`renders 1`] = `
options={
Array [
Object {
- "label": "none",
- "value": "",
- },
- Object {
"isDefault": undefined,
"label": "name-1",
"value": "1",
@@ -25,7 +21,6 @@ exports[`renders 1`] = `
},
]
}
- placeholder="none"
style={
Object {
"width": 300,