diff options
| author | Mathieu Suen <mathieu.suen@sonarsource.com> | 2022-04-25 11:18:53 +0200 |
|---|---|---|
| committer | sonartech <sonartech@sonarsource.com> | 2022-04-25 20:02:45 +0000 |
| commit | 64f91092e3303593f6bed7f24a02a20c36a2b5f7 (patch) | |
| tree | 8c71cb105e48537cd6d1978095ce13cc066efd6e /server/sonar-web/src/main/js/apps/system/components | |
| parent | adc7b775698154811b7d06360f8a02a7907b1183 (diff) | |
| download | sonarqube-64f91092e3303593f6bed7f24a02a20c36a2b5f7.tar.gz sonarqube-64f91092e3303593f6bed7f24a02a20c36a2b5f7.zip | |
SONAR-16301 Replace React legacy lifecycle methods in settings
Diffstat (limited to 'server/sonar-web/src/main/js/apps/system/components')
| -rw-r--r-- | server/sonar-web/src/main/js/apps/system/components/ChangeLogLevelForm.tsx | 4 | ||||
| -rw-r--r-- | server/sonar-web/src/main/js/apps/system/components/PageActions.tsx | 15 |
2 files changed, 5 insertions, 14 deletions
diff --git a/server/sonar-web/src/main/js/apps/system/components/ChangeLogLevelForm.tsx b/server/sonar-web/src/main/js/apps/system/components/ChangeLogLevelForm.tsx index b1f219464af..0e2a643b97e 100644 --- a/server/sonar-web/src/main/js/apps/system/components/ChangeLogLevelForm.tsx +++ b/server/sonar-web/src/main/js/apps/system/components/ChangeLogLevelForm.tsx @@ -28,7 +28,7 @@ import { LOGS_LEVELS } from '../utils'; interface Props { infoMsg: string; logLevel: string; - onChange: (level: string) => void; + onChange: () => void; onClose: () => void; } @@ -49,7 +49,7 @@ export default class ChangeLogLevelForm extends React.PureComponent<Props, State if (!this.state.updating) { this.setState({ updating: true }); setLogLevel(newLevel).then( - () => this.props.onChange(newLevel), + () => this.props.onChange(), () => this.setState({ updating: false }) ); } diff --git a/server/sonar-web/src/main/js/apps/system/components/PageActions.tsx b/server/sonar-web/src/main/js/apps/system/components/PageActions.tsx index b7f1c1bd909..527ec1b1ee7 100644 --- a/server/sonar-web/src/main/js/apps/system/components/PageActions.tsx +++ b/server/sonar-web/src/main/js/apps/system/components/PageActions.tsx @@ -38,7 +38,6 @@ interface Props { } interface State { - logLevel: string; openLogsLevelForm: boolean; } @@ -46,23 +45,15 @@ export default class PageActions extends React.PureComponent<Props, State> { constructor(props: Props) { super(props); this.state = { - logLevel: props.logLevel, openLogsLevelForm: false }; } - componentWillReceiveProps(nextProps: Props) { - if (nextProps.logLevel !== this.state.logLevel) { - this.setState({ logLevel: nextProps.logLevel }); - } - } - handleLogsLevelOpen = () => { this.setState({ openLogsLevelForm: true }); }; - handleLogsLevelChange = (logLevel: string) => { - this.setState({ logLevel }); + handleLogsLevelChange = () => { this.props.onLogLevelChange(); this.handleLogsLevelClose(); }; @@ -84,7 +75,7 @@ export default class PageActions extends React.PureComponent<Props, State> { <span className="text-middle"> {translate('system.logs_level')} {':'} - <strong className="little-spacer-left">{this.state.logLevel}</strong> + <strong className="little-spacer-left">{this.props.logLevel}</strong> </span> <EditButton className="spacer-left button-small" @@ -181,7 +172,7 @@ export default class PageActions extends React.PureComponent<Props, State> { infoMsg={translate( this.props.cluster ? 'system.cluster_log_level.info' : 'system.log_level.info' )} - logLevel={this.state.logLevel} + logLevel={this.props.logLevel} onChange={this.handleLogsLevelChange} onClose={this.handleLogsLevelClose} /> |