diff options
author | Grégoire Aubert <gregoire.aubert@sonarsource.com> | 2017-05-10 10:32:33 +0200 |
---|---|---|
committer | Grégoire Aubert <gregoire.aubert@sonarsource.com> | 2017-05-10 11:56:20 +0200 |
commit | 7f939f50b63f7c6ac7aab6d8fbb71a06193df0be (patch) | |
tree | 0fe8d207b9b88b8757179843068eb074f75c1864 /server/sonar-web/src/main/js/apps | |
parent | 9821488bd9e3f764dc4f3a7fdd4beda93e870254 (diff) | |
download | sonarqube-7f939f50b63f7c6ac7aab6d8fbb71a06193df0be.tar.gz sonarqube-7f939f50b63f7c6ac7aab6d8fbb71a06193df0be.zip |
Apply review comments
Diffstat (limited to 'server/sonar-web/src/main/js/apps')
6 files changed, 14 insertions, 12 deletions
diff --git a/server/sonar-web/src/main/js/apps/code/components/App.js b/server/sonar-web/src/main/js/apps/code/components/App.js index 1918cac2abf..a85387a0e5e 100644 --- a/server/sonar-web/src/main/js/apps/code/components/App.js +++ b/server/sonar-web/src/main/js/apps/code/components/App.js @@ -181,7 +181,7 @@ class App extends React.PureComponent { return ( <div className="page page-limited"> - <Helmet title={translate('code')} /> + <Helmet title={translate('code.page')} /> {error && <div className="alert alert-danger"> diff --git a/server/sonar-web/src/main/js/apps/coding-rules/components/CodingRulesAppContainer.js b/server/sonar-web/src/main/js/apps/coding-rules/components/CodingRulesAppContainer.js index 52b1b29d6a1..020977d998a 100644 --- a/server/sonar-web/src/main/js/apps/coding-rules/components/CodingRulesAppContainer.js +++ b/server/sonar-web/src/main/js/apps/coding-rules/components/CodingRulesAppContainer.js @@ -72,7 +72,7 @@ class CodingRulesAppContainer extends React.PureComponent { // but react wants it to be there to unmount it return ( <div> - <Helmet title={translate('rules')} /> + <Helmet title={translate('coding_rules.page')} /> <div ref="container" /> </div> ); diff --git a/server/sonar-web/src/main/js/apps/organizations/components/OrganizationDelete.js b/server/sonar-web/src/main/js/apps/organizations/components/OrganizationDelete.js index 1cd73c0be0f..dbfce33a3fd 100644 --- a/server/sonar-web/src/main/js/apps/organizations/components/OrganizationDelete.js +++ b/server/sonar-web/src/main/js/apps/organizations/components/OrganizationDelete.js @@ -95,12 +95,13 @@ class OrganizationDelete extends React.PureComponent { } render() { + const title = translate('organization.delete'); return ( <div className="page page-limited"> - <Helmet title={translate('delete')} /> + <Helmet title={title} /> <header className="page-header"> - <h1 className="page-title">{translate('organization.delete')}</h1> + <h1 className="page-title">{title}</h1> <div className="page-description">{translate('organization.delete.description')}</div> </header> diff --git a/server/sonar-web/src/main/js/apps/organizations/components/OrganizationEdit.js b/server/sonar-web/src/main/js/apps/organizations/components/OrganizationEdit.js index e108da282a5..a75fd2d9444 100644 --- a/server/sonar-web/src/main/js/apps/organizations/components/OrganizationEdit.js +++ b/server/sonar-web/src/main/js/apps/organizations/components/OrganizationEdit.js @@ -95,12 +95,13 @@ class OrganizationEdit extends React.PureComponent { }; render() { + const title = translate('organization.edit'); return ( <div className="page page-limited"> - <Helmet title={translate('edit')} /> + <Helmet title={title} /> <header className="page-header"> - <h1 className="page-title">{translate('organization.edit')}</h1> + <h1 className="page-title">{title}</h1> </header> <form onSubmit={this.handleSubmit}> diff --git a/server/sonar-web/src/main/js/apps/organizations/components/__tests__/__snapshots__/OrganizationDelete-test.js.snap b/server/sonar-web/src/main/js/apps/organizations/components/__tests__/__snapshots__/OrganizationDelete-test.js.snap index fa13f06a074..4762fa4e4d9 100644 --- a/server/sonar-web/src/main/js/apps/organizations/components/__tests__/__snapshots__/OrganizationDelete-test.js.snap +++ b/server/sonar-web/src/main/js/apps/organizations/components/__tests__/__snapshots__/OrganizationDelete-test.js.snap @@ -5,7 +5,7 @@ exports[`smoke test 1`] = ` className="page page-limited" > <HelmetWrapper - title="delete" + title="organization.delete" /> <header className="page-header" @@ -38,7 +38,7 @@ exports[`smoke test 2`] = ` className="page page-limited" > <HelmetWrapper - title="delete" + title="organization.delete" /> <header className="page-header" @@ -119,7 +119,7 @@ exports[`smoke test 3`] = ` className="page page-limited" > <HelmetWrapper - title="delete" + title="organization.delete" /> <header className="page-header" diff --git a/server/sonar-web/src/main/js/apps/organizations/components/__tests__/__snapshots__/OrganizationEdit-test.js.snap b/server/sonar-web/src/main/js/apps/organizations/components/__tests__/__snapshots__/OrganizationEdit-test.js.snap index 9fe30235a62..86dcb2b5556 100644 --- a/server/sonar-web/src/main/js/apps/organizations/components/__tests__/__snapshots__/OrganizationEdit-test.js.snap +++ b/server/sonar-web/src/main/js/apps/organizations/components/__tests__/__snapshots__/OrganizationEdit-test.js.snap @@ -5,7 +5,7 @@ exports[`smoke test 1`] = ` className="page page-limited" > <HelmetWrapper - title="edit" + title="organization.edit" /> <header className="page-header" @@ -136,7 +136,7 @@ exports[`smoke test 2`] = ` className="page page-limited" > <HelmetWrapper - title="edit" + title="organization.edit" /> <header className="page-header" @@ -282,7 +282,7 @@ exports[`smoke test 3`] = ` className="page page-limited" > <HelmetWrapper - title="edit" + title="organization.edit" /> <header className="page-header" |