rewrite remaining popups in react (#3109)

* extract baseFontFamily

* rewrite favorites store in ts

* add new types and change existing ones

* rewrite SourceViewer helpers in ts

* rewrite SourceViewer in ts and its popups in react

* drop popups

* fix iterating over nodelist

* fix quality flaws

1 files changed, 38 insertions, 0 deletions

diff --git a/server/sonar-web/src/main/js/components/issue/Issue.d.ts b/server/sonar-web/src/main/js/components/issue/Issue.d.ts
new file mode 100644
index 00000000000..5abf041951b
--- /dev/null
+++ b/server/sonar-web/src/main/js/components/issue/Issue.d.ts
@@ -0,0 +1,38 @@
+/*
+ * SonarQube
+ * Copyright (C) 2009-2018 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+import * as React from 'react';
+import { Issue as IssueType } from '../../app/types';
+
+interface IssueProps {
+  branch?: string;
+  checked?: boolean;
+  displayLocationsCount?: boolean;
+  displayLocationsLink?: boolean;
+  issue: IssueType;
+  onChange: (issue: IssueType) => void;
+  onCheck?: (issueKey: string) => void;
+  onClick: (issueKey: string) => void;
+  onFilter?: (property: string, issue: IssueType) => void;
+  onPopupToggle: (issue: string, popupName: string, open?: boolean) => void;
+  openPopup?: string;
+  selected: boolean;
+}
+
+export default class Issue extends React.PureComponent<IssueProps> {}