diff options
author | Stas Vilchik <stas.vilchik@sonarsource.com> | 2018-05-14 17:22:53 +0200 |
---|---|---|
committer | SonarTech <sonartech@sonarsource.com> | 2018-05-14 20:20:49 +0200 |
commit | 2c91ba5af11b8e5955b65d4f0f76ea0e8917afbd (patch) | |
tree | 2bd822b92f062b3117df2f54339a47469517c23b /server/sonar-web/src/main/js/components/issue | |
parent | 7fb43549fb85a0f79e61106ab770338d868b033d (diff) | |
download | sonarqube-2c91ba5af11b8e5955b65d4f0f76ea0e8917afbd.tar.gz sonarqube-2c91ba5af11b8e5955b65d4f0f76ea0e8917afbd.zip |
replace native buttons with Button component (#235)
Diffstat (limited to 'server/sonar-web/src/main/js/components/issue')
2 files changed, 5 insertions, 5 deletions
diff --git a/server/sonar-web/src/main/js/components/issue/components/IssueMessage.js b/server/sonar-web/src/main/js/components/issue/components/IssueMessage.js index 1f8a9cb2ae5..74bf39609ab 100644 --- a/server/sonar-web/src/main/js/components/issue/components/IssueMessage.js +++ b/server/sonar-web/src/main/js/components/issue/components/IssueMessage.js @@ -22,6 +22,7 @@ import React from 'react'; import PropTypes from 'prop-types'; import Tooltip from '../../controls/Tooltip'; import { translate, translateWithParameters } from '../../../helpers/l10n'; +import { Button } from '../../ui/buttons'; export default class IssueMessage extends React.PureComponent { /*:: props: { @@ -36,8 +37,7 @@ export default class IssueMessage extends React.PureComponent { workspace: PropTypes.object.isRequired }; - handleClick = (e /*: MouseEvent */) => { - e.preventDefault(); + handleClick = () => { this.context.workspace.openRule({ key: this.props.rule, organization: this.props.organization @@ -48,9 +48,9 @@ export default class IssueMessage extends React.PureComponent { return ( <div className="issue-message"> {this.props.message} - <button - className="button-link issue-rule icon-ellipsis-h little-spacer-left" + <Button aria-label={translate('issue.rule_details')} + className="button-link issue-rule icon-ellipsis-h little-spacer-left" onClick={this.handleClick} /> {this.props.engine && ( diff --git a/server/sonar-web/src/main/js/components/issue/components/__tests__/__snapshots__/IssueMessage-test.js.snap b/server/sonar-web/src/main/js/components/issue/components/__tests__/__snapshots__/IssueMessage-test.js.snap index 9bf92a16d15..91587572e88 100644 --- a/server/sonar-web/src/main/js/components/issue/components/__tests__/__snapshots__/IssueMessage-test.js.snap +++ b/server/sonar-web/src/main/js/components/issue/components/__tests__/__snapshots__/IssueMessage-test.js.snap @@ -5,7 +5,7 @@ exports[`should render with the message and a link to open the rule 1`] = ` className="issue-message" > Reduce the number of conditional operators (4) used in the expression - <button + <Button aria-label="issue.rule_details" className="button-link issue-rule icon-ellipsis-h little-spacer-left" onClick={[Function]} |