improve code quality

1 files changed, 89 insertions, 89 deletions

diff --git a/server/sonar-web/src/main/js/components/source-viewer/measures-overlay.js b/server/sonar-web/src/main/js/components/source-viewer/measures-overlay.js
index 254b4d36b81..5cb86419f15 100644
--- a/server/sonar-web/src/main/js/components/source-viewer/measures-overlay.js
+++ b/server/sonar-web/src/main/js/components/source-viewer/measures-overlay.js
@@ -27,9 +27,9 @@ export default ModalView.extend({
   template: Template,
   testsOrder: ['ERROR', 'FAILURE', 'OK', 'SKIPPED'],
 
-  initialize: function () {
-    var that = this,
-        requests = [this.requestMeasures(), this.requestIssues()];
+  initialize () {
+    const that = this;
+    const requests = [this.requestMeasures(), this.requestIssues()];
     if (this.model.get('isUnitTest')) {
       requests.push(this.requestTests());
     }
@@ -39,7 +39,7 @@ export default ModalView.extend({
     });
   },
 
-  events: function () {
+  events () {
     return _.extend(ModalView.prototype.events.apply(this, arguments), {
       'click .js-sort-tests-by-duration': 'sortTestsByDuration',
       'click .js-sort-tests-by-name': 'sortTestsByName',
@@ -49,12 +49,12 @@ export default ModalView.extend({
     });
   },
 
-  initPieChart: function () {
-    var trans = function (left, top) {
+  initPieChart () {
+    const trans = function (left, top) {
       return 'translate(' + left + ', ' + top + ')';
     };
 
-    var defaults = {
+    const defaults = {
       size: 40,
       thickness: 8,
       color: '#1f77b4',
@@ -62,32 +62,32 @@ export default ModalView.extend({
     };
 
     this.$('.js-pie-chart').each(function () {
-      var data = [
-            $(this).data('value'),
-            $(this).data('max') - $(this).data('value')
-          ],
-          options = _.defaults($(this).data(), defaults),
-          radius = options.size / 2;
+      const data = [
+        $(this).data('value'),
+        $(this).data('max') - $(this).data('value')
+      ];
+      const options = _.defaults($(this).data(), defaults);
+      const radius = options.size / 2;
 
-      var container = d3.select(this),
-          svg = container.append('svg')
-              .attr('width', options.size)
-              .attr('height', options.size),
-          plot = svg.append('g')
-              .attr('transform', trans(radius, radius)),
-          arc = d3.svg.arc()
-              .innerRadius(radius - options.thickness)
-              .outerRadius(radius),
-          pie = d3.layout.pie()
-              .sort(null)
-              .value(function (d) {
-                return d;
-              }),
-          colors = function (i) {
-            return i === 0 ? options.color : options.baseColor;
-          },
-          sectors = plot.selectAll('path')
-              .data(pie(data));
+      const container = d3.select(this);
+      const svg = container.append('svg')
+          .attr('width', options.size)
+          .attr('height', options.size);
+      const plot = svg.append('g')
+          .attr('transform', trans(radius, radius));
+      const arc = d3.svg.arc()
+          .innerRadius(radius - options.thickness)
+          .outerRadius(radius);
+      const pie = d3.layout.pie()
+          .sort(null)
+          .value(function (d) {
+            return d;
+          });
+      const colors = function (i) {
+        return i === 0 ? options.color : options.baseColor;
+      };
+      const sectors = plot.selectAll('path')
+          .data(pie(data));
 
       sectors.enter()
           .append('path')
@@ -98,17 +98,17 @@ export default ModalView.extend({
     });
   },
 
-  onRender: function () {
+  onRender () {
     ModalView.prototype.onRender.apply(this, arguments);
     this.initPieChart();
     this.$('.js-test-list').scrollTop(this.testsScroll);
   },
 
-  getMetrics: function () {
-    var metrics = '',
-        url = '/api/metrics/search';
+  getMetrics () {
+    let metrics = '';
+    const url = '/api/metrics/search';
     $.ajax({
-      url: url,
+      url,
       async: false,
       data: { ps: 9999 }
     }).done(function (data) {
@@ -121,7 +121,7 @@ export default ModalView.extend({
   },
 
 
-  calcAdditionalMeasures: function (measures) {
+  calcAdditionalMeasures (measures) {
     if (measures.lines_to_cover && measures.uncovered_lines) {
       measures.covered_lines = measures.lines_to_cover - measures.uncovered_lines;
     }
@@ -138,7 +138,7 @@ export default ModalView.extend({
   },
 
 
-  prepareMetrics: function (metrics) {
+  prepareMetrics (metrics) {
     metrics = _.filter(metrics, function (metric) {
       return metric.value != null;
     });
@@ -154,68 +154,68 @@ export default ModalView.extend({
   },
 
 
-  requestMeasures: function () {
-    var that = this,
-        url = '/api/resources',
-        metrics = this.getMetrics(),
-        options = {
-          resource: this.model.key(),
-          metrics: _.pluck(metrics, 'key').join()
-        };
+  requestMeasures () {
+    const that = this;
+    const url = '/api/resources';
+    const metrics = this.getMetrics();
+    const options = {
+      resource: this.model.key(),
+      metrics: _.pluck(metrics, 'key').join()
+    };
     return $.get(url, options).done(function (data) {
-      var measuresList = data[0].msr || [],
-          measures = that.model.get('measures') || {};
+      const measuresList = data[0].msr || [];
+      let measures = that.model.get('measures') || {};
       measuresList.forEach(function (m) {
-        var metric = _.findWhere(metrics, { key: m.key });
+        const metric = _.findWhere(metrics, { key: m.key });
         metric.value = m.frmt_val || m.data;
         measures[m.key] = m.frmt_val || m.data;
         measures[m.key + '_raw'] = m.val;
       });
       measures = that.calcAdditionalMeasures(measures);
       that.model.set({
-        measures: measures,
+        measures,
         measuresToDisplay: that.prepareMetrics(metrics)
       });
     });
   },
 
-  requestIssues: function () {
-    var that = this,
-        url = '/api/issues/search',
-        options = {
-          componentUuids: this.model.id,
-          resolved: false,
-          ps: 1,
-          facets: 'severities,tags'
-        };
+  requestIssues () {
+    const that = this;
+    const url = '/api/issues/search';
+    const options = {
+      componentUuids: this.model.id,
+      resolved: false,
+      ps: 1,
+      facets: 'severities,tags'
+    };
     return $.get(url, options).done(function (data) {
-      var issuesFacets = {};
+      const issuesFacets = {};
       data.facets.forEach(function (facet) {
         issuesFacets[facet.property] = facet.values;
       });
-      var severityOrder = ['BLOCKER', 'CRITICAL', 'MAJOR', 'MINOR', 'INFO'],
-          maxCountBySeverity = _.max(issuesFacets.severities, function (s) {
-            return s.count;
-          }).count,
-          maxCountByTag = _.max(issuesFacets.tags, function (s) {
-            return s.count;
-          }).count;
+      const severityOrder = ['BLOCKER', 'CRITICAL', 'MAJOR', 'MINOR', 'INFO'];
+      const maxCountBySeverity = _.max(issuesFacets.severities, function (s) {
+        return s.count;
+      }).count;
+      const maxCountByTag = _.max(issuesFacets.tags, function (s) {
+        return s.count;
+      }).count;
       issuesFacets.severities = _.sortBy(issuesFacets.severities, function (s) {
         return severityOrder.indexOf(s.val);
       });
       that.model.set({
-        issuesFacets: issuesFacets,
+        issuesFacets,
         issuesCount: data.total,
-        maxCountBySeverity: maxCountBySeverity,
-        maxCountByTag: maxCountByTag
+        maxCountBySeverity,
+        maxCountByTag
       });
     });
   },
 
-  requestTests: function () {
-    var that = this,
-        url = '/api/tests/list',
-        options = { testFileId: this.model.id };
+  requestTests () {
+    const that = this;
+    const url = '/api/tests/list';
+    const options = { testFileId: this.model.id };
     return $.get(url, options).done(function (data) {
       that.model.set({ tests: data.tests });
       that.testSorting = 'status';
@@ -226,18 +226,18 @@ export default ModalView.extend({
     });
   },
 
-  sortTests: function (condition) {
-    var tests = this.model.get('tests');
+  sortTests (condition) {
+    let tests = this.model.get('tests');
     if (_.isArray(tests)) {
       tests = _.sortBy(tests, condition);
       if (!this.testAsc) {
         tests.reverse();
       }
-      this.model.set({ tests: tests });
+      this.model.set({ tests });
     }
   },
 
-  sortTestsByDuration: function () {
+  sortTestsByDuration () {
     if (this.testSorting === 'duration') {
       this.testAsc = !this.testAsc;
     }
@@ -246,7 +246,7 @@ export default ModalView.extend({
     this.render();
   },
 
-  sortTestsByName: function () {
+  sortTestsByName () {
     if (this.testSorting === 'name') {
       this.testAsc = !this.testAsc;
     }
@@ -255,8 +255,8 @@ export default ModalView.extend({
     this.render();
   },
 
-  sortTestsByStatus: function () {
-    var that = this;
+  sortTestsByStatus () {
+    const that = this;
     if (this.testSorting === 'status') {
       this.testAsc = !this.testAsc;
     }
@@ -267,11 +267,11 @@ export default ModalView.extend({
     this.render();
   },
 
-  showTest: function (e) {
-    var that = this,
-        testId = $(e.currentTarget).data('id'),
-        url = '/api/tests/covered_files',
-        options = { testId: testId };
+  showTest (e) {
+    const that = this;
+    const testId = $(e.currentTarget).data('id');
+    const url = '/api/tests/covered_files';
+    const options = { testId };
     this.testsScroll = $(e.currentTarget).scrollParent().scrollTop();
     return $.get(url, options).done(function (data) {
       that.coveredFiles = data.files;
@@ -280,12 +280,12 @@ export default ModalView.extend({
     });
   },
 
-  showAllMeasures: function () {
+  showAllMeasures () {
     this.$('.js-all-measures').removeClass('hidden');
     this.$('.js-show-all-measures').remove();
   },
 
-  serializeData: function () {
+  serializeData () {
     return _.extend(ModalView.prototype.serializeData.apply(this, arguments), {
       testSorting: this.testSorting,
       selectedTest: this.selectedTest,