rewrite remaining popups in react (#3109)

* extract baseFontFamily

* rewrite favorites store in ts

* add new types and change existing ones

* rewrite SourceViewer helpers in ts

* rewrite SourceViewer in ts and its popups in react

* drop popups

* fix iterating over nodelist

* fix quality flaws

1 files changed, 30 insertions, 57 deletions

diff --git a/server/sonar-web/src/main/js/store/favorites/duck.js b/server/sonar-web/src/main/js/store/favorites/duck.ts
index 3015e256953..710151e4eb2 100644
--- a/server/sonar-web/src/main/js/store/favorites/duck.js
+++ b/server/sonar-web/src/main/js/store/favorites/duck.ts
@@ -17,92 +17,65 @@
  * along with this program; if not, write to the Free Software Foundation,
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
-// @flow
 import { uniq, without } from 'lodash';
 
-/*::
-type Favorite = { key: string };
-*/
+interface Favorite {
+  key: string;
+}
 
-/*::
-type ReceiveFavoritesAction = {
-  type: 'RECEIVE_FAVORITES',
-  favorites: Array<Favorite>,
-  notFavorites: Array<Favorite>
-};
-*/
+interface ReceiveFavoritesAction {
+  type: 'RECEIVE_FAVORITES';
+  favorites: Array<Favorite>;
+  notFavorites: Array<Favorite>;
+}
 
-/*::
-type AddFavoriteAction = {
-  type: 'ADD_FAVORITE',
-  componentKey: string
-};
-*/
+interface AddFavoriteAction {
+  type: 'ADD_FAVORITE';
+  componentKey: string;
+}
 
-/*::
-type RemoveFavoriteAction = {
-  type: 'REMOVE_FAVORITE',
-  componentKey: string
-};
-*/
+interface RemoveFavoriteAction {
+  type: 'REMOVE_FAVORITE';
+  componentKey: string;
+}
 
-/*::
 type Action = ReceiveFavoritesAction | AddFavoriteAction | RemoveFavoriteAction;
-*/
-
-/*::
-type State = Array<string>;
-*/
 
-export const actions = {
-  RECEIVE_FAVORITES: 'RECEIVE_FAVORITES',
-  ADD_FAVORITE: 'ADD_FAVORITE',
-  REMOVE_FAVORITE: 'REMOVE_FAVORITE'
-};
+type State = string[];
 
 export function receiveFavorites(
-  favorites /*: Array<Favorite> */,
-  notFavorites /*: Array<Favorite> */ = []
-) /*: ReceiveFavoritesAction */ {
-  return {
-    type: actions.RECEIVE_FAVORITES,
-    favorites,
-    notFavorites
-  };
+  favorites: Favorite[],
+  notFavorites: Favorite[] = []
+): ReceiveFavoritesAction {
+  return { type: 'RECEIVE_FAVORITES', favorites, notFavorites };
 }
 
-export function addFavorite(componentKey /*: string */) /*: AddFavoriteAction */ {
-  return {
-    type: actions.ADD_FAVORITE,
-    componentKey
-  };
+export function addFavorite(componentKey: string): AddFavoriteAction {
+  return { type: 'ADD_FAVORITE', componentKey };
 }
 
-export function removeFavorite(componentKey /*: string */) /*: RemoveFavoriteAction */ {
-  return {
-    type: actions.REMOVE_FAVORITE,
-    componentKey
-  };
+export function removeFavorite(componentKey: string): RemoveFavoriteAction {
+  return { type: 'REMOVE_FAVORITE', componentKey };
 }
 
-export default function(state /*: State */ = [], action /*: Action */) /*: State */ {
-  if (action.type === actions.RECEIVE_FAVORITES) {
+export default function(state: State = [], action: Action): State {
+  if (action.type === 'RECEIVE_FAVORITES') {
     const toAdd = action.favorites.map(f => f.key);
     const toRemove = action.notFavorites.map(f => f.key);
     return without(uniq([...state, ...toAdd]), ...toRemove);
   }
 
-  if (action.type === actions.ADD_FAVORITE) {
+  if (action.type === 'ADD_FAVORITE') {
     return uniq([...state, action.componentKey]);
   }
 
-  if (action.type === actions.REMOVE_FAVORITE) {
+  if (action.type === 'REMOVE_FAVORITE') {
     return without(state, action.componentKey);
   }
 
   return state;
 }
 
-export function isFavorite(state /*: State */, componentKey /*: string */) {
+export function isFavorite(state: State, componentKey: string) {
   return state.includes(componentKey);
 }