diff options
| author | Wouter Admiraal <wouter.admiraal@sonarsource.com> | 2021-06-15 11:33:26 +0200 |
|---|---|---|
| committer | sonartech <sonartech@sonarsource.com> | 2021-06-17 20:03:07 +0000 |
| commit | 681f2203cd403508e1feba97749bb98d3422852a (patch) | |
| tree | 2fefe2e6549e9b852a9091f4dee37bd4d21e0ace /server/sonar-web | |
| parent | dee4f363b8bdebe59126a5464e1ebc4fc3202932 (diff) | |
| download | sonarqube-681f2203cd403508e1feba97749bb98d3422852a.tar.gz sonarqube-681f2203cd403508e1feba97749bb98d3422852a.zip | |
SONAR-14933 Fix missing SVG path
Diffstat (limited to 'server/sonar-web')
2 files changed, 13 insertions, 22 deletions
diff --git a/server/sonar-web/src/main/js/apps/create/project/CreateProjectModeSelection.tsx b/server/sonar-web/src/main/js/apps/create/project/CreateProjectModeSelection.tsx index e14ba173049..717e6f7f783 100644 --- a/server/sonar-web/src/main/js/apps/create/project/CreateProjectModeSelection.tsx +++ b/server/sonar-web/src/main/js/apps/create/project/CreateProjectModeSelection.tsx @@ -19,6 +19,7 @@ */ import * as classNames from 'classnames'; import * as React from 'react'; +import ChevronsIcon from 'sonar-ui-common/components/icons/ChevronsIcon'; import { translate, translateWithParameters } from 'sonar-ui-common/helpers/l10n'; import { getBaseUrl } from 'sonar-ui-common/helpers/urls'; import DocumentationTooltip from '../../../components/common/DocumentationTooltip'; @@ -40,6 +41,8 @@ export interface CreateProjectModeSelectionProps { onSelectMode: (mode: CreateProjectModes) => void; } +const DEFAULT_ICON_SIZE = 80; + function renderAlmOption( props: CreateProjectModeSelectionProps, alm: AlmKeys.Azure | AlmKeys.BitbucketServer | AlmKeys.GitHub | AlmKeys.GitLab, @@ -87,7 +90,7 @@ function renderAlmOption( type="button"> <img alt="" // Should be ignored by screen readers - height={80} + height={DEFAULT_ICON_SIZE} src={`${getBaseUrl()}/images/alm/${alm}.svg`} /> <div className="medium big-spacer-top abs-height-50 display-flex-center"> @@ -139,11 +142,7 @@ export function CreateProjectModeSelection(props: CreateProjectModeSelectionProp className="button button-huge display-flex-column create-project-mode-type-manual" onClick={() => props.onSelectMode(CreateProjectModes.Manual)} type="button"> - <img - alt="" // Should be ignored by screen readers - height={80} - src={`${getBaseUrl()}/images/sonarcloud/analysis/manual.svg`} - /> + <ChevronsIcon size={DEFAULT_ICON_SIZE} /> <div className="medium big-spacer-top"> {translate('onboarding.create_project.select_method.manual')} </div> diff --git a/server/sonar-web/src/main/js/apps/create/project/__tests__/__snapshots__/CreateProjectModeSelection-test.tsx.snap b/server/sonar-web/src/main/js/apps/create/project/__tests__/__snapshots__/CreateProjectModeSelection-test.tsx.snap index 4b84b1a5b58..7ecb4dff98e 100644 --- a/server/sonar-web/src/main/js/apps/create/project/__tests__/__snapshots__/CreateProjectModeSelection-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/create/project/__tests__/__snapshots__/CreateProjectModeSelection-test.tsx.snap @@ -24,10 +24,8 @@ exports[`should render correctly: default 1`] = ` onClick={[Function]} type="button" > - <img - alt="" - height={80} - src="/images/sonarcloud/analysis/manual.svg" + <ChevronsIcon + size={80} /> <div className="medium big-spacer-top" @@ -213,10 +211,8 @@ exports[`should render correctly: invalid configs, admin 1`] = ` onClick={[Function]} type="button" > - <img - alt="" - height={80} - src="/images/sonarcloud/analysis/manual.svg" + <ChevronsIcon + size={80} /> <div className="medium big-spacer-top" @@ -429,10 +425,8 @@ exports[`should render correctly: invalid configs, not admin 1`] = ` onClick={[Function]} type="button" > - <img - alt="" - height={80} - src="/images/sonarcloud/analysis/manual.svg" + <ChevronsIcon + size={80} /> <div className="medium big-spacer-top" @@ -633,10 +627,8 @@ exports[`should render correctly: loading instances 1`] = ` onClick={[Function]} type="button" > - <img - alt="" - height={80} - src="/images/sonarcloud/analysis/manual.svg" + <ChevronsIcon + size={80} /> <div className="medium big-spacer-top" |