diff options
author | Belen Pruvost <belen.pruvost@sonarsource.com> | 2021-07-14 17:15:32 +0200 |
---|---|---|
committer | sonartech <sonartech@sonarsource.com> | 2021-07-27 20:03:02 +0000 |
commit | 09d8569209aade0e3b4cbd21c6dee9da025b245b (patch) | |
tree | 938e184ebc8296a3ae821d7225ba3fff82375e75 /server/sonar-webserver-auth | |
parent | 1627d31954c6fcbcbad8bd4045285df8e97cc96b (diff) | |
download | sonarqube-09d8569209aade0e3b4cbd21c6dee9da025b245b.tar.gz sonarqube-09d8569209aade0e3b4cbd21c6dee9da025b245b.zip |
SONAR-15142 Persisting audits for User operations
Diffstat (limited to 'server/sonar-webserver-auth')
5 files changed, 10 insertions, 8 deletions
diff --git a/server/sonar-webserver-auth/src/main/java/org/sonar/server/authentication/UserLastConnectionDatesUpdaterImpl.java b/server/sonar-webserver-auth/src/main/java/org/sonar/server/authentication/UserLastConnectionDatesUpdaterImpl.java index 85e85c12392..20b0e23ead8 100644 --- a/server/sonar-webserver-auth/src/main/java/org/sonar/server/authentication/UserLastConnectionDatesUpdaterImpl.java +++ b/server/sonar-webserver-auth/src/main/java/org/sonar/server/authentication/UserLastConnectionDatesUpdaterImpl.java @@ -46,7 +46,7 @@ public class UserLastConnectionDatesUpdaterImpl implements UserLastConnectionDat return; } try (DbSession dbSession = dbClient.openSession(false)) { - dbClient.userDao().update(dbSession, user.setLastConnectionDate(now)); + dbClient.userDao().update(dbSession, user.setLastConnectionDate(now), false); dbSession.commit(); } } @@ -59,7 +59,7 @@ public class UserLastConnectionDatesUpdaterImpl implements UserLastConnectionDat return; } try (DbSession dbSession = dbClient.openSession(false)) { - dbClient.userTokenDao().update(dbSession, userToken.setLastConnectionDate(now)); + dbClient.userTokenDao().update(dbSession, userToken.setLastConnectionDate(now), false, null); userToken.setLastConnectionDate(now); dbSession.commit(); } diff --git a/server/sonar-webserver-auth/src/main/java/org/sonar/server/authentication/UserRegistrarImpl.java b/server/sonar-webserver-auth/src/main/java/org/sonar/server/authentication/UserRegistrarImpl.java index 21fe881a4a6..dc003eede15 100644 --- a/server/sonar-webserver-auth/src/main/java/org/sonar/server/authentication/UserRegistrarImpl.java +++ b/server/sonar-webserver-auth/src/main/java/org/sonar/server/authentication/UserRegistrarImpl.java @@ -216,7 +216,8 @@ public class UserRegistrarImpl implements UserRegistrar { groupsToAdd.stream().map(groupsByName::get).filter(Objects::nonNull).forEach( groupDto -> { LOGGER.debug("Adding group '{}' to user '{}'", groupDto.getName(), userDto.getLogin()); - dbClient.userGroupDao().insert(dbSession, new UserGroupDto().setGroupUuid(groupDto.getUuid()).setUserUuid(userDto.getUuid())); + dbClient.userGroupDao().insert(dbSession, new UserGroupDto().setGroupUuid(groupDto.getUuid()).setUserUuid(userDto.getUuid()), + groupDto.getName(), userDto.getLogin()); }); } @@ -229,7 +230,7 @@ public class UserRegistrarImpl implements UserRegistrar { .filter(group -> !defaultGroup.isPresent() || !group.getUuid().equals(defaultGroup.get().getUuid())) .forEach(groupDto -> { LOGGER.debug("Removing group '{}' from user '{}'", groupDto.getName(), userDto.getLogin()); - dbClient.userGroupDao().delete(dbSession, groupDto.getUuid(), userDto.getUuid()); + dbClient.userGroupDao().delete(dbSession, groupDto, userDto); }); } diff --git a/server/sonar-webserver-auth/src/main/java/org/sonar/server/user/UserUpdater.java b/server/sonar-webserver-auth/src/main/java/org/sonar/server/user/UserUpdater.java index 3cd64eefd2f..97230b61f9b 100644 --- a/server/sonar-webserver-auth/src/main/java/org/sonar/server/user/UserUpdater.java +++ b/server/sonar-webserver-auth/src/main/java/org/sonar/server/user/UserUpdater.java @@ -442,6 +442,7 @@ public class UserUpdater { if (isUserAlreadyMemberOfDefaultGroup(defaultGroup, userGroups)) { return; } - dbClient.userGroupDao().insert(dbSession, new UserGroupDto().setUserUuid(userDto.getUuid()).setGroupUuid(defaultGroup.getUuid())); + dbClient.userGroupDao().insert(dbSession, new UserGroupDto().setUserUuid(userDto.getUuid()).setGroupUuid(defaultGroup.getUuid()), + defaultGroup.getName(), userDto.getLogin()); } } diff --git a/server/sonar-webserver-auth/src/test/java/org/sonar/server/authentication/UserLastConnectionDatesUpdaterImplTest.java b/server/sonar-webserver-auth/src/test/java/org/sonar/server/authentication/UserLastConnectionDatesUpdaterImplTest.java index 329082f97aa..e6bb550e9ae 100644 --- a/server/sonar-webserver-auth/src/test/java/org/sonar/server/authentication/UserLastConnectionDatesUpdaterImplTest.java +++ b/server/sonar-webserver-auth/src/test/java/org/sonar/server/authentication/UserLastConnectionDatesUpdaterImplTest.java @@ -79,7 +79,7 @@ public class UserLastConnectionDatesUpdaterImplTest { public void update_last_connection_date_from_user_token_when_last_connection_was_more_than_one_hour() { UserDto user = db.users().insertUser(); UserTokenDto userToken = db.users().insertToken(user); - db.getDbClient().userTokenDao().update(db.getSession(), userToken.setLastConnectionDate(NOW - TWO_HOUR)); + db.getDbClient().userTokenDao().update(db.getSession(), userToken.setLastConnectionDate(NOW - TWO_HOUR), false, null); db.commit(); underTest.updateLastConnectionDateIfNeeded(userToken); @@ -103,7 +103,7 @@ public class UserLastConnectionDatesUpdaterImplTest { public void do_not_update_when_last_connection_from_user_token_was_less_than_one_hour() { UserDto user = db.users().insertUser(); UserTokenDto userToken = db.users().insertToken(user); - db.getDbClient().userTokenDao().update(db.getSession(), userToken.setLastConnectionDate(NOW - ONE_MINUTE)); + db.getDbClient().userTokenDao().update(db.getSession(), userToken.setLastConnectionDate(NOW - ONE_MINUTE), false, null); db.commit(); underTest.updateLastConnectionDateIfNeeded(userToken); diff --git a/server/sonar-webserver-auth/src/test/java/org/sonar/server/usergroups/DefaultGroupFinderTest.java b/server/sonar-webserver-auth/src/test/java/org/sonar/server/usergroups/DefaultGroupFinderTest.java index 926a117ef73..9c9ca2e3a3b 100644 --- a/server/sonar-webserver-auth/src/test/java/org/sonar/server/usergroups/DefaultGroupFinderTest.java +++ b/server/sonar-webserver-auth/src/test/java/org/sonar/server/usergroups/DefaultGroupFinderTest.java @@ -58,7 +58,7 @@ public class DefaultGroupFinderTest { @Test public void fail_with_ISE_when_default_group_does_not_exist() { GroupDto defaultGroup = db.users().insertDefaultGroup(); - db.getDbClient().groupDao().deleteByUuid(db.getSession(), defaultGroup.getUuid()); + db.getDbClient().groupDao().deleteByUuid(db.getSession(), defaultGroup.getUuid(), defaultGroup.getName()); DbSession session = db.getSession(); assertThatThrownBy(() -> underTest.findDefaultGroup(session)) |