diff options
author | Jacek <jacek.poreda@sonarsource.com> | 2020-04-20 14:47:21 +0200 |
---|---|---|
committer | sonartech <sonartech@sonarsource.com> | 2020-05-25 20:05:20 +0000 |
commit | 6c334f9290e0a5f42b4b128919d4c25b5d20ce58 (patch) | |
tree | e7741cfafdbce350005b92bd2f98bf7ba53184cc /server/sonar-webserver-auth | |
parent | 6b41a01454b98c413889dc2400a9cddb3b390847 (diff) | |
download | sonarqube-6c334f9290e0a5f42b4b128919d4c25b5d20ce58.tar.gz sonarqube-6c334f9290e0a5f42b4b128919d4c25b5d20ce58.zip |
SONAR-13221 change PK to uuid of PERMISSION_TEMPLATES table
* change template_id to template_uuid for PERM_TEMPLATES_GROUPS, PERM_TEMPLATES_USERS, PERM_TPL_CHARACTERISTICS
Diffstat (limited to 'server/sonar-webserver-auth')
4 files changed, 9 insertions, 9 deletions
diff --git a/server/sonar-webserver-auth/src/main/java/org/sonar/server/organization/OrganisationSupport.java b/server/sonar-webserver-auth/src/main/java/org/sonar/server/organization/OrganisationSupport.java index d225562275a..720a2ba1be0 100644 --- a/server/sonar-webserver-auth/src/main/java/org/sonar/server/organization/OrganisationSupport.java +++ b/server/sonar-webserver-auth/src/main/java/org/sonar/server/organization/OrganisationSupport.java @@ -106,7 +106,7 @@ public class OrganisationSupport { List<PermissionTemplateGroupDto> sonarUsersPermissionTemplates = dbClient.permissionTemplateDao().selectAllGroupPermissionTemplatesByGroupId(dbSession, sonarUsersGroup.getId()); sonarUsersPermissionTemplates.forEach(permissionTemplateGroup -> dbClient.permissionTemplateDao().insertGroupPermission(dbSession, - permissionTemplateGroup.getTemplateId(), membersGroup.getId(), permissionTemplateGroup.getPermission())); + permissionTemplateGroup.getTemplateUuid(), membersGroup.getId(), permissionTemplateGroup.getPermission())); } private List<Integer> disableTemplateRulesAndCustomRules(DbSession dbSession) { diff --git a/server/sonar-webserver-auth/src/main/java/org/sonar/server/organization/OrganizationUpdaterImpl.java b/server/sonar-webserver-auth/src/main/java/org/sonar/server/organization/OrganizationUpdaterImpl.java index e591419feda..7f6e27efb88 100644 --- a/server/sonar-webserver-auth/src/main/java/org/sonar/server/organization/OrganizationUpdaterImpl.java +++ b/server/sonar-webserver-auth/src/main/java/org/sonar/server/organization/OrganizationUpdaterImpl.java @@ -183,7 +183,7 @@ public class OrganizationUpdaterImpl implements OrganizationUpdater { } private void insertGroupPermission(DbSession dbSession, PermissionTemplateDto template, String permission, @Nullable GroupDto group) { - dbClient.permissionTemplateDao().insertGroupPermission(dbSession, template.getId(), group == null ? null : group.getId(), permission); + dbClient.permissionTemplateDao().insertGroupPermission(dbSession, template.getUuid(), group == null ? null : group.getId(), permission); } private void insertQualityProfiles(DbSession dbSession, DbSession batchDbSession, OrganizationDto organization) { diff --git a/server/sonar-webserver-auth/src/test/java/org/sonar/server/organization/MemberUpdaterTest.java b/server/sonar-webserver-auth/src/test/java/org/sonar/server/organization/MemberUpdaterTest.java index 5ff30743de3..885d96c0016 100644 --- a/server/sonar-webserver-auth/src/test/java/org/sonar/server/organization/MemberUpdaterTest.java +++ b/server/sonar-webserver-auth/src/test/java/org/sonar/server/organization/MemberUpdaterTest.java @@ -248,15 +248,15 @@ public class MemberUpdaterTest { PermissionTemplateDto template = db.permissionTemplates().insertTemplate(organization); PermissionTemplateDto anotherTemplate = db.permissionTemplates().insertTemplate(anotherOrganization); String permission = "browse"; - db.permissionTemplates().addUserToTemplate(template.getId(), user.getId(), permission); - db.permissionTemplates().addUserToTemplate(template.getId(), anotherUser.getId(), permission); - db.permissionTemplates().addUserToTemplate(anotherTemplate.getId(), user.getId(), permission); + db.permissionTemplates().addUserToTemplate(template.getUuid(), user.getId(), permission); + db.permissionTemplates().addUserToTemplate(template.getUuid(), anotherUser.getId(), permission); + db.permissionTemplates().addUserToTemplate(anotherTemplate.getUuid(), user.getId(), permission); underTest.removeMember(db.getSession(), organization, user); - assertThat(dbClient.permissionTemplateDao().selectUserPermissionsByTemplateId(db.getSession(), template.getId())).extracting(PermissionTemplateUserDto::getUserId) + assertThat(dbClient.permissionTemplateDao().selectUserPermissionsByTemplateId(db.getSession(), template.getUuid())).extracting(PermissionTemplateUserDto::getUserId) .containsOnly(anotherUser.getId()); - assertThat(dbClient.permissionTemplateDao().selectUserPermissionsByTemplateId(db.getSession(), anotherTemplate.getId())).extracting(PermissionTemplateUserDto::getUserId) + assertThat(dbClient.permissionTemplateDao().selectUserPermissionsByTemplateId(db.getSession(), anotherTemplate.getUuid())).extracting(PermissionTemplateUserDto::getUserId) .containsOnly(user.getId()); } diff --git a/server/sonar-webserver-auth/src/test/java/org/sonar/server/organization/OrganizationUpdaterImplTest.java b/server/sonar-webserver-auth/src/test/java/org/sonar/server/organization/OrganizationUpdaterImplTest.java index b7f5fc4c368..2395ce8b267 100644 --- a/server/sonar-webserver-auth/src/test/java/org/sonar/server/organization/OrganizationUpdaterImplTest.java +++ b/server/sonar-webserver-auth/src/test/java/org/sonar/server/organization/OrganizationUpdaterImplTest.java @@ -26,10 +26,10 @@ import org.apache.commons.lang.RandomStringUtils; import org.junit.Rule; import org.junit.Test; import org.junit.rules.ExpectedException; +import org.sonar.api.impl.utils.TestSystem2; import org.sonar.api.resources.Qualifiers; import org.sonar.api.resources.ResourceTypes; import org.sonar.api.utils.System2; -import org.sonar.api.impl.utils.TestSystem2; import org.sonar.api.web.UserRole; import org.sonar.core.permission.GlobalPermissions; import org.sonar.core.util.SequenceUuidFactory; @@ -190,7 +190,7 @@ public class OrganizationUpdaterImplTest { DefaultTemplates defaultTemplates = dbClient.organizationDao().getDefaultTemplates(dbSession, organization.getUuid()).get(); assertThat(defaultTemplates.getProjectUuid()).isEqualTo(defaultTemplate.getUuid()); assertThat(defaultTemplates.getApplicationsUuid()).isNull(); - assertThat(dbClient.permissionTemplateDao().selectGroupPermissionsByTemplateId(dbSession, defaultTemplate.getId())) + assertThat(dbClient.permissionTemplateDao().selectGroupPermissionsByTemplateUuid(dbSession, defaultTemplate.getUuid())) .extracting(PermissionTemplateGroupDto::getGroupId, PermissionTemplateGroupDto::getPermission) .containsOnly( tuple(ownersGroup.getId(), UserRole.ADMIN), |