diff options
author | Matteo Mara <matteo.mara@sonarsource.com> | 2023-01-27 16:16:07 +0100 |
---|---|---|
committer | sonartech <sonartech@sonarsource.com> | 2023-02-03 14:41:21 +0000 |
commit | ca5790f9c26dcd9fdb291a91193dcf3ffe7bf7de (patch) | |
tree | fd13a52ea8fea3ec35b777c0f83e9e4f8a9f909b /server/sonar-webserver-core | |
parent | f507535da5cc4f1f2d25d6cd3c7c742cda1e8465 (diff) | |
download | sonarqube-ca5790f9c26dcd9fdb291a91193dcf3ffe7bf7de.tar.gz sonarqube-ca5790f9c26dcd9fdb291a91193dcf3ffe7bf7de.zip |
SONAR-17815 implement updated logic for CaYC quality gates
Diffstat (limited to 'server/sonar-webserver-core')
2 files changed, 8 insertions, 5 deletions
diff --git a/server/sonar-webserver-core/src/main/java/org/sonar/server/telemetry/TelemetryDataLoaderImpl.java b/server/sonar-webserver-core/src/main/java/org/sonar/server/telemetry/TelemetryDataLoaderImpl.java index b82f39156b3..a24ec92656f 100644 --- a/server/sonar-webserver-core/src/main/java/org/sonar/server/telemetry/TelemetryDataLoaderImpl.java +++ b/server/sonar-webserver-core/src/main/java/org/sonar/server/telemetry/TelemetryDataLoaderImpl.java @@ -241,7 +241,7 @@ public class TelemetryDataLoaderImpl implements TelemetryDataLoader { for (QualityGateDto qualityGateDto : qualityGateDtos) { qualityGates.add( new TelemetryData.QualityGate(qualityGateDto.getUuid(), qualityGateCaycChecker.checkCaycCompliant(dbSession, - qualityGateDto.getUuid())) + qualityGateDto.getUuid()).toString()) ); } diff --git a/server/sonar-webserver-core/src/test/java/org/sonar/server/telemetry/TelemetryDataLoaderImplTest.java b/server/sonar-webserver-core/src/test/java/org/sonar/server/telemetry/TelemetryDataLoaderImplTest.java index ffcbc9f0411..e996981a909 100644 --- a/server/sonar-webserver-core/src/test/java/org/sonar/server/telemetry/TelemetryDataLoaderImplTest.java +++ b/server/sonar-webserver-core/src/test/java/org/sonar/server/telemetry/TelemetryDataLoaderImplTest.java @@ -63,6 +63,7 @@ import static org.apache.commons.lang.RandomStringUtils.randomAlphanumeric; import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.entry; import static org.assertj.core.groups.Tuple.tuple; +import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.spy; import static org.mockito.Mockito.when; @@ -83,6 +84,7 @@ import static org.sonar.core.platform.EditionProvider.Edition.ENTERPRISE; import static org.sonar.db.component.BranchType.BRANCH; import static org.sonar.server.metric.UnanalyzedLanguageMetrics.UNANALYZED_CPP_KEY; import static org.sonar.server.metric.UnanalyzedLanguageMetrics.UNANALYZED_C_KEY; +import static org.sonar.server.qualitygate.QualityGateCaycStatus.NON_COMPLIANT; import static org.sonar.server.telemetry.TelemetryDataLoaderImpl.SCIM_PROPERTY_ENABLED; @RunWith(DataProviderRunner.class) @@ -118,6 +120,7 @@ public class TelemetryDataLoaderImplTest { public void setUpBuiltInQualityGate() { String builtInQgName = "Sonar Way"; builtInDefaultQualityGate = db.qualityGates().insertQualityGate(qg -> qg.setName(builtInQgName).setBuiltIn(true)); + when(qualityGateCaycChecker.checkCaycCompliant(any(), any())).thenReturn(NON_COMPLIANT); db.qualityGates().setDefaultQualityGate(builtInDefaultQualityGate); bugsDto = db.measures().insertMetric(m -> m.setKey(BUGS_KEY)); @@ -229,11 +232,11 @@ public class TelemetryDataLoaderImplTest { tuple(1L, 0L, qualityGate1.getUuid(), "scm-1", "ci-1", "azure_devops_cloud", Optional.of(1L), Optional.of(1L), Optional.of(1L), Optional.of(50L), Optional.of(5L)), tuple(1L, 0L, builtInDefaultQualityGate.getUuid(), "scm-2", "ci-2", "github_cloud", Optional.empty(), Optional.empty(), Optional.empty(), Optional.empty(), Optional.empty())); assertThat(data.getQualityGates()) - .extracting(TelemetryData.QualityGate::uuid, TelemetryData.QualityGate::isCaycCompliant) + .extracting(TelemetryData.QualityGate::uuid, TelemetryData.QualityGate::caycStatus) .containsExactlyInAnyOrder( - tuple(builtInDefaultQualityGate.getUuid(), false), - tuple(qualityGate1.getUuid(), false), - tuple(qualityGate2.getUuid(), false) + tuple(builtInDefaultQualityGate.getUuid(), "non-compliant"), + tuple(qualityGate1.getUuid(), "non-compliant"), + tuple(qualityGate2.getUuid(), "non-compliant") ); } |