diff options
| author | Jacek <jacek.poreda@sonarsource.com> | 2020-12-04 11:34:36 +0100 |
|---|---|---|
| committer | sonartech <sonartech@sonarsource.com> | 2020-12-09 20:07:21 +0000 |
| commit | 720c19e83f2299a848c18c6921a3c22281b87eb6 (patch) | |
| tree | fdbdc8b99a62296fbb7eec5812ed336e70ea9e3d /server/sonar-webserver-es | |
| parent | 5380a8080eb0d52981739fc3fe5459c66b204f11 (diff) | |
| download | sonarqube-720c19e83f2299a848c18c6921a3c22281b87eb6.tar.gz sonarqube-720c19e83f2299a848c18c6921a3c22281b87eb6.zip | |
Code smells test fixes
Diffstat (limited to 'server/sonar-webserver-es')
2 files changed, 8 insertions, 8 deletions
diff --git a/server/sonar-webserver-es/src/test/java/org/sonar/server/issue/index/IssueIndexSyncProgressCheckerTest.java b/server/sonar-webserver-es/src/test/java/org/sonar/server/issue/index/IssueIndexSyncProgressCheckerTest.java index 06f073d3564..f3cbe525ab4 100644 --- a/server/sonar-webserver-es/src/test/java/org/sonar/server/issue/index/IssueIndexSyncProgressCheckerTest.java +++ b/server/sonar-webserver-es/src/test/java/org/sonar/server/issue/index/IssueIndexSyncProgressCheckerTest.java @@ -48,12 +48,12 @@ import static org.sonar.db.ce.CeActivityDto.Status.SUCCESS; @RunWith(DataProviderRunner.class) public class IssueIndexSyncProgressCheckerTest { - private System2 system2 = new System2(); + private final System2 system2 = new System2(); @Rule public DbTester db = DbTester.create(System2.INSTANCE); - private IssueIndexSyncProgressChecker underTest = new IssueIndexSyncProgressChecker(db.getDbClient()); + private final IssueIndexSyncProgressChecker underTest = new IssueIndexSyncProgressChecker(db.getDbClient()); @Test public void return_100_if_there_is_no_tasks_left() { @@ -246,11 +246,11 @@ public class IssueIndexSyncProgressCheckerTest { underTest.checkIfComponentNeedIssueSync(session, projectDto2.getKey()); // throws if flag set to TRUE - assertThatThrownBy(() -> underTest.checkIfComponentNeedIssueSync(session, - projectDto1.getKey())) - .isInstanceOf(EsIndexSyncInProgressException.class) - .hasFieldOrPropertyWithValue("httpCode", 503) - .hasMessage("Results are temporarily unavailable. Indexing of issues is in progress."); + String key = projectDto1.getKey(); + assertThatThrownBy(() -> underTest.checkIfComponentNeedIssueSync(session, key)) + .isInstanceOf(EsIndexSyncInProgressException.class) + .hasFieldOrPropertyWithValue("httpCode", 503) + .hasMessage("Results are temporarily unavailable. Indexing of issues is in progress."); } @Test diff --git a/server/sonar-webserver-es/src/test/java/org/sonar/server/measure/index/ProjectMeasuresIndexTest.java b/server/sonar-webserver-es/src/test/java/org/sonar/server/measure/index/ProjectMeasuresIndexTest.java index 4e6ae085da2..7a4315ac9c9 100644 --- a/server/sonar-webserver-es/src/test/java/org/sonar/server/measure/index/ProjectMeasuresIndexTest.java +++ b/server/sonar-webserver-es/src/test/java/org/sonar/server/measure/index/ProjectMeasuresIndexTest.java @@ -1664,7 +1664,7 @@ public class ProjectMeasuresIndexTest { ProjectMeasuresStatistics result = underTest.searchTelemetryStatistics(); - assertThat(result.getProjectCount()).isEqualTo(0); + assertThat(result.getProjectCount()).isZero(); assertThat(result.getProjectCountByLanguage()).isEmpty(); } |