diff options
author | belen-pruvost-sonarsource <belen.pruvost@sonarsource.com> | 2021-07-29 07:33:08 +0200 |
---|---|---|
committer | sonartech <sonartech@sonarsource.com> | 2021-08-09 20:03:17 +0000 |
commit | 91559d24f00bbbb682880540a68ac22209473550 (patch) | |
tree | 79ff0db310c78fc4f47a29779f6b24401edbdd1e /server/sonar-webserver-webapi | |
parent | 317192fb5d026725f0ea0f83a9a9f94efa2bd299 (diff) | |
download | sonarqube-91559d24f00bbbb682880540a68ac22209473550.tar.gz sonarqube-91559d24f00bbbb682880540a68ac22209473550.zip |
SONAR-15139 - Update Report Endpoints to work with Projects and Apps
Diffstat (limited to 'server/sonar-webserver-webapi')
12 files changed, 37 insertions, 38 deletions
diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/component/ws/SearchActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/component/ws/SearchActionTest.java index 3ea8807dd0f..1dbe1437862 100644 --- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/component/ws/SearchActionTest.java +++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/component/ws/SearchActionTest.java @@ -64,7 +64,7 @@ import static org.sonar.api.server.ws.WebService.Param.TEXT_QUERY; import static org.sonar.db.component.ComponentTesting.newDirectory; import static org.sonar.db.component.ComponentTesting.newModuleDto; import static org.sonar.db.component.ComponentTesting.newPrivateProjectDto; -import static org.sonar.db.component.ComponentTesting.newView; +import static org.sonar.db.component.ComponentTesting.newPortfolio; import static org.sonar.test.JsonAssert.assertJson; import static org.sonarqube.ws.client.component.ComponentsWsParameters.PARAM_QUALIFIERS; @@ -150,7 +150,7 @@ public class SearchActionTest { public void return_only_projects_on_which_user_has_browse_permission() { ComponentDto project1 = ComponentTesting.newPrivateProjectDto(); ComponentDto project2 = ComponentTesting.newPrivateProjectDto(); - ComponentDto portfolio = ComponentTesting.newView(); + ComponentDto portfolio = ComponentTesting.newPortfolio(); db.components().insertComponents(project1, project2, portfolio); setBrowsePermissionOnUserAndIndex(project1); @@ -208,11 +208,11 @@ public class SearchActionTest { @Test public void test_json_example() { - db.components().insertComponent(newView()); + db.components().insertComponent(newPortfolio()); ComponentDto project = newPrivateProjectDto("project-uuid").setName("Project Name").setDbKey("project-key"); ComponentDto module = newModuleDto("module-uuid", project).setName("Module Name").setDbKey("module-key"); ComponentDto directory = newDirectory(module, "path/to/directoy").setUuid("directory-uuid").setDbKey("directory-key").setName("Directory Name"); - ComponentDto view = newView(); + ComponentDto view = newPortfolio(); db.components().insertComponents(project, module, directory, view); setBrowsePermissionOnUserAndIndex(project); diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/component/ws/TreeActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/component/ws/TreeActionTest.java index f96beba7f89..d585fb15b4a 100644 --- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/component/ws/TreeActionTest.java +++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/component/ws/TreeActionTest.java @@ -69,7 +69,7 @@ import static org.sonar.db.component.ComponentTesting.newModuleDto; import static org.sonar.db.component.ComponentTesting.newPrivateProjectDto; import static org.sonar.db.component.ComponentTesting.newProjectCopy; import static org.sonar.db.component.ComponentTesting.newSubView; -import static org.sonar.db.component.ComponentTesting.newView; +import static org.sonar.db.component.ComponentTesting.newPortfolio; import static org.sonarqube.ws.client.component.ComponentsWsParameters.PARAM_BRANCH; import static org.sonarqube.ws.client.component.ComponentsWsParameters.PARAM_COMPONENT; import static org.sonarqube.ws.client.component.ComponentsWsParameters.PARAM_PULL_REQUEST; @@ -253,7 +253,7 @@ public class TreeActionTest { @Test public void project_reference_from_portfolio() { - ComponentDto view = newView("view-uuid"); + ComponentDto view = ComponentTesting.newPortfolio("view-uuid"); db.components().insertViewAndSnapshot(view); ComponentDto project = newPrivateProjectDto("project-uuid-1").setName("project-name").setDbKey("project-key-1"); db.components().insertProjectAndSnapshot(project); @@ -315,7 +315,7 @@ public class TreeActionTest { public void return_projects_composing_a_view() { ComponentDto project = newPrivateProjectDto("project-uuid"); db.components().insertProjectAndSnapshot(project); - ComponentDto view = newView("view-uuid"); + ComponentDto view = ComponentTesting.newPortfolio("view-uuid"); db.components().insertViewAndSnapshot(view); ComponentDto projectCopy = db.components().insertComponent(newProjectCopy("project-copy-uuid", project, view)); userSession.logIn() diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/issue/ws/SearchActionComponentsTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/issue/ws/SearchActionComponentsTest.java index 56149cf5a53..cc1f44efce9 100644 --- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/issue/ws/SearchActionComponentsTest.java +++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/issue/ws/SearchActionComponentsTest.java @@ -33,6 +33,7 @@ import org.sonar.api.utils.System2; import org.sonar.db.DbClient; import org.sonar.db.DbTester; import org.sonar.db.component.ComponentDto; +import org.sonar.db.component.ComponentTesting; import org.sonar.db.issue.IssueDto; import org.sonar.db.rule.RuleDefinitionDto; import org.sonar.server.es.EsTester; @@ -72,7 +73,7 @@ import static org.sonar.db.component.ComponentTesting.newFileDto; import static org.sonar.db.component.ComponentTesting.newModuleDto; import static org.sonar.db.component.ComponentTesting.newProjectCopy; import static org.sonar.db.component.ComponentTesting.newSubView; -import static org.sonar.db.component.ComponentTesting.newView; +import static org.sonar.db.component.ComponentTesting.newPortfolio; import static org.sonarqube.ws.client.component.ComponentsWsParameters.PARAM_BRANCH; import static org.sonarqube.ws.client.issue.IssuesWsParameters.PARAM_COMPONENT_KEYS; import static org.sonarqube.ws.client.issue.IssuesWsParameters.PARAM_DIRECTORIES; @@ -369,7 +370,7 @@ public class SearchActionComponentsTest { public void search_by_view_uuid() { ComponentDto project = db.components().insertPublicProject(p -> p.setDbKey("PK1")); ComponentDto file = db.components().insertComponent(newFileDto(project, null, "F1").setDbKey("FK1")); - ComponentDto view = db.components().insertComponent(newView("V1").setDbKey("MyView")); + ComponentDto view = db.components().insertComponent(ComponentTesting.newPortfolio("V1").setDbKey("MyView")); db.components().insertComponent(newProjectCopy(project, view)); RuleDefinitionDto rule = db.rules().insertIssueRule(r -> r.setRuleKey(RuleKey.of("xoo", "x1"))); db.issues().insertIssue(rule, project, file, i -> i.setKee("82fd47d4-b650-4037-80bc-7b112bd4eac2")); @@ -388,7 +389,7 @@ public class SearchActionComponentsTest { ComponentDto file = db.components().insertComponent(newFileDto(project, null, "F1").setDbKey("FK1")); RuleDefinitionDto rule = db.rules().insertIssueRule(r -> r.setRuleKey(RuleKey.of("xoo", "x1"))); db.issues().insertIssue(rule, project, file, i -> i.setKee("82fd47d4-b650-4037-80bc-7b112bd4eac2")); - ComponentDto view = db.components().insertComponent(newView("V1").setDbKey("MyView")); + ComponentDto view = db.components().insertComponent(ComponentTesting.newPortfolio("V1").setDbKey("MyView")); ComponentDto subView = db.components().insertComponent(newSubView(view, "SV1", "MySubView")); db.components().insertComponent(newProjectCopy(project, subView)); allowAnyoneOnProjects(project, view, subView); @@ -406,7 +407,7 @@ public class SearchActionComponentsTest { ComponentDto file = db.components().insertComponent(newFileDto(project, null, "F1").setDbKey("FK1")); RuleDefinitionDto rule = db.rules().insertIssueRule(r -> r.setRuleKey(RuleKey.of("xoo", "x1"))); db.issues().insertIssue(rule, project, file, i -> i.setKee("82fd47d4-b650-4037-80bc-7b112bd4eac2")); - ComponentDto view = db.components().insertComponent(newView("V1").setDbKey("MyView")); + ComponentDto view = db.components().insertComponent(ComponentTesting.newPortfolio("V1").setDbKey("MyView")); ComponentDto subView = db.components().insertComponent(newSubView(view, "SV1", "MySubView")); db.components().insertComponent(newProjectCopy(project, subView)); // User has no permission on the view, no issue will be returned diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/measure/ws/ComponentTreeActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/measure/ws/ComponentTreeActionTest.java index 68280c9bbea..dd9e6d9ecfb 100644 --- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/measure/ws/ComponentTreeActionTest.java +++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/measure/ws/ComponentTreeActionTest.java @@ -35,6 +35,7 @@ import org.sonar.db.DbClient; import org.sonar.db.DbSession; import org.sonar.db.DbTester; import org.sonar.db.component.ComponentDto; +import org.sonar.db.component.ComponentTesting; import org.sonar.db.component.ResourceTypesRule; import org.sonar.db.component.SnapshotDto; import org.sonar.db.measure.LiveMeasureDto; @@ -68,13 +69,12 @@ import static org.sonar.api.resources.Qualifiers.PROJECT; import static org.sonar.api.resources.Qualifiers.UNIT_TEST_FILE; import static org.sonar.api.server.ws.WebService.Param.SORT; import static org.sonar.api.utils.DateUtils.parseDateTime; -import static org.sonar.api.web.UserRole.USER; import static org.sonar.db.component.BranchType.PULL_REQUEST; import static org.sonar.db.component.ComponentTesting.newDirectory; import static org.sonar.db.component.ComponentTesting.newFileDto; import static org.sonar.db.component.ComponentTesting.newProjectCopy; import static org.sonar.db.component.ComponentTesting.newSubView; -import static org.sonar.db.component.ComponentTesting.newView; +import static org.sonar.db.component.ComponentTesting.newPortfolio; import static org.sonar.db.component.SnapshotTesting.newAnalysis; import static org.sonar.server.component.ws.MeasuresWsParameters.ADDITIONAL_PERIOD; import static org.sonar.server.component.ws.MeasuresWsParameters.DEPRECATED_ADDITIONAL_PERIODS; @@ -661,7 +661,7 @@ public class ComponentTreeActionTest { @Test public void portfolio_local_reference_in_portfolio() { - ComponentDto view = db.components().insertComponent(newView("VIEW1-UUID").setDbKey("Apache-Projects").setName("Apache Projects")); + ComponentDto view = db.components().insertComponent(ComponentTesting.newPortfolio("VIEW1-UUID").setDbKey("Apache-Projects").setName("Apache Projects")); ComponentDto view2 = db.components().insertPrivatePortfolio(); ComponentDto localView = db.components().insertComponent( newSubView(view, "SUB-VIEW-UUID", "All-Projects").setName("All projects").setCopyComponentUuid(view2.uuid())); @@ -681,7 +681,7 @@ public class ComponentTreeActionTest { @Test public void application_local_reference_in_portfolio() { - ComponentDto view = db.components().insertComponent(newView("VIEW1-UUID").setDbKey("Apache-Projects").setName("Apache Projects")); + ComponentDto view = db.components().insertComponent(ComponentTesting.newPortfolio("VIEW1-UUID").setDbKey("Apache-Projects").setName("Apache Projects")); ComponentDto application = db.components().insertPrivateApplication(); ComponentDto localView = db.components().insertComponent( newSubView(view, "SUB-VIEW-UUID", "All-Projects").setName("All projects").setCopyComponentUuid(application.uuid())); diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/notification/ws/AddActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/notification/ws/AddActionTest.java index 0f974955889..8f01a41b779 100644 --- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/notification/ws/AddActionTest.java +++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/notification/ws/AddActionTest.java @@ -49,7 +49,7 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; import static org.sonar.api.web.UserRole.USER; -import static org.sonar.db.component.ComponentTesting.newView; +import static org.sonar.db.component.ComponentTesting.newPortfolio; import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_CHANNEL; import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_LOGIN; import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_PROJECT; @@ -306,7 +306,7 @@ public class AddActionTest { public void fail_when_component_is_not_a_project() { UserDto user = db.users().insertUser(); userSession.logIn(user); - db.components().insertViewAndSnapshot(newView().setDbKey("VIEW_1")); + db.components().insertViewAndSnapshot(newPortfolio().setDbKey("VIEW_1")); when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES)); when(dispatchers.getProjectDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES)); diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/notification/ws/RemoveActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/notification/ws/RemoveActionTest.java index 92053d15e56..b202173ba80 100644 --- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/notification/ws/RemoveActionTest.java +++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/notification/ws/RemoveActionTest.java @@ -49,7 +49,7 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThatThrownBy; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; -import static org.sonar.db.component.ComponentTesting.newView; +import static org.sonar.db.component.ComponentTesting.newPortfolio; import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_CHANNEL; import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_LOGIN; import static org.sonar.server.notification.ws.NotificationsWsParameters.PARAM_PROJECT; @@ -284,7 +284,7 @@ public class RemoveActionTest { userSession.logIn(user); when(dispatchers.getGlobalDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES)); when(dispatchers.getProjectDispatchers()).thenReturn(singletonList(NOTIF_MY_NEW_ISSUES)); - db.components().insertViewAndSnapshot(newView().setDbKey("VIEW_1")); + db.components().insertViewAndSnapshot(newPortfolio().setDbKey("VIEW_1")); RemoveRequest request = this.request.setProject("VIEW_1"); assertThatThrownBy(() -> call(request)) diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/permission/ws/AddUserActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/permission/ws/AddUserActionTest.java index b980dd2b2fb..d22b2922a22 100644 --- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/permission/ws/AddUserActionTest.java +++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/permission/ws/AddUserActionTest.java @@ -26,6 +26,7 @@ import org.sonar.api.resources.Qualifiers; import org.sonar.api.resources.ResourceTypes; import org.sonar.api.web.UserRole; import org.sonar.db.component.ComponentDto; +import org.sonar.db.component.ComponentTesting; import org.sonar.db.component.ResourceTypesRule; import org.sonar.db.user.UserDto; import org.sonar.server.exceptions.BadRequestException; @@ -46,7 +47,7 @@ import static org.sonar.db.component.ComponentTesting.newDirectory; import static org.sonar.db.component.ComponentTesting.newFileDto; import static org.sonar.db.component.ComponentTesting.newModuleDto; import static org.sonar.db.component.ComponentTesting.newSubView; -import static org.sonar.db.component.ComponentTesting.newView; +import static org.sonar.db.component.ComponentTesting.newPortfolio; import static org.sonar.db.permission.GlobalPermission.ADMINISTER; import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PERMISSION; import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_PROJECT_ID; @@ -115,7 +116,7 @@ public class AddUserActionTest extends BasePermissionWsTest<AddUserAction> { @Test public void add_permission_to_view() { - ComponentDto view = db.components().insertComponent(newView("view-uuid").setDbKey("view-key")); + ComponentDto view = db.components().insertComponent(ComponentTesting.newPortfolio("view-uuid").setDbKey("view-key")); loginAsAdmin(); newRequest() diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/permission/ws/GroupsActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/permission/ws/GroupsActionTest.java index 52619c4d025..8ae37ef6a59 100644 --- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/permission/ws/GroupsActionTest.java +++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/permission/ws/GroupsActionTest.java @@ -27,6 +27,7 @@ import org.sonar.api.security.DefaultGroups; import org.sonar.api.server.ws.Change; import org.sonar.api.server.ws.WebService.Action; import org.sonar.db.component.ComponentDto; +import org.sonar.db.component.ComponentTesting; import org.sonar.db.component.ResourceTypesRule; import org.sonar.db.user.GroupDto; import org.sonar.server.exceptions.BadRequestException; @@ -46,7 +47,7 @@ import static org.sonar.api.web.UserRole.ADMIN; import static org.sonar.api.web.UserRole.ISSUE_ADMIN; import static org.sonar.core.permission.GlobalPermissions.SCAN_EXECUTION; import static org.sonar.db.component.ComponentTesting.newPrivateProjectDto; -import static org.sonar.db.component.ComponentTesting.newView; +import static org.sonar.db.component.ComponentTesting.newPortfolio; import static org.sonar.db.permission.GlobalPermission.ADMINISTER; import static org.sonar.db.permission.GlobalPermission.SCAN; import static org.sonar.test.JsonAssert.assertJson; @@ -256,7 +257,7 @@ public class GroupsActionTest extends BasePermissionWsTest<GroupsAction> { @Test public void search_groups_on_views() { - ComponentDto view = db.components().insertComponent(newView("view-uuid").setDbKey("view-key")); + ComponentDto view = db.components().insertComponent(ComponentTesting.newPortfolio("view-uuid").setDbKey("view-key")); GroupDto group = db.users().insertGroup("project-group-name"); db.users().insertProjectPermissionOnGroup(group, ISSUE_ADMIN, view); diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/permission/ws/template/BulkApplyTemplateActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/permission/ws/template/BulkApplyTemplateActionTest.java index 0eea5c1d9fe..382a669331e 100644 --- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/permission/ws/template/BulkApplyTemplateActionTest.java +++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/permission/ws/template/BulkApplyTemplateActionTest.java @@ -51,7 +51,7 @@ import static org.sonar.api.resources.Qualifiers.PROJECT; import static org.sonar.api.resources.Qualifiers.VIEW; import static org.sonar.api.utils.DateUtils.parseDate; import static org.sonar.db.component.ComponentTesting.newApplication; -import static org.sonar.db.component.ComponentTesting.newView; +import static org.sonar.db.component.ComponentTesting.newPortfolio; import static org.sonar.db.component.SnapshotTesting.newAnalysis; import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_TEMPLATE_ID; import static org.sonarqube.ws.client.permission.PermissionsWsParameters.PARAM_TEMPLATE_NAME; @@ -158,7 +158,7 @@ public class BulkApplyTemplateActionTest extends BasePermissionWsTest<BulkApplyT public void apply_template_by_qualifiers() { ComponentDto publicProject = db.components().insertPublicProject(); ComponentDto privateProject = db.components().insertPrivateProject(); - ComponentDto view = db.components().insertComponent(newView()); + ComponentDto view = db.components().insertComponent(newPortfolio()); ComponentDto application = db.components().insertComponent(newApplication()); loginAsAdmin(); diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/project/ws/SearchActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/project/ws/SearchActionTest.java index 5c9278d7d9e..8994868ef58 100644 --- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/project/ws/SearchActionTest.java +++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/project/ws/SearchActionTest.java @@ -59,7 +59,7 @@ import static org.sonar.db.component.ComponentTesting.newDirectory; import static org.sonar.db.component.ComponentTesting.newFileDto; import static org.sonar.db.component.ComponentTesting.newModuleDto; import static org.sonar.db.component.ComponentTesting.newPrivateProjectDto; -import static org.sonar.db.component.ComponentTesting.newView; +import static org.sonar.db.component.ComponentTesting.newPortfolio; import static org.sonar.db.component.SnapshotTesting.newAnalysis; import static org.sonar.db.permission.GlobalPermission.ADMINISTER; import static org.sonar.db.permission.GlobalPermission.ADMINISTER_QUALITY_PROFILES; @@ -125,7 +125,7 @@ public class SearchActionTest { userSession.addPermission(ADMINISTER); db.components().insertComponents( ComponentTesting.newPrivateProjectDto().setDbKey(PROJECT_KEY_1), - newView()); + newPortfolio()); SearchWsResponse response = call(SearchRequest.builder().build()); @@ -142,7 +142,7 @@ public class SearchActionTest { db.components().insertComponents( project, module, directory, file, ComponentTesting.newPrivateProjectDto().setDbKey(PROJECT_KEY_2), - newView()); + newPortfolio()); SearchWsResponse response = call(SearchRequest.builder().setQualifiers(singletonList("TRK")).build()); @@ -154,7 +154,7 @@ public class SearchActionTest { userSession.addPermission(ADMINISTER); db.components().insertComponents( ComponentTesting.newPrivateProjectDto().setDbKey(PROJECT_KEY_1), - newView().setDbKey("view1")); + newPortfolio().setDbKey("view1")); SearchWsResponse response = call(SearchRequest.builder().setQualifiers(singletonList("VW")).build()); @@ -166,7 +166,7 @@ public class SearchActionTest { userSession.addPermission(ADMINISTER); db.components().insertComponents( ComponentTesting.newPrivateProjectDto().setDbKey(PROJECT_KEY_1), - newView().setDbKey("view1")); + newPortfolio().setDbKey("view1")); SearchWsResponse response = call(SearchRequest.builder().setQualifiers(asList("TRK", "VW")).build()); diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/project/ws/SearchMyProjectsActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/project/ws/SearchMyProjectsActionTest.java index 7fb5c337b16..d2a9c4736ce 100644 --- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/project/ws/SearchMyProjectsActionTest.java +++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/project/ws/SearchMyProjectsActionTest.java @@ -50,7 +50,6 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThatThrownBy; import static org.sonar.api.measures.CoreMetrics.ALERT_STATUS_KEY; import static org.sonar.db.component.ComponentTesting.newPrivateProjectDto; -import static org.sonar.db.component.ComponentTesting.newView; import static org.sonar.db.component.SnapshotTesting.newAnalysis; import static org.sonar.db.measure.MeasureTesting.newLiveMeasure; import static org.sonar.db.metric.MetricTesting.newMetricDto; @@ -174,7 +173,7 @@ public class SearchMyProjectsActionTest { @Test public void does_not_return_views() { ComponentDto jdk7 = insertJdk7(); - ComponentDto view = insertView(); + ComponentDto view = insertPortfolio(); db.users().insertProjectPermissionOnUser(user, UserRole.ADMIN, jdk7); db.users().insertProjectPermissionOnUser(user, UserRole.ADMIN, view); @@ -260,8 +259,8 @@ public class SearchMyProjectsActionTest { .setDescription("JDK")); } - private ComponentDto insertView() { - return db.components().insertComponent(newView("752d8bfd-420c-4a83-a4e5-8ab19b13c8fc") + private ComponentDto insertPortfolio() { + return db.components().insertPublicPortfolio(p -> p.setUuid("752d8bfd-420c-4a83-a4e5-8ab19b13c8fc") .setName("Java") .setDbKey("Java")); } diff --git a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/setting/ws/SetActionTest.java b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/setting/ws/SetActionTest.java index 234a84829e3..277f4dcf03b 100644 --- a/server/sonar-webserver-webapi/src/test/java/org/sonar/server/setting/ws/SetActionTest.java +++ b/server/sonar-webserver-webapi/src/test/java/org/sonar/server/setting/ws/SetActionTest.java @@ -24,12 +24,10 @@ import com.google.gson.Gson; import com.tngtech.java.junit.dataprovider.DataProvider; import com.tngtech.java.junit.dataprovider.DataProviderRunner; import com.tngtech.java.junit.dataprovider.UseDataProvider; - import java.net.HttpURLConnection; import java.util.List; import java.util.Random; import javax.annotation.Nullable; - import org.junit.Before; import org.junit.Rule; import org.junit.Test; @@ -72,7 +70,6 @@ import static java.util.Collections.singletonList; import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThatThrownBy; import static org.assertj.core.groups.Tuple.tuple; -import static org.sonar.db.component.ComponentTesting.newView; import static org.sonar.db.metric.MetricTesting.newMetricDto; import static org.sonar.db.property.PropertyTesting.newComponentPropertyDto; import static org.sonar.db.property.PropertyTesting.newGlobalPropertyDto; @@ -714,7 +711,7 @@ public class SetActionTest { .defaultValue("default") .onQualifiers(Qualifiers.PROJECT) .build()); - ComponentDto view = db.components().insertComponent(newView("view-uuid")); + ComponentDto view = db.components().insertPublicPortfolio(); i18n.put("qualifier." + Qualifiers.VIEW, "View"); expectedException.expect(BadRequestException.class); expectedException.expectMessage("Setting 'my.key' cannot be set on a View"); |