aboutsummaryrefslogtreecommitdiffstats
path: root/server
diff options
context:
space:
mode:
authorJeremy Davis <jeremy.davis@sonarsource.com>2019-06-21 17:26:14 +0200
committersonartech <sonartech@sonarsource.com>2019-06-28 08:45:49 +0200
commit5ae0cac851b99bca99f8a0dd55ea86d90c12cfe7 (patch)
treed61489882cdcb653568d8d20e2701dd8bc80d52a /server
parente7137e80ff06d817da6eb50fa0e8dc4224e77e49 (diff)
downloadsonarqube-5ae0cac851b99bca99f8a0dd55ea86d90c12cfe7.tar.gz
sonarqube-5ae0cac851b99bca99f8a0dd55ea86d90c12cfe7.zip
SONAR-12189 Make dashes smaller for empty measures
Diffstat (limited to 'server')
-rw-r--r--server/sonar-web/src/main/js/apps/overview/main/Coverage.tsx2
-rw-r--r--server/sonar-web/src/main/js/apps/overview/main/Duplications.tsx2
-rw-r--r--server/sonar-web/src/main/js/apps/overview/main/VulnerabilitiesAndHotspots.tsx2
-rw-r--r--server/sonar-web/src/main/js/apps/overview/main/__tests__/__snapshots__/VulnerabilitiesAndHotspots-test.tsx.snap38
-rw-r--r--server/sonar-web/src/main/js/apps/overview/main/enhance.tsx2
-rw-r--r--server/sonar-web/src/main/js/apps/overview/pullRequests/__tests__/__snapshots__/ReviewApp-test.tsx.snap4
-rw-r--r--server/sonar-web/src/main/js/apps/overview/styles.css1
-rw-r--r--server/sonar-web/src/main/js/apps/portfolio/styles.css1
8 files changed, 26 insertions, 26 deletions
diff --git a/server/sonar-web/src/main/js/apps/overview/main/Coverage.tsx b/server/sonar-web/src/main/js/apps/overview/main/Coverage.tsx
index a335fa06f50..6c7990e42c7 100644
--- a/server/sonar-web/src/main/js/apps/overview/main/Coverage.tsx
+++ b/server/sonar-web/src/main/js/apps/overview/main/Coverage.tsx
@@ -106,7 +106,7 @@ export class Coverage extends React.PureComponent<ComposedProps> {
</DrilldownLink>
</div>
) : (
- <span>—</span>
+ <span className="big">—</span>
);
const newLinesToCover = measures.find(measure => measure.metric.key === 'new_lines_to_cover');
diff --git a/server/sonar-web/src/main/js/apps/overview/main/Duplications.tsx b/server/sonar-web/src/main/js/apps/overview/main/Duplications.tsx
index 30b4c08d570..edc8c195328 100644
--- a/server/sonar-web/src/main/js/apps/overview/main/Duplications.tsx
+++ b/server/sonar-web/src/main/js/apps/overview/main/Duplications.tsx
@@ -106,7 +106,7 @@ export class Duplications extends React.PureComponent<ComposedProps> {
</DrilldownLink>
</div>
) : (
- <span>—</span>
+ <span className="big">—</span>
);
const newLinesMeasure = measures.find(measure => measure.metric.key === 'new_lines');
diff --git a/server/sonar-web/src/main/js/apps/overview/main/VulnerabilitiesAndHotspots.tsx b/server/sonar-web/src/main/js/apps/overview/main/VulnerabilitiesAndHotspots.tsx
index 2802b7796d8..4e021d1bf67 100644
--- a/server/sonar-web/src/main/js/apps/overview/main/VulnerabilitiesAndHotspots.tsx
+++ b/server/sonar-web/src/main/js/apps/overview/main/VulnerabilitiesAndHotspots.tsx
@@ -56,7 +56,7 @@ export class VulnerabiltiesAndHotspots extends React.PureComponent<ComposedProps
</div>
<div className="overview-domain-measure">
<div className="overview-domain-measure-value">
- <span>{this.props.renderIssues('new_security_hotspots', 'SECURITY_HOTSPOT')}</span>
+ {this.props.renderIssues('new_security_hotspots', 'SECURITY_HOTSPOT')}
</div>
<div className="overview-domain-measure-label">
<SecurityHotspotIcon className="little-spacer-right" />
diff --git a/server/sonar-web/src/main/js/apps/overview/main/__tests__/__snapshots__/VulnerabilitiesAndHotspots-test.tsx.snap b/server/sonar-web/src/main/js/apps/overview/main/__tests__/__snapshots__/VulnerabilitiesAndHotspots-test.tsx.snap
index b8c6dc9ddb6..04386abdc13 100644
--- a/server/sonar-web/src/main/js/apps/overview/main/__tests__/__snapshots__/VulnerabilitiesAndHotspots-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/overview/main/__tests__/__snapshots__/VulnerabilitiesAndHotspots-test.tsx.snap
@@ -128,7 +128,7 @@ exports[`should render correctly 1`] = `
className="overview-domain-measure"
>
<div
- className="overview-domain-measure-value overview-domain-measure-value-small"
+ className="overview-domain-measure-value"
>
<Link
onlyActiveOnIndex={false}
@@ -260,27 +260,25 @@ exports[`should render correctly 1`] = `
className="overview-domain-measure"
>
<div
- className="overview-domain-measure-value overview-domain-measure-value-small"
+ className="overview-domain-measure-value"
>
- <span>
- <Link
- onlyActiveOnIndex={false}
- style={Object {}}
- to={
- Object {
- "pathname": "/project/issues",
- "query": Object {
- "id": "my-project",
- "resolved": "false",
- "sinceLeakPeriod": "true",
- "types": "SECURITY_HOTSPOT",
- },
- }
+ <Link
+ onlyActiveOnIndex={false}
+ style={Object {}}
+ to={
+ Object {
+ "pathname": "/project/issues",
+ "query": Object {
+ "id": "my-project",
+ "resolved": "false",
+ "sinceLeakPeriod": "true",
+ "types": "SECURITY_HOTSPOT",
+ },
}
- >
- 10
- </Link>
- </span>
+ }
+ >
+ 10
+ </Link>
</div>
<div
className="overview-domain-measure-label"
diff --git a/server/sonar-web/src/main/js/apps/overview/main/enhance.tsx b/server/sonar-web/src/main/js/apps/overview/main/enhance.tsx
index 72cda201606..e4af5bce6b3 100644
--- a/server/sonar-web/src/main/js/apps/overview/main/enhance.tsx
+++ b/server/sonar-web/src/main/js/apps/overview/main/enhance.tsx
@@ -151,7 +151,7 @@ export default function enhance(ComposedComponent: React.ComponentType<ComposedP
const { branchLike, measures, component } = this.props;
const measure = measures.find(measure => measure.metric.key === metric);
if (!measure) {
- return <span>—</span>;
+ return <span className="big">—</span>;
}
const value = this.getValue(measure);
diff --git a/server/sonar-web/src/main/js/apps/overview/pullRequests/__tests__/__snapshots__/ReviewApp-test.tsx.snap b/server/sonar-web/src/main/js/apps/overview/pullRequests/__tests__/__snapshots__/ReviewApp-test.tsx.snap
index f23c3a895ff..66376718be8 100644
--- a/server/sonar-web/src/main/js/apps/overview/pullRequests/__tests__/__snapshots__/ReviewApp-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/overview/pullRequests/__tests__/__snapshots__/ReviewApp-test.tsx.snap
@@ -425,7 +425,7 @@ exports[`should render correctly for a failed QG 1`] = `
"title": "Foo Bar feature",
}
}
- className="huge"
+ className="overview-domain-measure-value"
component={
Object {
"breadcrumbs": Array [],
@@ -1460,7 +1460,7 @@ exports[`should render correctly for a passed QG 1`] = `
"title": "Foo Bar feature",
}
}
- className="huge"
+ className="overview-domain-measure-value"
component={
Object {
"breadcrumbs": Array [],
diff --git a/server/sonar-web/src/main/js/apps/overview/styles.css b/server/sonar-web/src/main/js/apps/overview/styles.css
index 438648e9c3d..7745bce4e32 100644
--- a/server/sonar-web/src/main/js/apps/overview/styles.css
+++ b/server/sonar-web/src/main/js/apps/overview/styles.css
@@ -543,6 +543,7 @@
.pr-overview-measurements-value .measure-empty {
margin-top: -4px;
+ font-size: var(--bigFontSize);
}
.pr-overview-measurements-rating,
diff --git a/server/sonar-web/src/main/js/apps/portfolio/styles.css b/server/sonar-web/src/main/js/apps/portfolio/styles.css
index 6778e7eca1a..bcc30c9a8e7 100644
--- a/server/sonar-web/src/main/js/apps/portfolio/styles.css
+++ b/server/sonar-web/src/main/js/apps/portfolio/styles.css
@@ -123,6 +123,7 @@
.portfolio-box-rating .rating.no-rating {
color: var(--secondFontColor);
+ font-size: var(--bigFontSize);
}
.portfolio-box-links {